Re: Review Request 48200: Merge function "socket_send_data" logical judgment.

2016-09-06 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48200/#review147803
---


Ship it!




Ship It!

- Vinod Kone


On June 3, 2016, 10:10 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48200/
> ---
> 
> (Updated June 3, 2016, 10:10 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Function "socket_send_data" last logical judgment maybe merge beeter.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/poll_socket.cpp d14dd1a 
> 
> Diff: https://reviews.apache.org/r/48200/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>



Re: Review Request 48200: Merge function "socket_send_data" logical judgment.

2016-06-03 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48200/#review136056
---



Patch looks great!

Reviews applied: [48200]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 3, 2016, 10:10 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48200/
> ---
> 
> (Updated June 3, 2016, 10:10 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Function "socket_send_data" last logical judgment maybe merge beeter.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/poll_socket.cpp d14dd1a 
> 
> Diff: https://reviews.apache.org/r/48200/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>



Review Request 48200: Merge function "socket_send_data" logical judgment.

2016-06-03 Thread Andy Pang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48200/
---

Review request for mesos, Jie Yu and Vinod Kone.


Repository: mesos


Description
---

Function "socket_send_data" last logical judgment maybe merge beeter.


Diffs
-

  3rdparty/libprocess/src/poll_socket.cpp d14dd1a 

Diff: https://reviews.apache.org/r/48200/diff/


Testing
---

make check


Thanks,

Andy Pang