Re: Review Request 48365: Bundled NVML headers for Nvidia GPU support.

2016-06-16 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48365/#review138065
---


Ship it!




This is coming together very nicely!

Now we can build it without external depedencies and we'll pick up the 
dependency at runtime. Are you planning to flip the configure default to have 
the nvidia code enabled by default? That would be great!


configure.ac (line 341)


Weird whitespace here?


- Benjamin Mahler


On June 11, 2016, 3:37 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48365/
> ---
> 
> (Updated June 11, 2016, 3:37 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5552
> https://issues.apache.org/jira/browse/MESOS-5552
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Bundled NVML headers for Nvidia GPU support.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 3622602 
>   3rdparty/Makefile.am fb4a37d 
>   3rdparty/cmake/Versions.cmake 86c51ed 
>   3rdparty/nvml-352.79.tar.gz PRE-CREATION 
>   3rdparty/versions.am 7dcd6bf 
>   configure.ac e344c56 
>   src/Makefile.am b656702 
>   support/install-nvidia-gdk.sh fcb075f 
> 
> Diff: https://reviews.apache.org/r/48365/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 48365: Bundled NVML headers for Nvidia GPU support.

2016-06-10 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48365/
---

(Updated June 11, 2016, 3:37 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Reupload binary data that was missing in the previous revision.


Bugs: MESOS-5552
https://issues.apache.org/jira/browse/MESOS-5552


Repository: mesos


Description
---

Bundled NVML headers for Nvidia GPU support.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 3622602 
  3rdparty/Makefile.am fb4a37d 
  3rdparty/cmake/Versions.cmake 86c51ed 
  3rdparty/nvml-352.79.tar.gz PRE-CREATION 
  3rdparty/versions.am 7dcd6bf 
  configure.ac e344c56 
  src/Makefile.am b656702 
  support/install-nvidia-gdk.sh fcb075f 

Diff: https://reviews.apache.org/r/48365/diff/


Testing
---

GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests


Thanks,

Kevin Klues

Re: Review Request 48365: Bundled NVML headers for Nvidia GPU support.

2016-06-10 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48365/
---

(Updated June 11, 2016, 3:04 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Rebased for https://reviews.apache.org/r/48578


Bugs: MESOS-5552
https://issues.apache.org/jira/browse/MESOS-5552


Repository: mesos


Description
---

Bundled NVML headers for Nvidia GPU support.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 3622602953b31f2f6d0dc5f5cb32fb611e8c3a61 
  3rdparty/Makefile.am fb4a37d50e751703b4ccddb0e004b58560707067 
  3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 
  3rdparty/nvml-352.79.tar.gz PRE-CREATION 
  3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 
  configure.ac e344c56e1be5e232ee331c933b8c04c4c2e55d1e 
  src/Makefile.am b656702d918e747cbd4b3d8f2c4257f61c83b385 
  support/install-nvidia-gdk.sh fcb075f75ef5dade6a05cfafcfb6b3d516764ae6 

Diff: https://reviews.apache.org/r/48365/diff/


Testing
---

GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests


Thanks,

Kevin Klues

Re: Review Request 48365: Bundled NVML headers for Nvidia GPU support.

2016-06-07 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48365/
---

(Updated June 8, 2016, 1:03 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Upload binary data that was missing in the previous revision.


Bugs: MESOS-5552
https://issues.apache.org/jira/browse/MESOS-5552


Repository: mesos


Description
---

Bundled NVML headers for Nvidia GPU support.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 3622602 
  3rdparty/Makefile.am fb4a37d 
  3rdparty/cmake/Versions.cmake 86c51ed 
  3rdparty/nvml-352.79.tar.gz PRE-CREATION 
  3rdparty/versions.am 7dcd6bf 
  configure.ac e344c56 
  src/Makefile.am 29525c9 
  support/install-nvidia-gdk.sh fcb075f 

Diff: https://reviews.apache.org/r/48365/diff/


Testing
---

GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests


Thanks,

Kevin Klues

Review Request 48365: Bundled NVML headers for Nvidia GPU support.

2016-06-07 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48365/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-5552
https://issues.apache.org/jira/browse/MESOS-5552


Repository: mesos


Description
---

Bundled NVML headers for Nvidia GPU support.


Diffs
-

  3rdparty/CMakeLists.txt 3622602953b31f2f6d0dc5f5cb32fb611e8c3a61 
  3rdparty/Makefile.am fb4a37d50e751703b4ccddb0e004b58560707067 
  3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 
  3rdparty/nvml-352.79.tar.gz PRE-CREATION 
  3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 
  configure.ac e344c56e1be5e232ee331c933b8c04c4c2e55d1e 
  src/Makefile.am 29525c960e8fb2448260efdd774fd8fc1d68047b 
  support/install-nvidia-gdk.sh fcb075f75ef5dade6a05cfafcfb6b3d516764ae6 

Diff: https://reviews.apache.org/r/48365/diff/


Testing
---

GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests


Thanks,

Kevin Klues