Re: Review Request 48571: Added assertion for initialization success to the log replica tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48571/#review138353 --- Ship it! Ship It! - Benjamin Mahler On June 15, 2016, 9:03 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48571/ > --- > > (Updated June 15, 2016, 9:03 p.m.) > > > Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and > Neil Conway. > > > Bugs: MESOS-5576 > https://issues.apache.org/jira/browse/MESOS-5576 > > > Repository: mesos > > > Description > --- > > The log replica tests use a tool to set an `EMPTY` replica to `VOTING`. > This tool has a few potential failure cases, and the tool's result > should be checked in tests that expect `VOTING` replicas. > > > Diffs > - > > src/tests/log_tests.cpp 06bf5b8eb0336e015285ef749f50b8ad5be9aa62 > > Diff: https://reviews.apache.org/r/48571/diff/ > > > Testing > --- > > make check > > > Thanks, > > Joseph Wu > >
Re: Review Request 48571: Added assertion for initialization success to the log replica tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48571/#review137933 --- Ship it! Would be cool to explore building a static analysis check to find call-sites where certain values (e.g., `Try`) are returned but the return value is ignored. - Neil Conway On June 15, 2016, 9:03 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48571/ > --- > > (Updated June 15, 2016, 9:03 p.m.) > > > Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and > Neil Conway. > > > Bugs: MESOS-5576 > https://issues.apache.org/jira/browse/MESOS-5576 > > > Repository: mesos > > > Description > --- > > The log replica tests use a tool to set an `EMPTY` replica to `VOTING`. > This tool has a few potential failure cases, and the tool's result > should be checked in tests that expect `VOTING` replicas. > > > Diffs > - > > src/tests/log_tests.cpp 06bf5b8eb0336e015285ef749f50b8ad5be9aa62 > > Diff: https://reviews.apache.org/r/48571/diff/ > > > Testing > --- > > make check > > > Thanks, > > Joseph Wu > >
Re: Review Request 48571: Added assertion for initialization success to the log replica tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48571/ --- (Updated June 15, 2016, 2:03 p.m.) Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and Neil Conway. Changes --- Add JIRA and reviewer. Bugs: MESOS-5576 https://issues.apache.org/jira/browse/MESOS-5576 Repository: mesos Description --- The log replica tests use a tool to set an `EMPTY` replica to `VOTING`. This tool has a few potential failure cases, and the tool's result should be checked in tests that expect `VOTING` replicas. Diffs - src/tests/log_tests.cpp 06bf5b8eb0336e015285ef749f50b8ad5be9aa62 Diff: https://reviews.apache.org/r/48571/diff/ Testing --- make check Thanks, Joseph Wu
Review Request 48571: Added assertion for initialization success to the log replica tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48571/ --- Review request for mesos, Benjamin Mahler, Artem Harutyunyan, and Jie Yu. Repository: mesos Description --- The log replica tests use a tool to set an `EMPTY` replica to `VOTING`. This tool has a few potential failure cases, and the tool's result should be checked in tests that expect `VOTING` replicas. Diffs - src/tests/log_tests.cpp 06bf5b8eb0336e015285ef749f50b8ad5be9aa62 Diff: https://reviews.apache.org/r/48571/diff/ Testing --- make check Thanks, Joseph Wu
