Re: Review Request 48923: Updated test to expect ServiceUnavailable.

2016-06-20 Thread Alexander Rojas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48923/#review138550
---


Ship it!




Ship It!

- Alexander Rojas


On June 20, 2016, 7:51 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48923/
> ---
> 
> (Updated June 20, 2016, 7:51 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, 
> Alexander Rojas, Benjamin Mahler, Greg Mann, and Kapil Arya.
> 
> 
> Bugs: MESOS-5637
> https://issues.apache.org/jira/browse/MESOS-5637
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> StatisticsEndpointGetResourceUsageFailed was expecting an
> InternalServerError but instead it will now receive a
> ServiceUnavailable.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp ad36b74c12e52435b356bced1d15bd33983949e0 
> 
> Diff: https://reviews.apache.org/r/48923/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX and some Linux distros)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>



Re: Review Request 48923: Updated test to expect ServiceUnavailable.

2016-06-20 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48923/#review138539
---


Ship it!




Ship It!

- Alexander Rukletsov


On June 20, 2016, 5:51 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48923/
> ---
> 
> (Updated June 20, 2016, 5:51 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, 
> Alexander Rojas, Benjamin Mahler, Greg Mann, and Kapil Arya.
> 
> 
> Bugs: MESOS-5637
> https://issues.apache.org/jira/browse/MESOS-5637
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> StatisticsEndpointGetResourceUsageFailed was expecting an
> InternalServerError but instead it will now receive a
> ServiceUnavailable.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp ad36b74c12e52435b356bced1d15bd33983949e0 
> 
> Diff: https://reviews.apache.org/r/48923/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX and some Linux distros)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>



Re: Review Request 48923: Updated test to expect ServiceUnavailable.

2016-06-19 Thread Till Toenshoff

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48923/
---

(Updated June 20, 2016, 5:51 a.m.)


Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, 
Alexander Rojas, Benjamin Mahler, Greg Mann, and Kapil Arya.


Bugs: MESOS-5637
https://issues.apache.org/jira/browse/MESOS-5637


Repository: mesos


Description
---

StatisticsEndpointGetResourceUsageFailed was expecting an
InternalServerError but instead it will now receive a
ServiceUnavailable.


Diffs
-

  src/tests/slave_tests.cpp ad36b74c12e52435b356bced1d15bd33983949e0 

Diff: https://reviews.apache.org/r/48923/diff/


Testing (updated)
---

make check (OSX and some Linux distros)


Thanks,

Till Toenshoff



Re: Review Request 48923: Updated test to expect ServiceUnavailable.

2016-06-19 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48923/#review138455
---



Patch looks great!

Reviews applied: [48918, 48919, 48920, 48923]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 19, 2016, 11:37 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48923/
> ---
> 
> (Updated June 19, 2016, 11:37 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, 
> Benjamin Mahler, Greg Mann, and Kapil Arya.
> 
> 
> Bugs: MESOS-5637
> https://issues.apache.org/jira/browse/MESOS-5637
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> StatisticsEndpointGetResourceUsageFailed was expecting an
> InternalServerError but instead it will now receive a
> ServiceUnavailable.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp ad36b74c12e52435b356bced1d15bd33983949e0 
> 
> Diff: https://reviews.apache.org/r/48923/diff/
> 
> 
> Testing
> ---
> 
> make check & functional testing.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>



Review Request 48923: Updated test to expect ServiceUnavailable.

2016-06-19 Thread Till Toenshoff

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48923/
---

Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, 
Benjamin Mahler, Greg Mann, and Kapil Arya.


Bugs: MESOS-5637
https://issues.apache.org/jira/browse/MESOS-5637


Repository: mesos


Description
---

StatisticsEndpointGetResourceUsageFailed was expecting an
InternalServerError but instead it will now receive a
ServiceUnavailable.


Diffs
-

  src/tests/slave_tests.cpp ad36b74c12e52435b356bced1d15bd33983949e0 

Diff: https://reviews.apache.org/r/48923/diff/


Testing
---

make check & functional testing.


Thanks,

Till Toenshoff