Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-20 Thread Zhitao Li 


> On June 20, 2016, 12:34 a.m., Vinod Kone wrote:
> > docs/upgrades.md, line 262
> > 
> >
> > Is libelf a run-time dep as well? I thought it was a build-time dep 
> > only? I'm thinking more and more that we should guard this dep on a config 
> > or run time flag. cc @bmahler.
> 
> Kevin Klues wrote:
> Yes, it's a runtime dependence.  The headers are a build-time dependence 
> and then the library itself is a runtime dependence. Honestly, for this 
> release it's not even necessary to pull in this dependence yet, as none of 
> the committed code uses it yet (other than a test). It is only used for 
> anything substantial by stuff that won't make it until the next release.  If 
> you want me to submit a patch to just remove it for now so we can think about 
> the best way forward for the next release, let me know.

Do we also need this dependency for programsing using libmesos driver 
(scheduler and executore before V1 API)?

In either case, call that out explicitly will help operators.


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48928/#review138506
---


On June 19, 2016, 7:30 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48928/
> ---
> 
> (Updated June 19, 2016, 7:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, haosdent huang, Vinod Kone, and 
> Zhitao Li.
> 
> 
> Bugs: MESOS-5630
> https://issues.apache.org/jira/browse/MESOS-5630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added info about external `libelf` dependence to `upgrades.md`.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 61b7cd3ab45d09f3e4785e00bb8622421952d253 
> 
> Diff: https://reviews.apache.org/r/48928/diff/
> 
> 
> Testing
> ---
> 
> Ran the site docker to verify everything looked OK.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread Kevin Klues 


> On June 20, 2016, 1:59 a.m., haosdent huang wrote:
> > docs/upgrades.md, line 257
> > 
> >
> > I saw the `getting-started.md` use `elfutils-libelf-devel.x86_64`, 
> > seems not match here?

The getting started guide describes what to install as a developer (i.e. the 
headers + the libs). The upgrade guide describes what to install as a user 
(i.e. just the libs).


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48928/#review138513
---


On June 19, 2016, 7:30 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48928/
> ---
> 
> (Updated June 19, 2016, 7:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, haosdent huang, Vinod Kone, and 
> Zhitao Li.
> 
> 
> Bugs: MESOS-5630
> https://issues.apache.org/jira/browse/MESOS-5630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added info about external `libelf` dependence to `upgrades.md`.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 61b7cd3ab45d09f3e4785e00bb8622421952d253 
> 
> Diff: https://reviews.apache.org/r/48928/diff/
> 
> 
> Testing
> ---
> 
> Ran the site docker to verify everything looked OK.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48928/#review138513
---


Fix it, then Ship it!





docs/upgrades.md (line 257)


I saw the `getting-started.md` use `elfutils-libelf-devel.x86_64`, seems 
not match here?


- haosdent huang


On June 19, 2016, 7:30 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48928/
> ---
> 
> (Updated June 19, 2016, 7:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, haosdent huang, Vinod Kone, and 
> Zhitao Li.
> 
> 
> Bugs: MESOS-5630
> https://issues.apache.org/jira/browse/MESOS-5630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added info about external `libelf` dependence to `upgrades.md`.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 61b7cd3ab45d09f3e4785e00bb8622421952d253 
> 
> Diff: https://reviews.apache.org/r/48928/diff/
> 
> 
> Testing
> ---
> 
> Ran the site docker to verify everything looked OK.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread Kevin Klues 


> On June 20, 2016, 12:34 a.m., Vinod Kone wrote:
> > docs/upgrades.md, line 255
> > 
> >
> > s/dependence/dependency/ ?
> > 
> > esp the last occurence in this para.

I can make the change if you like, but what you propose (although colloquially 
used) is not technically correct english in the way I'm using it. A 
"dependence" is the thing you depend on. A "dependency" is the state of being 
dependent on something.

I could say "Mesos 1.0 adds an external dependency to libmesos for `libelf` on 
Linux". And then "Please install this library before upgrading". Does that 
sound better?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48928/#review138506
---


On June 19, 2016, 7:30 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48928/
> ---
> 
> (Updated June 19, 2016, 7:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, haosdent huang, Vinod Kone, and 
> Zhitao Li.
> 
> 
> Bugs: MESOS-5630
> https://issues.apache.org/jira/browse/MESOS-5630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added info about external `libelf` dependence to `upgrades.md`.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 61b7cd3ab45d09f3e4785e00bb8622421952d253 
> 
> Diff: https://reviews.apache.org/r/48928/diff/
> 
> 
> Testing
> ---
> 
> Ran the site docker to verify everything looked OK.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread Kevin Klues 


> On June 20, 2016, 12:34 a.m., Vinod Kone wrote:
> > docs/upgrades.md, line 262
> > 
> >
> > Is libelf a run-time dep as well? I thought it was a build-time dep 
> > only? I'm thinking more and more that we should guard this dep on a config 
> > or run time flag. cc @bmahler.

Yes, it's a runtime dependence.  The headers are a build-time dependence and 
then the library itself is a runtime dependence. Honestly, for this release 
it's not even necessary to pull in this dependence yet, as none of the 
committed code uses it yet (other than a test). It is only used for anything 
substantial by stuff that won't make it until the next release.  If you want me 
to submit a patch to just remove it for now so we can think about the best way 
forward for the next release, let me know.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48928/#review138506
---


On June 19, 2016, 7:30 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48928/
> ---
> 
> (Updated June 19, 2016, 7:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, haosdent huang, Vinod Kone, and 
> Zhitao Li.
> 
> 
> Bugs: MESOS-5630
> https://issues.apache.org/jira/browse/MESOS-5630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added info about external `libelf` dependence to `upgrades.md`.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 61b7cd3ab45d09f3e4785e00bb8622421952d253 
> 
> Diff: https://reviews.apache.org/r/48928/diff/
> 
> 
> Testing
> ---
> 
> Ran the site docker to verify everything looked OK.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48928/#review138506
---




docs/upgrades.md (line 255)


s/dependence/dependency/ ?

esp the last occurence in this para.



docs/upgrades.md (line 262)


Is libelf a run-time dep as well? I thought it was a build-time dep only? 
I'm thinking more and more that we should guard this dep on a config or run 
time flag. cc @bmahler.


- Vinod Kone


On June 19, 2016, 7:30 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48928/
> ---
> 
> (Updated June 19, 2016, 7:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, haosdent huang, Vinod Kone, and 
> Zhitao Li.
> 
> 
> Bugs: MESOS-5630
> https://issues.apache.org/jira/browse/MESOS-5630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added info about external `libelf` dependence to `upgrades.md`.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 61b7cd3ab45d09f3e4785e00bb8622421952d253 
> 
> Diff: https://reviews.apache.org/r/48928/diff/
> 
> 
> Testing
> ---
> 
> Ran the site docker to verify everything looked OK.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48928/
---

Review request for mesos, Benjamin Mahler, haosdent huang, Vinod Kone, and 
Zhitao Li.


Bugs: MESOS-5630
https://issues.apache.org/jira/browse/MESOS-5630


Repository: mesos


Description
---

Added info about external `libelf` dependence to `upgrades.md`.


Diffs
-

  docs/upgrades.md 61b7cd3ab45d09f3e4785e00bb8622421952d253 

Diff: https://reviews.apache.org/r/48928/diff/


Testing
---

Ran the site docker to verify everything looked OK.


Thanks,

Kevin Klues