Re: Review Request 48989: Fixed broken cni isolator test on centos7.

2016-06-22 Thread Qian Zhang 


> On June 22, 2016, 10:20 a.m., Qian Zhang wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp, line 185
> > 
> >
> > I just manually ran a Docker container from 'alpine' image in an RHEL 
> > 7.1 machine, and `/bin/sh -c 'ifconfig'` can work successfully. I thought 
> > there should be no much difference between RHEL and CentOS, so not sure why 
> > it does not work in CentOS ...
> 
> Jie Yu wrote:
> Qian, i think it depends on your shell.
> 
> Gilbert Song wrote:
> Yeah, it really depends on os default PATH. The test would fail or not on 
> diff CentOS 7.x. We encountered similar issues a couple times.

Got it, thanks Jie and Gilbert!


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48989/#review139009
---


On June 23, 2016, 6:54 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48989/
> ---
> 
> (Updated June 23, 2016, 6:54 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Guangya Liu, Artem Harutyunyan, 
> Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-5667
> https://issues.apache.org/jira/browse/MESOS-5667
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed broken cni isolator test on centos7.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> a51f24b0c4946ffe464e55ca1f25a1a38090e094 
> 
> Diff: https://reviews.apache.org/r/48989/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 48989: Fixed broken cni isolator test on centos7.

2016-06-22 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48989/
---

(Updated June 22, 2016, 3:54 p.m.)


Review request for mesos, Avinash sridharan, Guangya Liu, Artem Harutyunyan, 
Jie Yu, and Qian Zhang.


Bugs: MESOS-5667
https://issues.apache.org/jira/browse/MESOS-5667


Repository: mesos


Description
---

Fixed broken cni isolator test on centos7.


Diffs (updated)
-

  src/tests/containerizer/cni_isolator_tests.cpp 
a51f24b0c4946ffe464e55ca1f25a1a38090e094 

Diff: https://reviews.apache.org/r/48989/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 48989: Fixed broken cni isolator test on centos7.

2016-06-22 Thread Gilbert Song 


> On June 21, 2016, 7:20 p.m., Qian Zhang wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp, line 185
> > 
> >
> > I just manually ran a Docker container from 'alpine' image in an RHEL 
> > 7.1 machine, and `/bin/sh -c 'ifconfig'` can work successfully. I thought 
> > there should be no much difference between RHEL and CentOS, so not sure why 
> > it does not work in CentOS ...
> 
> Jie Yu wrote:
> Qian, i think it depends on your shell.

Yeah, it really depends on os default PATH. The test would fail or not on diff 
CentOS 7.x. We encountered similar issues a couple times.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48989/#review139009
---


On June 20, 2016, 7:46 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48989/
> ---
> 
> (Updated June 20, 2016, 7:46 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Guangya Liu, Artem Harutyunyan, 
> Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-5667
> https://issues.apache.org/jira/browse/MESOS-5667
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed broken cni isolator test on centos7.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> a51f24b0c4946ffe464e55ca1f25a1a38090e094 
> 
> Diff: https://reviews.apache.org/r/48989/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 48989: Fixed broken cni isolator test on centos7.

2016-06-22 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48989/#review139090
---


Ship it!




Ship It!

- Jie Yu


On June 21, 2016, 2:46 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48989/
> ---
> 
> (Updated June 21, 2016, 2:46 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Guangya Liu, Artem Harutyunyan, 
> Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-5667
> https://issues.apache.org/jira/browse/MESOS-5667
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed broken cni isolator test on centos7.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> a51f24b0c4946ffe464e55ca1f25a1a38090e094 
> 
> Diff: https://reviews.apache.org/r/48989/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 48989: Fixed broken cni isolator test on centos7.

2016-06-22 Thread Jie Yu 


> On June 22, 2016, 2:20 a.m., Qian Zhang wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp, line 185
> > 
> >
> > I just manually ran a Docker container from 'alpine' image in an RHEL 
> > 7.1 machine, and `/bin/sh -c 'ifconfig'` can work successfully. I thought 
> > there should be no much difference between RHEL and CentOS, so not sure why 
> > it does not work in CentOS ...

Qian, i think it depends on your shell.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48989/#review139009
---


On June 21, 2016, 2:46 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48989/
> ---
> 
> (Updated June 21, 2016, 2:46 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Guangya Liu, Artem Harutyunyan, 
> Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-5667
> https://issues.apache.org/jira/browse/MESOS-5667
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed broken cni isolator test on centos7.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> a51f24b0c4946ffe464e55ca1f25a1a38090e094 
> 
> Diff: https://reviews.apache.org/r/48989/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 48989: Fixed broken cni isolator test on centos7.

2016-06-21 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48989/#review139009
---




src/tests/containerizer/cni_isolator_tests.cpp (line 185)


I just manually ran a Docker container from 'alpine' image in an RHEL 7.1 
machine, and `/bin/sh -c 'ifconfig'` can work successfully. I thought there 
should be no much difference between RHEL and CentOS, so not sure why it does 
not work in CentOS ...


- Qian Zhang


On June 21, 2016, 10:46 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48989/
> ---
> 
> (Updated June 21, 2016, 10:46 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Guangya Liu, Artem Harutyunyan, 
> Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-5667
> https://issues.apache.org/jira/browse/MESOS-5667
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed broken cni isolator test on centos7.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> a51f24b0c4946ffe464e55ca1f25a1a38090e094 
> 
> Diff: https://reviews.apache.org/r/48989/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 48989: Fixed broken cni isolator test on centos7.

2016-06-20 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48989/
---

Review request for mesos, Avinash sridharan, Guangya Liu, Artem Harutyunyan, 
Jie Yu, and Qian Zhang.


Bugs: MESOS-5667
https://issues.apache.org/jira/browse/MESOS-5667


Repository: mesos


Description
---

Fixed broken cni isolator test on centos7.


Diffs
-

  src/tests/containerizer/cni_isolator_tests.cpp 
a51f24b0c4946ffe464e55ca1f25a1a38090e094 

Diff: https://reviews.apache.org/r/48989/diff/


Testing
---

make check


Thanks,

Gilbert Song