Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.

2016-07-05 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49488/#review140944
---


Fix it, then Ship it!




Would fix these minor style nits while committing.


src/master/http.cpp (line 2091)


Added new line before.



src/master/http.cpp (lines 2092 - 2093)


hmm, looks like this was still not fixed.
- 2 space indent before then
- 2 space indent before ->


- Anand Mazumdar


On July 6, 2016, 1:44 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49488/
> ---
> 
> (Updated July 6, 2016, 1:44 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The new helper function will be reused by both `GET_AGENTS`
> and `GET_STATE` calls.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp debedd4a4061034a3b55181e93443b9d5e676c52 
>   src/master/master.hpp 996ff425fc8e9234a5e02560460ad1233dca7061 
> 
> Diff: https://reviews.apache.org/r/49488/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.

2016-07-05 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49488/
---

(Updated July 6, 2016, 1:44 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

Rebase and review comments.


Repository: mesos


Description
---

The new helper function will be reused by both `GET_AGENTS`
and `GET_STATE` calls.


Diffs (updated)
-

  src/master/http.cpp debedd4a4061034a3b55181e93443b9d5e676c52 
  src/master/master.hpp 996ff425fc8e9234a5e02560460ad1233dca7061 

Diff: https://reviews.apache.org/r/49488/diff/


Testing
---

make check


Thanks,

Zhitao Li

Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.

2016-07-05 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49488/#review140912
---


Fix it, then Ship it!





src/master/http.cpp (line 2081)


s/Response/Future to be consistent throughout

Also 
- 2 space indent before then instead of the 4 space indent.
- 2 space indent before ->



src/master/http.cpp (line 2093)


Capture by const ref. Ditto for the declaration.



src/master/http.cpp (line 2125)


Nit: Newline before


- Anand Mazumdar


On July 1, 2016, 11:34 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49488/
> ---
> 
> (Updated July 1, 2016, 11:34 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The new helper function will be reused by both `GET_AGENTS`
> and `GET_STATE` calls.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe 
>   src/master/master.hpp be7cd239c49a0710a29a8187c01484f9f6d615e1 
> 
> Diff: https://reviews.apache.org/r/49488/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.

2016-07-03 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49488/#review140586
---


Ship it!




Looks like you fixed the issues. Not sure why you marked them as dropped? I 
re-opened and marked them as fixed for you.

- Vinod Kone


On July 1, 2016, 11:34 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49488/
> ---
> 
> (Updated July 1, 2016, 11:34 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The new helper function will be reused by both `GET_AGENTS`
> and `GET_STATE` calls.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe 
>   src/master/master.hpp be7cd239c49a0710a29a8187c01484f9f6d615e1 
> 
> Diff: https://reviews.apache.org/r/49488/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.

2016-07-02 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49488/#review140492
---


Ship it!




Ship It!

- haosdent huang


On July 1, 2016, 11:34 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49488/
> ---
> 
> (Updated July 1, 2016, 11:34 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The new helper function will be reused by both `GET_AGENTS`
> and `GET_STATE` calls.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe 
>   src/master/master.hpp be7cd239c49a0710a29a8187c01484f9f6d615e1 
> 
> Diff: https://reviews.apache.org/r/49488/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.

2016-07-01 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49488/
---

(Updated July 1, 2016, 11:34 p.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

Review comments.


Summary (updated)
-

Refactor Master::Http::getAgents into helper function.


Repository: mesos


Description
---

The new helper function will be reused by both `GET_AGENTS`
and `GET_STATE` calls.


Diffs (updated)
-

  src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe 
  src/master/master.hpp be7cd239c49a0710a29a8187c01484f9f6d615e1 

Diff: https://reviews.apache.org/r/49488/diff/


Testing
---

make check


Thanks,

Zhitao Li

Re: Review Request 49488: Refactor master::Http::getAgents into helper function.

2016-07-01 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49488/#review140404
---




src/master/http.cpp (lines 1964 - 1967)


ditto. see comments in earlier review.



src/master/http.cpp (line 1966)


s/getAgentsResp/getAgents/



src/master/http.cpp (line 1983)


space after "="


- Vinod Kone


On July 1, 2016, 2:47 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49488/
> ---
> 
> (Updated July 1, 2016, 2:47 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The new helper function will be reused by both `GET_AGENTS`
> and `GET_STATE` calls.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 528f01f2e00ddbd15da1cc4fca27b5347c9fc798 
>   src/master/master.hpp 7388a3e7f3a0c9f0a2a286a8c8107210971b654a 
> 
> Diff: https://reviews.apache.org/r/49488/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 49488: Refactor master::Http::getAgents into helper function.

2016-06-30 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49488/
---

(Updated July 1, 2016, 2:47 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Summary (updated)
-

Refactor master::Http::getAgents into helper function.


Repository: mesos


Description
---

The new helper function will be reused by both `GET_AGENTS`
and `GET_STATE` calls.


Diffs
-

  src/master/http.cpp 528f01f2e00ddbd15da1cc4fca27b5347c9fc798 
  src/master/master.hpp 7388a3e7f3a0c9f0a2a286a8c8107210971b654a 

Diff: https://reviews.apache.org/r/49488/diff/


Testing
---

make check


Thanks,

Zhitao Li

Re: Review Request 49488: Refactor master::Http::GetAgents into helper function.

2016-06-30 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49488/
---

(Updated July 1, 2016, 2:47 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Repository: mesos


Description
---

The new helper function will be reused by both `GET_AGENTS`
and `GET_STATE` calls.


Diffs
-

  src/master/http.cpp 528f01f2e00ddbd15da1cc4fca27b5347c9fc798 
  src/master/master.hpp 7388a3e7f3a0c9f0a2a286a8c8107210971b654a 

Diff: https://reviews.apache.org/r/49488/diff/


Testing (updated)
---

make check


Thanks,

Zhitao Li

Review Request 49488: Refactor master::Http::GetAgents into helper function.

2016-06-30 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49488/
---

Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Repository: mesos


Description
---

The new helper function will be reused by both `GET_AGENTS`
and `GET_STATE` calls.


Diffs
-

  src/master/http.cpp 528f01f2e00ddbd15da1cc4fca27b5347c9fc798 
  src/master/master.hpp 7388a3e7f3a0c9f0a2a286a8c8107210971b654a 

Diff: https://reviews.apache.org/r/49488/diff/


Testing
---


Thanks,

Zhitao Li