Re: Review Request 49609: Added filtering for orphaned tasks in /state endpoint.

2016-07-05 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49609/#review140938
---




src/master/http.cpp (line 2511)


is this check safe in a new master old agent scenario?


- Vinod Kone


On July 5, 2016, 7:51 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49609/
> ---
> 
> (Updated July 5, 2016, 7:51 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5757
> https://issues.apache.org/jira/browse/MESOS-5757
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering for orphaned tasks in /state endpoint.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe 
> 
> Diff: https://reviews.apache.org/r/49609/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 49609: Added filtering for orphaned tasks in /state endpoint.

2016-07-05 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49609/
---

(Updated July 5, 2016, 7:51 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-5757
https://issues.apache.org/jira/browse/MESOS-5757


Repository: mesos


Description
---

Added filtering for orphaned tasks in /state endpoint.


Diffs (updated)
-

  src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe 

Diff: https://reviews.apache.org/r/49609/diff/


Testing
---

sudo make check


Thanks,

Joerg Schad

Re: Review Request 49609: Added filtering for orphaned tasks in /state endpoint.

2016-07-05 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49609/#review140839
---


Fix it, then Ship it!





src/master/http.cpp (lines 2501 - 2504)


kill this comment.


- Vinod Kone


On July 5, 2016, 8:44 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49609/
> ---
> 
> (Updated July 5, 2016, 8:44 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5757
> https://issues.apache.org/jira/browse/MESOS-5757
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering for orphaned tasks in /state endpoint.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe 
> 
> Diff: https://reviews.apache.org/r/49609/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 49609: Added filtering for orphaned tasks in /state endpoint.

2016-07-05 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49609/#review140743
---



Patch looks great!

Reviews applied: [49606, 49607, 49609]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 5, 2016, 8:44 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49609/
> ---
> 
> (Updated July 5, 2016, 8:44 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5757
> https://issues.apache.org/jira/browse/MESOS-5757
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering for orphaned tasks in /state endpoint.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe 
> 
> Diff: https://reviews.apache.org/r/49609/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 49609: Added filtering for orphaned tasks in /state endpoint.

2016-07-05 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49609/
---

(Updated July 5, 2016, 8:44 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-5757
https://issues.apache.org/jira/browse/MESOS-5757


Repository: mesos


Description
---

Added filtering for orphaned tasks in /state endpoint.


Diffs
-

  src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe 

Diff: https://reviews.apache.org/r/49609/diff/


Testing (updated)
---

sudo make check


Thanks,

Joerg Schad

Review Request 49609: Added filtering for orphaned tasks in /state endpoint.

2016-07-05 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49609/
---

Review request for mesos.


Repository: mesos


Description
---

Added filtering for orphaned tasks in /state endpoint.


Diffs
-

  src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe 

Diff: https://reviews.apache.org/r/49609/diff/


Testing
---


Thanks,

Joerg Schad