Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

[haosdent huang]

> On July 6, 2016, 6:37 p.m., Joerg Schad wrote:
> > src/master/http.cpp, line 1561
> > 
> >
> > s/info/executorInfo ?

Thank you very much. Post a follow up fix at https://reviews.apache.org/r/49865/


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49685/#review141047
---


On July 6, 2016, 6:07 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49685/
> ---
> 
> (Updated July 6, 2016, 6:07 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao 
> Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering for orphaned executors in `GET_EXECUTORS` operator API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 3640486d02f523ee6eb7c40fe959f42260e4cd2d 
> 
> Diff: https://reviews.apache.org/r/49685/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49685/#review141601
---




src/master/http.cpp (line 1557)


Thank you very much. Post a follow up fix at 
https://reviews.apache.org/r/49865/


- haosdent huang


On July 6, 2016, 6:07 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49685/
> ---
> 
> (Updated July 6, 2016, 6:07 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao 
> Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering for orphaned executors in `GET_EXECUTORS` operator API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 3640486d02f523ee6eb7c40fe959f42260e4cd2d 
> 
> Diff: https://reviews.apache.org/r/49685/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49685/#review141047
---


Fix it, then Ship it!





src/master/http.cpp (line 1557)


s/info/executorInfo ?


- Joerg Schad


On July 6, 2016, 6:07 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49685/
> ---
> 
> (Updated July 6, 2016, 6:07 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao 
> Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering for orphaned executors in `GET_EXECUTORS` operator API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 3640486d02f523ee6eb7c40fe959f42260e4cd2d 
> 
> Diff: https://reviews.apache.org/r/49685/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49685/#review141050
---


Ship it!




Ship It!

- Vinod Kone


On July 6, 2016, 6:07 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49685/
> ---
> 
> (Updated July 6, 2016, 6:07 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao 
> Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering for orphaned executors in `GET_EXECUTORS` operator API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 3640486d02f523ee6eb7c40fe959f42260e4cd2d 
> 
> Diff: https://reviews.apache.org/r/49685/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49685/
---

(Updated July 6, 2016, 6:07 p.m.)


Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao 
Li.


Changes
---

Rebase.


Repository: mesos


Description
---

Added filtering for orphaned executors in `GET_EXECUTORS` operator API.


Diffs (updated)
-

  src/master/http.cpp 3640486d02f523ee6eb7c40fe959f42260e4cd2d 

Diff: https://reviews.apache.org/r/49685/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49685/
---

(Updated July 6, 2016, 5:39 p.m.)


Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao 
Li.


Changes
---

Address comments.


Repository: mesos


Description
---

Added filtering for orphaned executors in `GET_EXECUTORS` operator API.


Diffs (updated)
-

  src/master/http.cpp 3640486d02f523ee6eb7c40fe959f42260e4cd2d 

Diff: https://reviews.apache.org/r/49685/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49685/#review141018
---




src/master/http.cpp (line 1548)


This would mean when upgrading (i.e., old agent and new master) we would 
show no orphaned tasks even though authz was disabled. 
We added a more complex logic for this depractation period (should be 
immediately removed afterwards as I don't like the added complexity too much 
:-)). See https://reviews.apache.org/r/49697/diff/2/


- Joerg Schad


On July 6, 2016, 9:30 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49685/
> ---
> 
> (Updated July 6, 2016, 9:30 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao 
> Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering for orphaned executors in `GET_EXECUTORS` operator API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 3640486d02f523ee6eb7c40fe959f42260e4cd2d 
> 
> Diff: https://reviews.apache.org/r/49685/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49685/
---

(Updated July 6, 2016, 9:30 a.m.)


Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao 
Li.


Changes
---

Address @vinodkone's comments.


Repository: mesos


Description
---

Added filtering for orphaned executors in `GET_EXECUTORS` operator API.


Diffs (updated)
-

  src/master/http.cpp 3640486d02f523ee6eb7c40fe959f42260e4cd2d 

Diff: https://reviews.apache.org/r/49685/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

[Joerg Schad]

> On July 6, 2016, 4 a.m., Vinod Kone wrote:
> > src/master/http.cpp, line 1505
> > 
> >
> > don't think this check works for new master old agent case?

Agree, that won't work if old agent reregisters with new master


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49685/#review140936
---


On July 6, 2016, 3:43 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49685/
> ---
> 
> (Updated July 6, 2016, 3:43 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao 
> Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering for orphaned executors in `GET_EXECUTORS` operator API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp debedd4a4061034a3b55181e93443b9d5e676c52 
> 
> Diff: https://reviews.apache.org/r/49685/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49685/#review140936
---




src/master/http.cpp (line 1501)


don't think this check works for new master old agent case?


- Vinod Kone


On July 6, 2016, 3:43 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49685/
> ---
> 
> (Updated July 6, 2016, 3:43 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao 
> Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering for orphaned executors in `GET_EXECUTORS` operator API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp debedd4a4061034a3b55181e93443b9d5e676c52 
> 
> Diff: https://reviews.apache.org/r/49685/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49685/
---

(Updated July 6, 2016, 3:43 a.m.)


Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao 
Li.


Changes
---

Rebase.


Summary (updated)
-

Added filtering for orphaned executors in `GET_EXECUTORS` operator API.


Repository: mesos


Description (updated)
---

Added filtering for orphaned executors in `GET_EXECUTORS` operator API.


Diffs (updated)
-

  src/master/http.cpp debedd4a4061034a3b55181e93443b9d5e676c52 

Diff: https://reviews.apache.org/r/49685/diff/


Testing
---


Thanks,

haosdent huang