Re: Review Request 49686: Added filtering for orphaned tasks in `GET_TASKS` operator API.

2016-07-06 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49686/#review141051
---


Ship it!




Ship It!

- Vinod Kone


On July 6, 2016, 6:08 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49686/
> ---
> 
> (Updated July 6, 2016, 6:08 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao 
> Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering for orphaned tasks in `GET_TASKS` operator API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 3640486d02f523ee6eb7c40fe959f42260e4cd2d 
> 
> Diff: https://reviews.apache.org/r/49686/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49686: Added filtering for orphaned tasks in `GET_TASKS` operator API.

2016-07-06 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49686/
---

(Updated July 6, 2016, 6:08 p.m.)


Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao 
Li.


Changes
---

Rebase.


Repository: mesos


Description
---

Added filtering for orphaned tasks in `GET_TASKS` operator API.


Diffs (updated)
-

  src/master/http.cpp 3640486d02f523ee6eb7c40fe959f42260e4cd2d 

Diff: https://reviews.apache.org/r/49686/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49686: Added filtering for orphaned tasks in `GET_TASKS` operator API.

2016-07-06 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49686/
---

(Updated July 6, 2016, 5:39 p.m.)


Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao 
Li.


Changes
---

Address comments.


Repository: mesos


Description
---

Added filtering for orphaned tasks in `GET_TASKS` operator API.


Diffs (updated)
-

  src/master/http.cpp 3640486d02f523ee6eb7c40fe959f42260e4cd2d 

Diff: https://reviews.apache.org/r/49686/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49686: Added filtering for orphaned tasks in `GET_TASKS` operator API.

2016-07-06 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49686/#review141021
---




src/master/http.cpp (line 3605)


see joerg's comment in the previous review.


- Vinod Kone


On July 6, 2016, 9:30 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49686/
> ---
> 
> (Updated July 6, 2016, 9:30 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao 
> Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering for orphaned tasks in `GET_TASKS` operator API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 3640486d02f523ee6eb7c40fe959f42260e4cd2d 
> 
> Diff: https://reviews.apache.org/r/49686/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49686: Added filtering for orphaned tasks in `GET_TASKS` operator API.

2016-07-06 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49686/
---

(Updated July 6, 2016, 9:30 a.m.)


Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao 
Li.


Changes
---

Address @vinodkone's comments.


Repository: mesos


Description
---

Added filtering for orphaned tasks in `GET_TASKS` operator API.


Diffs (updated)
-

  src/master/http.cpp 3640486d02f523ee6eb7c40fe959f42260e4cd2d 

Diff: https://reviews.apache.org/r/49686/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49686: Added filtering for orphaned tasks in `GET_TASKS` operator API.

2016-07-05 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49686/#review140937
---




src/master/http.cpp (line 3491)


ditto. check is not safe i think.


- Vinod Kone


On July 6, 2016, 3:44 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49686/
> ---
> 
> (Updated July 6, 2016, 3:44 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao 
> Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering for orphaned tasks in `GET_TASKS` operator API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp debedd4a4061034a3b55181e93443b9d5e676c52 
> 
> Diff: https://reviews.apache.org/r/49686/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 49686: Added filtering for orphaned tasks in `GET_TASKS` operator API.

2016-07-05 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49686/
---

Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao 
Li.


Repository: mesos


Description
---

Added filtering for orphaned tasks in `GET_TASKS` operator API.


Diffs
-

  src/master/http.cpp debedd4a4061034a3b55181e93443b9d5e676c52 

Diff: https://reviews.apache.org/r/49686/diff/


Testing
---


Thanks,

haosdent huang