Re: Review Request 51808: Moved OfferEqMatcher to the single test file where it is used.

2016-09-13 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51808/
---

(Updated Sept. 13, 2016, 10:24 a.m.)


Review request for mesos and Michael Park.


Changes
---

Rebase, reorder reviews.


Repository: mesos


Description
---

Moved OfferEqMatcher to the single test file where it is used.


Diffs (updated)
-

  src/tests/master_allocator_tests.cpp 7eed672be14f116d0aa5058da98a1db3a146dad9 
  src/tests/mesos.hpp 92d7d94733d461eb0c565830cc1c8e709e7a2ef7 

Diff: https://reviews.apache.org/r/51808/diff/


Testing
---

`make check` on OSX and Linux.


Thanks,

Neil Conway



Re: Review Request 51808: Moved OfferEqMatcher to the single test file where it is used.

2016-09-13 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51808/#review148675
---


Ship it!




Ship It!

- Michael Park


On Sept. 12, 2016, 2:41 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51808/
> ---
> 
> (Updated Sept. 12, 2016, 2:41 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved OfferEqMatcher to the single test file where it is used.
> 
> 
> Diffs
> -
> 
>   src/tests/master_allocator_tests.cpp 
> 7eed672be14f116d0aa5058da98a1db3a146dad9 
>   src/tests/mesos.hpp 9bcdaf19833d08ccfbfe4781179f8626e141a7e1 
> 
> Diff: https://reviews.apache.org/r/51808/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX and Linux.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Review Request 51808: Moved OfferEqMatcher to the single test file where it is used.

2016-09-12 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51808/
---

Review request for mesos and Michael Park.


Repository: mesos


Description
---

Moved OfferEqMatcher to the single test file where it is used.


Diffs
-

  src/tests/master_allocator_tests.cpp 7eed672be14f116d0aa5058da98a1db3a146dad9 
  src/tests/mesos.hpp 9bcdaf19833d08ccfbfe4781179f8626e141a7e1 

Diff: https://reviews.apache.org/r/51808/diff/


Testing
---

`make check` on OSX and Linux.


Thanks,

Neil Conway