Re: Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

2016-09-26 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51825/
---

(Updated Sept. 26, 2016, 5:12 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
Wu, Kevin Klues, and Vinod Kone.


Bugs: MESOS-6073
https://issues.apache.org/jira/browse/MESOS-6073


Repository: mesos


Description
---

We are using '.' as a separator. If we have a nested container "yyy"
under its parent container "xxx". Then, the streaming function will
print it out as "xxx.yyy".


Diffs (updated)
-

  src/common/type_utils.cpp 9cb6274231bc373e796dc8e91e9340025b57ad1e 

Diff: https://reviews.apache.org/r/51825/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

2016-09-25 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51825/#review150334
---


Ship it!




Ship It!

- Jie Yu


On Sept. 24, 2016, 6:50 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51825/
> ---
> 
> (Updated Sept. 24, 2016, 6:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
> Wu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6073
> https://issues.apache.org/jira/browse/MESOS-6073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We are using '.' as a separator. If we have a nested container "yyy"
> under its parent container "xxx". Then, the streaming function will
> print it out as "xxx.yyy".
> 
> 
> Diffs
> -
> 
>   src/common/type_utils.cpp 9cb6274231bc373e796dc8e91e9340025b57ad1e 
> 
> Diff: https://reviews.apache.org/r/51825/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

2016-09-24 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51825/
---

(Updated Sept. 24, 2016, 11:50 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
Wu, Kevin Klues, and Vinod Kone.


Bugs: MESOS-6073
https://issues.apache.org/jira/browse/MESOS-6073


Repository: mesos


Description (updated)
---

We are using '.' as a separator. If we have a nested container "yyy"
under its parent container "xxx". Then, the streaming function will
print it out as "xxx.yyy".


Diffs (updated)
-

  src/common/type_utils.cpp 9cb6274231bc373e796dc8e91e9340025b57ad1e 

Diff: https://reviews.apache.org/r/51825/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

2016-09-15 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51825/#review149158
---



Bad patch!

Reviews applied: [51825, 51816, 51780, 51779, 51778, 51421, 51770, 51420, 
51503, 51402, 51393, 51392, 51323]

Failed command: ./support/apply-review.sh -n -r 51778

Error:
2016-09-16 00:18:37 URL:https://reviews.apache.org/r/51778/diff/raw/ [469/469] 
-> "51778.patch" [1]
error: patch failed: src/slave/containerizer/mesos/provisioner/paths.cpp:20
error: src/slave/containerizer/mesos/provisioner/paths.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/15266/console

- Mesos ReviewBot


On Sept. 15, 2016, 7:46 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51825/
> ---
> 
> (Updated Sept. 15, 2016, 7:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
> Wu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6073
> https://issues.apache.org/jira/browse/MESOS-6073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the streaming function for ContainerID to be nesting aware.
> 
> 
> Diffs
> -
> 
>   src/common/type_utils.cpp c7d50334b4e56bc0eb5473b9f9277465b607334f 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 96e24500a12825161553eb050da389088b122695 
> 
> Diff: https://reviews.apache.org/r/51825/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

2016-09-15 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51825/#review149120
---


Ship it!




Ship It!

- Avinash sridharan


On Sept. 15, 2016, 7:46 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51825/
> ---
> 
> (Updated Sept. 15, 2016, 7:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
> Wu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6073
> https://issues.apache.org/jira/browse/MESOS-6073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the streaming function for ContainerID to be nesting aware.
> 
> 
> Diffs
> -
> 
>   src/common/type_utils.cpp c7d50334b4e56bc0eb5473b9f9277465b607334f 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 96e24500a12825161553eb050da389088b122695 
> 
> Diff: https://reviews.apache.org/r/51825/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

2016-09-15 Thread Gilbert Song 


> On Sept. 15, 2016, 12:22 p.m., Avinash sridharan wrote:
> > src/common/type_utils.cpp, line 417
> > 
> >
> > Can we use "." instead of "/" as the delimiter. Reason being that in 
> > `network/cni` isolator we plan to use the stringified version of 
> > `ContainerID` to create directories for containers. This would result in 
> > creating a hierarchy. Using "." instead of "/" would prevent it from 
> > creating hierarchies. Also, recreating `ContainerID` from a flat hierarchy 
> > structure, would much more cleaner.

We will have the recreate mothod later. :)


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51825/#review149116
---


On Sept. 15, 2016, 12:46 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51825/
> ---
> 
> (Updated Sept. 15, 2016, 12:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
> Wu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6073
> https://issues.apache.org/jira/browse/MESOS-6073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the streaming function for ContainerID to be nesting aware.
> 
> 
> Diffs
> -
> 
>   src/common/type_utils.cpp c7d50334b4e56bc0eb5473b9f9277465b607334f 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 96e24500a12825161553eb050da389088b122695 
> 
> Diff: https://reviews.apache.org/r/51825/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

2016-09-15 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51825/
---

(Updated Sept. 15, 2016, 12:46 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
Wu, Kevin Klues, and Vinod Kone.


Bugs: MESOS-6073
https://issues.apache.org/jira/browse/MESOS-6073


Repository: mesos


Description
---

Updated the streaming function for ContainerID to be nesting aware.


Diffs (updated)
-

  src/common/type_utils.cpp c7d50334b4e56bc0eb5473b9f9277465b607334f 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
96e24500a12825161553eb050da389088b122695 

Diff: https://reviews.apache.org/r/51825/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

2016-09-15 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51825/#review149116
---




src/common/type_utils.cpp (line 417)


Can we use "." instead of "/" as the delimiter. Reason being that in 
`network/cni` isolator we plan to use the stringified version of `ContainerID` 
to create directories for containers. This would result in creating a 
hierarchy. Using "." instead of "/" would prevent it from creating hierarchies. 
Also, recreating `ContainerID` from a flat hierarchy structure, would much more 
cleaner.


- Avinash sridharan


On Sept. 12, 2016, 9:40 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51825/
> ---
> 
> (Updated Sept. 12, 2016, 9:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
> Wu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6073
> https://issues.apache.org/jira/browse/MESOS-6073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the streaming function for ContainerID to be nesting aware.
> 
> 
> Diffs
> -
> 
>   src/common/type_utils.cpp c7d50334b4e56bc0eb5473b9f9277465b607334f 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 96e24500a12825161553eb050da389088b122695 
> 
> Diff: https://reviews.apache.org/r/51825/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

2016-09-12 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51825/#review148637
---



Bad patch!

Reviews applied: [51825, 51816, 51780, 51779, 51778, 51421, 51770, 51420, 
51503, 51402, 51393, 51392, 51323]

Failed command: ./support/apply-review.sh -n -r 51778

Error:
2016-09-13 02:02:28 URL:https://reviews.apache.org/r/51778/diff/raw/ [469/469] 
-> "51778.patch" [1]
error: patch failed: src/slave/containerizer/mesos/provisioner/paths.cpp:20
error: src/slave/containerizer/mesos/provisioner/paths.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/15222/console

- Mesos ReviewBot


On Sept. 12, 2016, 9:40 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51825/
> ---
> 
> (Updated Sept. 12, 2016, 9:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
> Wu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6073
> https://issues.apache.org/jira/browse/MESOS-6073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the streaming function for ContainerID to be nesting aware.
> 
> 
> Diffs
> -
> 
>   src/common/type_utils.cpp c7d50334b4e56bc0eb5473b9f9277465b607334f 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 96e24500a12825161553eb050da389088b122695 
> 
> Diff: https://reviews.apache.org/r/51825/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

2016-09-12 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51825/
---

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
Wu, Kevin Klues, and Vinod Kone.


Bugs: MESOS-6073
https://issues.apache.org/jira/browse/MESOS-6073


Repository: mesos


Description
---

Updated the streaming function for ContainerID to be nesting aware.


Diffs
-

  src/common/type_utils.cpp c7d50334b4e56bc0eb5473b9f9277465b607334f 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
96e24500a12825161553eb050da389088b122695 

Diff: https://reviews.apache.org/r/51825/diff/


Testing
---

make check


Thanks,

Gilbert Song