Re: Review Request 52185: Do not need to erase task if it not in pendingTasks.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52185/#review151258
---




src/master/master.cpp (line 4111)


Dont think this change is necessary. I would rather have all the removals 
related to pending (framework map and slave map) in one place.


- Vinod Kone


On Sept. 23, 2016, 2:43 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52185/
> ---
> 
> (Updated Sept. 23, 2016, 2:43 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If task has not been in hashmap pendingTasks, indicate it has been erase, so 
> don't need to erase twice.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 66a672f 
> 
> Diff: https://reviews.apache.org/r/52185/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 52185: Do not need to erase task if it not in pendingTasks.

[Vinod Kone]

> On Oct. 3, 2016, 11:50 p.m., Vinod Kone wrote:
> > src/master/master.cpp, line 4112
> > 
> >
> > Dont think this change is necessary. I would rather have all the 
> > removals related to pending (framework map and slave map) in one place.

Please discard this review if you agree.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52185/#review151258
---


On Sept. 23, 2016, 2:43 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52185/
> ---
> 
> (Updated Sept. 23, 2016, 2:43 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If task has not been in hashmap pendingTasks, indicate it has been erase, so 
> don't need to erase twice.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 66a672f 
> 
> Diff: https://reviews.apache.org/r/52185/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 52185: Do not need to erase task if it not in pendingTasks.

[Andy Pang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52185/
---

(Updated 九月 23, 2016, 2:43 a.m.)


Review request for mesos, Jie Yu and Vinod Kone.


Repository: mesos


Description
---

If task has not been in hashmap pendingTasks, indicate it has been erase, so 
don't need to erase twice.


Diffs (updated)
-

  src/master/master.cpp 66a672f 

Diff: https://reviews.apache.org/r/52185/diff/


Testing
---

make check


Thanks,

Andy Pang

Review Request 52185: Do not need to erase task if it not in pendingTasks.

[Andy Pang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52185/
---

Review request for mesos, Jie Yu and Vinod Kone.


Repository: mesos


Description
---

If task has not been in hashmap pendingTasks, indicate it has been erase, so 
don't need to erase twice.


Diffs
-

  src/master/master.cpp 66a672f 

Diff: https://reviews.apache.org/r/52185/diff/


Testing
---

make check


Thanks,

Andy Pang