Re: Review Request 52459: Ignored error in posix launcher destroy if the container is unknown.

2016-09-30 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52459/#review151105
---


Ship it!




Ship It!

- Gilbert Song


On Sept. 30, 2016, 4:17 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52459/
> ---
> 
> (Updated Sept. 30, 2016, 4:17 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is consistent to what we do in linux launcher. A container can be
> destroyed in launcher but not yet fully cleaned up in isolators. If
> agent restarts, we should still allow the cleanup of those containers.
> So launcher should ignore destroy request for unknown containers.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launcher.cpp 
> 5d1410da40128c365c581ced11eff954a1f5627e 
> 
> Diff: https://reviews.apache.org/r/52459/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Review Request 52459: Ignored error in posix launcher destroy if the container is unknown.

2016-09-30 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52459/
---

Review request for mesos, Benjamin Hindman and Gilbert Song.


Repository: mesos


Description
---

This is consistent to what we do in linux launcher. A container can be
destroyed in launcher but not yet fully cleaned up in isolators. If
agent restarts, we should still allow the cleanup of those containers.
So launcher should ignore destroy request for unknown containers.


Diffs
-

  src/slave/containerizer/mesos/launcher.cpp 
5d1410da40128c365c581ced11eff954a1f5627e 

Diff: https://reviews.apache.org/r/52459/diff/


Testing
---

make check


Thanks,

Jie Yu