Review Request 52817: Added utils method to check if `ExecutorInfo` different.

2016-10-12 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52817/
---

Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-6283
https://issues.apache.org/jira/browse/MESOS-6283


Repository: mesos


Description
---

Added utils method to check if `ExecutorInfo` different.


Diffs
-

  include/mesos/type_utils.hpp 1d09b4fb5d8db8005506a12e7a179f46ee376ca2 
  src/common/type_utils.cpp cad243f7222e93030fa5a9c00955e9ef55f3c805 

Diff: https://reviews.apache.org/r/52817/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 52817: Added utils method to check if `ExecutorInfo` different.

2016-10-14 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52817/#review152756
---




src/common/type_utils.cpp (line 327)


didn't realize there is this new patch when i commited this chain!

anyway, i think  you can kill the if loop and change return to

```
return left.has_type() == right.has_type() &&
   (!left.has_type() || left.type() = right.type()) &&
    &&
   . &&
```

this is how we do optional field checks. see examples in this file.


- Vinod Kone


On Oct. 13, 2016, 6:36 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52817/
> ---
> 
> (Updated Oct. 13, 2016, 6:36 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6283
> https://issues.apache.org/jira/browse/MESOS-6283
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added utils method to check if `ExecutorInfo` different.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp 1d09b4fb5d8db8005506a12e7a179f46ee376ca2 
>   src/common/type_utils.cpp cad243f7222e93030fa5a9c00955e9ef55f3c805 
> 
> Diff: https://reviews.apache.org/r/52817/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 52817: Added utils method to check if `ExecutorInfo` different.

2016-10-14 Thread haosdent huang 


> On Oct. 14, 2016, 11:09 p.m., Vinod Kone wrote:
> > src/common/type_utils.cpp, line 327
> > 
> >
> > didn't realize there is this new patch when i commited this chain!
> > 
> > anyway, i think  you can kill the if loop and change return to
> > 
> > ```
> > return left.has_type() == right.has_type() &&
> >(!left.has_type() || left.type() = right.type()) &&
> > &&
> >. &&
> > ```
> > 
> > this is how we do optional field checks. see examples in this file.

Sorry, I should update the ticket next time. A follow up fix 
https://reviews.apache.org/r/52906/


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52817/#review152756
---


On Oct. 13, 2016, 6:36 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52817/
> ---
> 
> (Updated Oct. 13, 2016, 6:36 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6283
> https://issues.apache.org/jira/browse/MESOS-6283
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added utils method to check if `ExecutorInfo` different.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp 1d09b4fb5d8db8005506a12e7a179f46ee376ca2 
>   src/common/type_utils.cpp cad243f7222e93030fa5a9c00955e9ef55f3c805 
> 
> Diff: https://reviews.apache.org/r/52817/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>