Re: Review Request 52946: Fixed some bugs in the CLI help formatting.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52946/#review167429 --- Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On Oct. 20, 2016, 6:11 p.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52946/ > --- > > (Updated Oct. 20, 2016, 6:11 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5676 > https://issues.apache.org/jira/browse/MESOS-5676 > > > Repository: mesos > > > Description > --- > > Fixed some bugs in the CLI help formatting. > > > Diffs > - > > src/cli_new/lib/mesos/plugins/base.py > 61b15428b029cec9ec7c9d89ab949959c3dc5b88 > src/cli_new/lib/mesos/util.py 87d2a65e78f04209566c1434b489b941d570ee01 > > > Diff: https://reviews.apache.org/r/52946/diff/2/ > > > Testing > --- > > > Thanks, > > Kevin Klues > >
Re: Review Request 52946: Fixed some bugs in the CLI help formatting.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52946/#review153836 --- Can you describe what is broken in the description? It's not obvious why the flags formatting needs to change, nor why the order of the options matters. - Joseph Wu On Oct. 20, 2016, 11:11 a.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52946/ > --- > > (Updated Oct. 20, 2016, 11:11 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5676 > https://issues.apache.org/jira/browse/MESOS-5676 > > > Repository: mesos > > > Description > --- > > Fixed some bugs in the CLI help formatting. > > > Diffs > - > > src/cli_new/lib/mesos/plugins/base.py > 61b15428b029cec9ec7c9d89ab949959c3dc5b88 > src/cli_new/lib/mesos/util.py 87d2a65e78f04209566c1434b489b941d570ee01 > > Diff: https://reviews.apache.org/r/52946/diff/ > > > Testing > --- > > > Thanks, > > Kevin Klues > >
Re: Review Request 52946: Fixed some bugs in the CLI help formatting.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52946/ --- (Updated Oct. 20, 2016, 6:11 p.m.) Review request for mesos and Joseph Wu. Changes --- Rebased Bugs: MESOS-5676 https://issues.apache.org/jira/browse/MESOS-5676 Repository: mesos Description --- Fixed some bugs in the CLI help formatting. Diffs (updated) - src/cli_new/lib/mesos/plugins/base.py 61b15428b029cec9ec7c9d89ab949959c3dc5b88 src/cli_new/lib/mesos/util.py 87d2a65e78f04209566c1434b489b941d570ee01 Diff: https://reviews.apache.org/r/52946/diff/ Testing --- Thanks, Kevin Klues
Review Request 52946: Fixed some bugs in the CLI help formatting.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52946/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5676 https://issues.apache.org/jira/browse/MESOS-5676 Repository: mesos Description --- Fixed some bugs in the CLI help formatting. Diffs - src/cli_new/lib/mesos/plugins/base.py 61b15428b029cec9ec7c9d89ab949959c3dc5b88 src/cli_new/lib/mesos/util.py 87d2a65e78f04209566c1434b489b941d570ee01 Diff: https://reviews.apache.org/r/52946/diff/ Testing --- Thanks, Kevin Klues