Re: Review Request 53082: Refactored `ROOT_CGROUPS_CreateRemove` test case.

2017-03-01 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53082/#review167436
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Oct. 28, 2016, 5:14 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53082/
> ---
> 
> (Updated Oct. 28, 2016, 5:14 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch makes `ROOT_CGROUPS_CreateRemove` create cgroups with
> `TEST_CGROUPS_ROOT` prefix in name to ensure cgroups would be clean up
> during tear down.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_tests.cpp 
> 0afaec6ae948cabf1472bf01103210d8f9809cb1 
> 
> 
> Diff: https://reviews.apache.org/r/53082/diff/3/
> 
> 
> Testing
> ---
> 
> ```
> sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*CGROUPS*" --verbose
> sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 53082: Refactored `ROOT_CGROUPS_CreateRemove` test case.

2016-10-27 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53082/
---

(Updated Oct. 28, 2016, 5:14 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Jiang Yan Xu.


Changes
---

Rebase.


Repository: mesos


Description
---

This patch makes `ROOT_CGROUPS_CreateRemove` create cgroups with
`TEST_CGROUPS_ROOT` prefix in name to ensure cgroups would be clean up
during tear down.


Diffs (updated)
-

  src/tests/containerizer/cgroups_tests.cpp 
0afaec6ae948cabf1472bf01103210d8f9809cb1 

Diff: https://reviews.apache.org/r/53082/diff/


Testing
---

```
sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*CGROUPS*" --verbose
sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose
```


Thanks,

haosdent huang



Re: Review Request 53082: Refactored `ROOT_CGROUPS_CreateRemove` test case.

2016-10-24 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53082/
---

(Updated Oct. 24, 2016, 2:39 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Jiang Yan Xu.


Changes
---

Rebase.


Repository: mesos


Description
---

This patch makes `ROOT_CGROUPS_CreateRemove` create cgroups with
`TEST_CGROUPS_ROOT` prefix in name to ensure cgroups would be clean up
during tear down.


Diffs (updated)
-

  src/tests/containerizer/cgroups_tests.cpp 
0afaec6ae948cabf1472bf01103210d8f9809cb1 

Diff: https://reviews.apache.org/r/53082/diff/


Testing
---

```
sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*CGROUPS*" --verbose
sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose
```


Thanks,

haosdent huang



Re: Review Request 53082: Refactored `ROOT_CGROUPS_CreateRemove` test case.

2016-10-21 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53082/
---

(Updated Oct. 22, 2016, 4:18 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Jiang Yan Xu.


Repository: mesos


Description
---

This patch makes `ROOT_CGROUPS_CreateRemove` create cgroups with
`TEST_CGROUPS_ROOT` prefix in name to ensure cgroups would be clean up
during tear down.


Diffs
-

  src/tests/containerizer/cgroups_tests.cpp 
0afaec6ae948cabf1472bf01103210d8f9809cb1 

Diff: https://reviews.apache.org/r/53082/diff/


Testing (updated)
---

```
sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*CGROUPS*" --verbose
sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose
```


Thanks,

haosdent huang



Review Request 53082: Refactored `ROOT_CGROUPS_CreateRemove` test case.

2016-10-21 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53082/
---

Review request for mesos.


Repository: mesos


Description
---

This patch makes `ROOT_CGROUPS_CreateRemove` create cgroups with
`TEST_CGROUPS_ROOT` prefix in name to ensure cgroups would be clean up
during tear down.


Diffs
-

  src/tests/containerizer/cgroups_tests.cpp 
0afaec6ae948cabf1472bf01103210d8f9809cb1 

Diff: https://reviews.apache.org/r/53082/diff/


Testing
---


Thanks,

haosdent huang