Re: Review Request 53463: Inlined '_status' method in MesosContainerizer as a lambda.

2016-11-07 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53463/#review155182
---


Ship it!




LGTM module kevin's comment.

- Vinod Kone


On Nov. 4, 2016, 7:07 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53463/
> ---
> 
> (Updated Nov. 4, 2016, 7:07 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: MESOS-6528
> https://issues.apache.org/jira/browse/MESOS-6528
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Inlined '_status' method in MesosContainerizer as a lambda.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 67cc595278f124cdf518d2f4fcfb257439f067e2 
> 
> Diff: https://reviews.apache.org/r/53463/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 53463: Inlined '_status' method in MesosContainerizer as a lambda.

2016-11-04 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53463/#review154938
---


Fix it, then Ship it!





src/slave/containerizer/mesos/containerizer.cpp (line 1907)


Do you need the '=' here or is just `containerID` sufficient?


- Kevin Klues


On Nov. 4, 2016, 7:07 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53463/
> ---
> 
> (Updated Nov. 4, 2016, 7:07 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: MESOS-6528
> https://issues.apache.org/jira/browse/MESOS-6528
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Inlined '_status' method in MesosContainerizer as a lambda.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 67cc595278f124cdf518d2f4fcfb257439f067e2 
> 
> Diff: https://reviews.apache.org/r/53463/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 53463: Inlined '_status' method in MesosContainerizer as a lambda.

2016-11-04 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53463/
---

(Updated Nov. 4, 2016, 7:07 a.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Bugs: MESOS-6528
https://issues.apache.org/jira/browse/MESOS-6528


Repository: mesos


Description
---

Inlined '_status' method in MesosContainerizer as a lambda.


Diffs
-

  src/slave/containerizer/mesos/containerizer.cpp 
67cc595278f124cdf518d2f4fcfb257439f067e2 

Diff: https://reviews.apache.org/r/53463/diff/


Testing (updated)
---

make check


Thanks,

Jie Yu

Review Request 53463: Inlined '_status' method in MesosContainerizer as a lambda.

2016-11-04 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53463/
---

Review request for mesos, Kevin Klues and Vinod Kone.


Bugs: MESOS-6528
https://issues.apache.org/jira/browse/MESOS-6528


Repository: mesos


Description
---

Inlined '_status' method in MesosContainerizer as a lambda.


Diffs
-

  src/slave/containerizer/mesos/containerizer.cpp 
67cc595278f124cdf518d2f4fcfb257439f067e2 

Diff: https://reviews.apache.org/r/53463/diff/


Testing
---


Thanks,

Jie Yu