Re: Review Request 53466: Added test to verify container status for nested containers.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53466/
---

(Updated Nov. 8, 2016, 1:51 a.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Bugs: MESOS-6465 and MESOS-6528
https://issues.apache.org/jira/browse/MESOS-6465
https://issues.apache.org/jira/browse/MESOS-6528


Repository: mesos


Description
---

This patch is used to verify that container status is properly set in
task status update for nested containers.


Diffs
-

  src/tests/default_executor_tests.cpp bb954fc48717b2c02abe1c98753b009ec3bb695a 
  src/tests/mesos.hpp f521d22eeafd1901d1acf42c168824b922b68743 

Diff: https://reviews.apache.org/r/53466/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Re: Review Request 53466: Added test to verify container status for nested containers.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53466/
---

(Updated Nov. 8, 2016, 1:06 a.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Bugs: MESOS-6465 and MESOS-6528
https://issues.apache.org/jira/browse/MESOS-6465
https://issues.apache.org/jira/browse/MESOS-6528


Repository: mesos


Description
---

This patch is used to verify that container status is properly set in
task status update for nested containers.


Diffs
-

  src/tests/default_executor_tests.cpp bb954fc48717b2c02abe1c98753b009ec3bb695a 
  src/tests/mesos.hpp f521d22eeafd1901d1acf42c168824b922b68743 

Diff: https://reviews.apache.org/r/53466/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Re: Review Request 53466: Added test to verify container status for nested containers.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53466/
---

(Updated Nov. 8, 2016, 1:05 a.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Bugs: MESOS-6465 and MESOS-6528
https://issues.apache.org/jira/browse/MESOS-6465
https://issues.apache.org/jira/browse/MESOS-6528


Repository: mesos


Description
---

This patch is used to verify that container status is properly set in
task status update for nested containers.


Diffs (updated)
-

  src/tests/default_executor_tests.cpp bb954fc48717b2c02abe1c98753b009ec3bb695a 
  src/tests/mesos.hpp f521d22eeafd1901d1acf42c168824b922b68743 

Diff: https://reviews.apache.org/r/53466/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Re: Review Request 53466: Added test to verify container status for nested containers.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53466/#review155190
---


Ship it!




Ship It!

- Vinod Kone


On Nov. 4, 2016, 7:08 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53466/
> ---
> 
> (Updated Nov. 4, 2016, 7:08 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: MESOS-6465 and MESOS-6528
> https://issues.apache.org/jira/browse/MESOS-6465
> https://issues.apache.org/jira/browse/MESOS-6528
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch is used to verify that container status is properly set in
> task status update for nested containers.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> db953d39a95e7e95871054114a0a9bbeded46224 
>   src/tests/mesos.hpp f521d22eeafd1901d1acf42c168824b922b68743 
> 
> Diff: https://reviews.apache.org/r/53466/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 53466: Added test to verify container status for nested containers.

[Jie Yu]

> On Nov. 4, 2016, 5:53 p.m., Kevin Klues wrote:
> > src/tests/mesos.hpp, lines 1867-1875
> > 
> >
> > This seems like a logically different change that should have its own 
> > commit message explaining why this is changed this way.

Yup, i'll separate it and explain why.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53466/#review154946
---


On Nov. 4, 2016, 7:08 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53466/
> ---
> 
> (Updated Nov. 4, 2016, 7:08 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: MESOS-6465 and MESOS-6528
> https://issues.apache.org/jira/browse/MESOS-6465
> https://issues.apache.org/jira/browse/MESOS-6528
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch is used to verify that container status is properly set in
> task status update for nested containers.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> db953d39a95e7e95871054114a0a9bbeded46224 
>   src/tests/mesos.hpp f521d22eeafd1901d1acf42c168824b922b68743 
> 
> Diff: https://reviews.apache.org/r/53466/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 53466: Added test to verify container status for nested containers.

[Jie Yu]

> On Nov. 4, 2016, 5:53 p.m., Kevin Klues wrote:
> > src/tests/mesos.hpp, line 365
> > 
> >
> > Why is this pulled in if it's now used anywhere? Does some of the macro 
> > magic below actually reference this type?

It's used in the test because we want to do v1::ContainerStatus in the test and 
this is necessary to disambguate with internal::tests::v1 namespace.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53466/#review154946
---


On Nov. 4, 2016, 7:08 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53466/
> ---
> 
> (Updated Nov. 4, 2016, 7:08 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: MESOS-6465 and MESOS-6528
> https://issues.apache.org/jira/browse/MESOS-6465
> https://issues.apache.org/jira/browse/MESOS-6528
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch is used to verify that container status is properly set in
> task status update for nested containers.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> db953d39a95e7e95871054114a0a9bbeded46224 
>   src/tests/mesos.hpp f521d22eeafd1901d1acf42c168824b922b68743 
> 
> Diff: https://reviews.apache.org/r/53466/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 53466: Added test to verify container status for nested containers.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53466/#review154946
---




src/tests/mesos.hpp (line 365)


Why is this pulled in if it's now used anywhere? Does some of the macro 
magic below actually reference this type?



src/tests/mesos.hpp (lines 1867 - 1875)


This seems like a logically different change that should have its own 
commit message explaining why this is changed this way.


- Kevin Klues


On Nov. 4, 2016, 7:08 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53466/
> ---
> 
> (Updated Nov. 4, 2016, 7:08 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: MESOS-6465 and MESOS-6528
> https://issues.apache.org/jira/browse/MESOS-6465
> https://issues.apache.org/jira/browse/MESOS-6528
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch is used to verify that container status is properly set in
> task status update for nested containers.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> db953d39a95e7e95871054114a0a9bbeded46224 
>   src/tests/mesos.hpp f521d22eeafd1901d1acf42c168824b922b68743 
> 
> Diff: https://reviews.apache.org/r/53466/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 53466: Added test to verify container status for nested containers.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53466/
---

Review request for mesos, Kevin Klues and Vinod Kone.


Bugs: MESOS-6465 and MESOS-6528
https://issues.apache.org/jira/browse/MESOS-6465
https://issues.apache.org/jira/browse/MESOS-6528


Repository: mesos


Description
---

This patch is used to verify that container status is properly set in
task status update for nested containers.


Diffs
-

  src/tests/default_executor_tests.cpp db953d39a95e7e95871054114a0a9bbeded46224 
  src/tests/mesos.hpp f521d22eeafd1901d1acf42c168824b922b68743 

Diff: https://reviews.apache.org/r/53466/diff/


Testing
---

sudo make check


Thanks,

Jie Yu