Re: Review Request 53467: Added ContainerStatus.container_id to JSON endpoints.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53467/
---

(Updated Nov. 8, 2016, 1:05 a.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Bugs: MESOS-6465 and MESOS-6528
https://issues.apache.org/jira/browse/MESOS-6465
https://issues.apache.org/jira/browse/MESOS-6528


Repository: mesos


Description
---

Added ContainerStatus.container_id to JSON endpoints.


Diffs (updated)
-

  src/common/http.cpp fb8454a97ad78c306d17b4222c14d68b3598175d 
  src/tests/slave_tests.cpp 8f1dbef081171421bf2761e24a4f267cbd015d0d 

Diff: https://reviews.apache.org/r/53467/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 53467: Added ContainerStatus.container_id to JSON endpoints.

[Jie Yu]

> On Nov. 7, 2016, 7:41 p.m., Vinod Kone wrote:
> > src/slave/http.cpp, line 1815
> > 
> >
> > why this change? is it backwards compatible?
> > 
> > This method is called by `getContainers()` which is part of v1 API and 
> > we try to avoid calling hand coded `model` functions from v1.

It is backward compatible becasue model basically does protobuf to json 
conversion, except for ContainerID, which we want to use `x.y.z` rather than a 
strcutured container ID json.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53467/#review155191
---


On Nov. 4, 2016, 7:40 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53467/
> ---
> 
> (Updated Nov. 4, 2016, 7:40 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: MESOS-6465 and MESOS-6528
> https://issues.apache.org/jira/browse/MESOS-6465
> https://issues.apache.org/jira/browse/MESOS-6528
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ContainerStatus.container_id to JSON endpoints.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp c2398177c9e5af12c7a20c02e92d3f3036a7a39a 
>   src/common/http.cpp fb8454a97ad78c306d17b4222c14d68b3598175d 
>   src/slave/http.cpp a32aca437cffd52bc2bcde859eedddca2038e3f1 
>   src/tests/slave_tests.cpp 8f1dbef081171421bf2761e24a4f267cbd015d0d 
> 
> Diff: https://reviews.apache.org/r/53467/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 53467: Added ContainerStatus.container_id to JSON endpoints.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53467/#review155191
---




src/slave/http.cpp (line 1815)


why this change? is it backwards compatible?

This method is called by `getContainers()` which is part of v1 API and we 
try to avoid calling hand coded `model` functions from v1.


- Vinod Kone


On Nov. 4, 2016, 7:40 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53467/
> ---
> 
> (Updated Nov. 4, 2016, 7:40 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: MESOS-6465 and MESOS-6528
> https://issues.apache.org/jira/browse/MESOS-6465
> https://issues.apache.org/jira/browse/MESOS-6528
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ContainerStatus.container_id to JSON endpoints.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp c2398177c9e5af12c7a20c02e92d3f3036a7a39a 
>   src/common/http.cpp fb8454a97ad78c306d17b4222c14d68b3598175d 
>   src/slave/http.cpp a32aca437cffd52bc2bcde859eedddca2038e3f1 
>   src/tests/slave_tests.cpp 8f1dbef081171421bf2761e24a4f267cbd015d0d 
> 
> Diff: https://reviews.apache.org/r/53467/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 53467: Added ContainerStatus.container_id to JSON endpoints.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53467/#review154948
---


Ship it!




Ship It!

- Kevin Klues


On Nov. 4, 2016, 7:40 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53467/
> ---
> 
> (Updated Nov. 4, 2016, 7:40 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: MESOS-6465 and MESOS-6528
> https://issues.apache.org/jira/browse/MESOS-6465
> https://issues.apache.org/jira/browse/MESOS-6528
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ContainerStatus.container_id to JSON endpoints.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp c2398177c9e5af12c7a20c02e92d3f3036a7a39a 
>   src/common/http.cpp fb8454a97ad78c306d17b4222c14d68b3598175d 
>   src/slave/http.cpp a32aca437cffd52bc2bcde859eedddca2038e3f1 
>   src/tests/slave_tests.cpp 8f1dbef081171421bf2761e24a4f267cbd015d0d 
> 
> Diff: https://reviews.apache.org/r/53467/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 53467: Added ContainerStatus.container_id to JSON endpoints.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53467/#review154903
---



Patch looks great!

Reviews applied: [53463, 53464, 53465, 53466, 53467]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Nov. 4, 2016, 7:40 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53467/
> ---
> 
> (Updated Nov. 4, 2016, 7:40 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: MESOS-6465 and MESOS-6528
> https://issues.apache.org/jira/browse/MESOS-6465
> https://issues.apache.org/jira/browse/MESOS-6528
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ContainerStatus.container_id to JSON endpoints.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp c2398177c9e5af12c7a20c02e92d3f3036a7a39a 
>   src/common/http.cpp fb8454a97ad78c306d17b4222c14d68b3598175d 
>   src/slave/http.cpp a32aca437cffd52bc2bcde859eedddca2038e3f1 
>   src/tests/slave_tests.cpp 8f1dbef081171421bf2761e24a4f267cbd015d0d 
> 
> Diff: https://reviews.apache.org/r/53467/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 53467: Added ContainerStatus.container_id to JSON endpoints.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53467/
---

Review request for mesos, Kevin Klues and Vinod Kone.


Bugs: MESOS-6465 and MESOS-6528
https://issues.apache.org/jira/browse/MESOS-6465
https://issues.apache.org/jira/browse/MESOS-6528


Repository: mesos


Description
---

Added ContainerStatus.container_id to JSON endpoints.


Diffs
-

  src/common/http.hpp c2398177c9e5af12c7a20c02e92d3f3036a7a39a 
  src/common/http.cpp fb8454a97ad78c306d17b4222c14d68b3598175d 
  src/slave/http.cpp a32aca437cffd52bc2bcde859eedddca2038e3f1 
  src/tests/slave_tests.cpp 8f1dbef081171421bf2761e24a4f267cbd015d0d 

Diff: https://reviews.apache.org/r/53467/diff/


Testing
---

make check


Thanks,

Jie Yu