Re: Review Request 53491: WIP Disabled tests relying on filtering HTTP events.

2016-11-04 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53491/#review155000
---



Patch looks great!

Reviews applied: [53481, 53482, 53483, 53484, 53485, 53486, 53487, 53488, 
53489, 53490, 53491]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Nov. 4, 2016, 5:54 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53491/
> ---
> 
> (Updated Nov. 4, 2016, 5:54 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6466
> https://issues.apache.org/jira/browse/MESOS-6466
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a placeholder patch to make review bot happy. Some tests
> that rely on filtering HTTP events based on type won't work now
> since the request body is not yet known when `visit()` is invoked.
> I am working on fixing these.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 3143af15cf7a589e3f469b8e07f0b398e252ee79 
>   src/tests/slave_recovery_tests.cpp cc50498040986e9aca1031df3622b13e7a44218a 
> 
> Diff: https://reviews.apache.org/r/53491/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Review Request 53491: WIP Disabled tests relying on filtering HTTP events.

2016-11-04 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53491/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-6466
https://issues.apache.org/jira/browse/MESOS-6466


Repository: mesos


Description
---

This is a placeholder patch to make review bot happy. Some tests
that rely on filtering HTTP events based on type won't work now
since the request body is not yet known when `visit()` is invoked.
I am working on fixing these.


Diffs
-

  src/tests/master_tests.cpp 3143af15cf7a589e3f469b8e07f0b398e252ee79 
  src/tests/slave_recovery_tests.cpp cc50498040986e9aca1031df3622b13e7a44218a 

Diff: https://reviews.apache.org/r/53491/diff/


Testing
---

make check


Thanks,

Anand Mazumdar