Re: Review Request 53510: Removed extraneous socket argument from `DataDecoder` constructor.

2016-11-10 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53510/
---

(Updated Nov. 10, 2016, 10:04 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Review comments, NNFR


Bugs: MESOS-6466
https://issues.apache.org/jira/browse/MESOS-6466


Repository: mesos


Description
---

This argument is not used anywhere in the code. This makes it
consistent with the streaming request decoder.


Diffs (updated)
-

  3rdparty/libprocess/src/decoder.hpp 76dca0b272af8591880ef220ec2dc006906fbc36 

Diff: https://reviews.apache.org/r/53510/diff/


Testing
---


Thanks,

Anand Mazumdar

Re: Review Request 53510: Removed extraneous socket argument from `DataDecoder` constructor.

2016-11-08 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53510/#review155348
---


Fix it, then Ship it!




Ship It!


3rdparty/libprocess/src/decoder.hpp (line 25)


Can you remove this now?


- Benjamin Mahler


On Nov. 8, 2016, 8:22 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53510/
> ---
> 
> (Updated Nov. 8, 2016, 8:22 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6466
> https://issues.apache.org/jira/browse/MESOS-6466
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This argument is not used anywhere in the code. This makes it
> consistent with the streaming request decoder.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/decoder.hpp 
> 76dca0b272af8591880ef220ec2dc006906fbc36 
> 
> Diff: https://reviews.apache.org/r/53510/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 53510: Removed extraneous socket argument from `DataDecoder` constructor.

2016-11-08 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53510/
---

(Updated Nov. 8, 2016, 8:22 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Updated Deps


Bugs: MESOS-6466
https://issues.apache.org/jira/browse/MESOS-6466


Repository: mesos


Description
---

This argument is not used anywhere in the code. This makes it
consistent with the streaming request decoder.


Diffs (updated)
-

  3rdparty/libprocess/src/decoder.hpp 76dca0b272af8591880ef220ec2dc006906fbc36 

Diff: https://reviews.apache.org/r/53510/diff/


Testing
---


Thanks,

Anand Mazumdar

Review Request 53510: Removed extraneous socket argument from `DataDecoder` constructor.

2016-11-04 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53510/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-6466
https://issues.apache.org/jira/browse/MESOS-6466


Repository: mesos


Description
---

This argument is not used anywhere in the code. This makes it
consistent with the streaming request decoder.


Diffs
-

  3rdparty/libprocess/src/decoder.hpp 76dca0b272af8591880ef220ec2dc006906fbc36 

Diff: https://reviews.apache.org/r/53510/diff/


Testing
---


Thanks,

Anand Mazumdar