Re: Review Request 53604: Added SeccompInfo protobuf message.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53604/#review167491
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 25, 2016, 2:46 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53604/
> ---
> 
> (Updated Nov. 25, 2016, 2:46 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-6581
> https://issues.apache.org/jira/browse/MESOS-6581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added SeccompInfo protobuf message.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05 
>   include/mesos/slave/containerizer.proto 
> 2621522ae59cf9275f607679b4678ac54508993d 
> 
> 
> Diff: https://reviews.apache.org/r/53604/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 53604: Added SeccompInfo protobuf message.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53604/#review157069
---




include/mesos/mesos.proto (line 2067)


Add a reference like what we do in 

```
/**
 * Encapsulation of `Capabilities` supported by Linux.
 * Reference: http://linux.die.net/man/7/capabilities.
 */
message CapabilityInfo {
```

would be better.



include/mesos/mesos.proto (line 2069)


Need add it to `include/mesos/v1/mesos.proto` as well.


- haosdent huang


On Nov. 25, 2016, 2:46 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53604/
> ---
> 
> (Updated Nov. 25, 2016, 2:46 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-6581
> https://issues.apache.org/jira/browse/MESOS-6581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added SeccompInfo protobuf message.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05 
>   include/mesos/slave/containerizer.proto 
> 2621522ae59cf9275f607679b4678ac54508993d 
> 
> Diff: https://reviews.apache.org/r/53604/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 53604: Added SeccompInfo protobuf message.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53604/#review157067
---




include/mesos/mesos.proto (lines 2066 - 2068)


```
 * Encapsulation for Linux seccomp filter.
 * TODO(jay_guo): Consider the compatibility issue stated in MESOS-4997.
 */
```



include/mesos/mesos.proto (line 2067)


I think need add `UNKNOWN = 0;` to all enums.


- haosdent huang


On Nov. 25, 2016, 2:46 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53604/
> ---
> 
> (Updated Nov. 25, 2016, 2:46 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-6581
> https://issues.apache.org/jira/browse/MESOS-6581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added SeccompInfo protobuf message.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05 
>   include/mesos/slave/containerizer.proto 
> 2621522ae59cf9275f607679b4678ac54508993d 
> 
> Diff: https://reviews.apache.org/r/53604/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 53604: Added SeccompInfo protobuf message.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53604/
---

(Updated Nov. 25, 2016, 2:46 p.m.)


Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.


Changes
---

rebase


Bugs: MESOS-6581
https://issues.apache.org/jira/browse/MESOS-6581


Repository: mesos


Description
---

Added SeccompInfo protobuf message.


Diffs (updated)
-

  include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05 
  include/mesos/slave/containerizer.proto 
2621522ae59cf9275f607679b4678ac54508993d 

Diff: https://reviews.apache.org/r/53604/diff/


Testing
---


Thanks,

Jay Guo

Re: Review Request 53604: Added SeccompInfo protobuf message.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53604/
---

(Updated Nov. 14, 2016, 8:09 a.m.)


Review request for mesos and Jie Yu.


Changes
---

rebase


Bugs: MESOS-6581
https://issues.apache.org/jira/browse/MESOS-6581


Repository: mesos


Description
---

Added SeccompInfo protobuf message.


Diffs (updated)
-

  include/mesos/mesos.proto 380575904a5a29ee53bdc87ae8791ed14e3cafca 
  include/mesos/slave/containerizer.proto 
2621522ae59cf9275f607679b4678ac54508993d 

Diff: https://reviews.apache.org/r/53604/diff/


Testing
---


Thanks,

Jay Guo

Re: Review Request 53604: Added SeccompInfo protobuf message.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53604/
---

(Updated Nov. 14, 2016, 4:41 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-6581
https://issues.apache.org/jira/browse/MESOS-6581


Repository: mesos


Description
---

Added SeccompInfo protobuf message.


Diffs (updated)
-

  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
786e47e63dc03ab4851c93ec2030f85c049cebe9 
  3rdparty/stout/include/stout/gzip.hpp 
83010cc1c8c40091fb9805a6bb4c4e427e78ce73 
  3rdparty/stout/include/stout/os/linux.hpp 
530f1a55b89361fc49543c3aa30ac0269b55438e 
  3rdparty/stout/tests/gzip_tests.cpp 05764a43c62e046995566f7f3105fd190b914ff4 
  3rdparty/stout/tests/os/filesystem_tests.cpp 
22460842c0db5dc5b6effbc2bdfce043ed47db6d 
  CHANGELOG ff35fa9cecde4489ff89339e08f17b790431b8e7 
  cmake/MesosConfigure.cmake de04389b016b22bdff69e94d37fad4eedbda5874 
  include/mesos/mesos.proto 380575904a5a29ee53bdc87ae8791ed14e3cafca 
  include/mesos/slave/containerizer.proto 
f4c4ad771b5dead4ea3ee7cd1b4383c4dc2359b4 
  src/cli/execute.cpp b47c427c5ad29dda1985ee8fef6c4efe054df879 
  src/slave/containerizer/mesos/containerizer.cpp 
44225ebf63d8dd93be9b60fff496c74dc6c3a5ad 
  src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
0ce3e1eb16f1b82e02d360f9e6aef6d5dc979010 
  src/slave/containerizer/mesos/provisioner/utils.hpp 
5b6c162fe4ade16131b2207d707e76228b0ec51a 
  src/slave/containerizer/mesos/provisioner/utils.cpp 
7fd7315dda99f49f967a665afe27c8db7835c04c 
  src/tests/containerizer/linux_filesystem_isolator_tests.cpp 
24d1a6971d412aaf7bdc20efcc1197b120de51ce 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
16d7f122e93638f7c6ae28bd7f890787b08ca2b5 

Diff: https://reviews.apache.org/r/53604/diff/


Testing
---


Thanks,

Jay Guo

Review Request 53604: Added SeccompInfo protobuf message.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53604/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-6581
https://issues.apache.org/jira/browse/MESOS-6581


Repository: mesos


Description
---

Added SeccompInfo protobuf message.


Diffs
-

  include/mesos/mesos.proto 380575904a5a29ee53bdc87ae8791ed14e3cafca 
  include/mesos/slave/containerizer.proto 
f4c4ad771b5dead4ea3ee7cd1b4383c4dc2359b4 

Diff: https://reviews.apache.org/r/53604/diff/


Testing
---


Thanks,

Jay Guo