Review Request 53626: Add net::setDomainname() helper API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53626/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6556 https://issues.apache.org/jira/browse/MESOS-6556 Repository: mesos Description --- Add net::setDomainname() helper API. Diffs - 3rdparty/stout/include/stout/posix/net.hpp 39b89828d350d83bf1d4b0badcd3e63eb9d1a630 3rdparty/stout/include/stout/windows/net.hpp 1bed115cb848332bf9c31e455b2d001c173face9 Diff: https://reviews.apache.org/r/53626/diff/ Testing --- make check Thanks, James Peach
Re: Review Request 53626: Add net::setDomainname() helper API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53626/ --- (Updated Nov. 10, 2016, 5:52 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-6556 https://issues.apache.org/jira/browse/MESOS-6556 Repository: mesos Description --- Add net::setDomainname() helper API. Diffs (updated) - 3rdparty/stout/include/stout/posix/net.hpp 39b89828d350d83bf1d4b0badcd3e63eb9d1a630 3rdparty/stout/include/stout/windows/net.hpp 1bed115cb848332bf9c31e455b2d001c173face9 Diff: https://reviews.apache.org/r/53626/diff/ Testing --- make check Thanks, James Peach
Re: Review Request 53626: Add net::setDomainname() helper API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53626/ --- (Updated Nov. 12, 2016, 1:42 a.m.) Review request for mesos and Jie Yu. Bugs: MESOS-6556 https://issues.apache.org/jira/browse/MESOS-6556 Repository: mesos Description --- Add net::setDomainname() helper API. Diffs (updated) - 3rdparty/stout/include/stout/posix/net.hpp 39b89828d350d83bf1d4b0badcd3e63eb9d1a630 3rdparty/stout/include/stout/windows/net.hpp 1bed115cb848332bf9c31e455b2d001c173face9 Diff: https://reviews.apache.org/r/53626/diff/ Testing --- make check Thanks, James Peach
Re: Review Request 53626: Add net::setDomainname() helper API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53626/ --- (Updated Nov. 14, 2016, 6:51 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-6556 https://issues.apache.org/jira/browse/MESOS-6556 Repository: mesos Description --- Add net::setDomainname() helper API. Diffs (updated) - 3rdparty/stout/include/stout/posix/net.hpp 39b89828d350d83bf1d4b0badcd3e63eb9d1a630 3rdparty/stout/include/stout/windows/net.hpp 1bed115cb848332bf9c31e455b2d001c173face9 Diff: https://reviews.apache.org/r/53626/diff/ Testing --- make check Thanks, James Peach
Re: Review Request 53626: Add net::setDomainname() helper API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53626/ --- (Updated Nov. 15, 2016, 5:09 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-6556 https://issues.apache.org/jira/browse/MESOS-6556 Repository: mesos Description --- Add net::setDomainname() helper API. Diffs (updated) - 3rdparty/stout/include/stout/posix/net.hpp 39b89828d350d83bf1d4b0badcd3e63eb9d1a630 3rdparty/stout/include/stout/windows/net.hpp 1bed115cb848332bf9c31e455b2d001c173face9 Diff: https://reviews.apache.org/r/53626/diff/ Testing --- make check Thanks, James Peach
Re: Review Request 53626: Add net::setDomainname() helper API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53626/#review156800 --- Ship it! Looks good to me. Although, I am not sure about the Windows part. - Jie Yu On Nov. 15, 2016, 5:09 p.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53626/ > --- > > (Updated Nov. 15, 2016, 5:09 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6556 > https://issues.apache.org/jira/browse/MESOS-6556 > > > Repository: mesos > > > Description > --- > > Add net::setDomainname() helper API. > > > Diffs > - > > 3rdparty/stout/include/stout/posix/net.hpp > 39b89828d350d83bf1d4b0badcd3e63eb9d1a630 > 3rdparty/stout/include/stout/windows/net.hpp > 1bed115cb848332bf9c31e455b2d001c173face9 > > Diff: https://reviews.apache.org/r/53626/diff/ > > > Testing > --- > > make check > > > Thanks, > > James Peach > >
Re: Review Request 53626: Add net::setDomainname() helper API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53626/ --- (Updated Nov. 28, 2016, 5:08 p.m.) Review request for mesos and Jie Yu. Changes --- Rebased. Bugs: MESOS-6556 https://issues.apache.org/jira/browse/MESOS-6556 Repository: mesos Description --- Add net::setDomainname() helper API. Diffs (updated) - 3rdparty/stout/include/stout/posix/net.hpp 39b89828d350d83bf1d4b0badcd3e63eb9d1a630 3rdparty/stout/include/stout/windows/net.hpp 1bed115cb848332bf9c31e455b2d001c173face9 Diff: https://reviews.apache.org/r/53626/diff/ Testing --- make check Thanks, James Peach
Re: Review Request 53626: Add net::setDomainname() helper API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53626/ --- (Updated Nov. 29, 2016, 9:19 p.m.) Review request for mesos, Alex Clemmer and Jie Yu. Bugs: MESOS-6556 https://issues.apache.org/jira/browse/MESOS-6556 Repository: mesos Description --- Add net::setDomainname() helper API. Diffs (updated) - 3rdparty/stout/include/stout/posix/net.hpp 39b89828d350d83bf1d4b0badcd3e63eb9d1a630 3rdparty/stout/include/stout/windows/net.hpp 1bed115cb848332bf9c31e455b2d001c173face9 Diff: https://reviews.apache.org/r/53626/diff/ Testing --- make check Thanks, James Peach
