Re: Review Request 53770: CMake Cleanup: Alphabetize the list of sources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53770/ --- (Updated Nov. 28, 2016, 10:48 a.m.) Review request for mesos, Alex Clemmer and Joris Van Remoortere. Changes --- Rebase on the switchboard changes. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- This alphabetizes the sources by variable name, and then by filename. A few missing files were added and some duplicate files were removed. Diffs (updated) - src/CMakeLists.txt d6e213686a44fbca0ed841594ce803151224a5a7 Diff: https://reviews.apache.org/r/53770/diff/ Testing --- This being the final review in the chain, I ran the cmake build on several systems: cmake .. make check (OSX) make check (CentOS 7) sudo bin/mesos-tests --gtest_filter="*ROOT*" (CentOS 7) These have reached parity with the automake build configured with `--disable-java --disable-python`. Thanks, Joseph Wu
Re: Review Request 53770: CMake Cleanup: Alphabetize the list of sources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53770/ --- (Updated Nov. 15, 2016, 2:58 p.m.) Review request for mesos, Alex Clemmer and Joris Van Remoortere. Changes --- Remove `SCHED_SRC`. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- This alphabetizes the sources by variable name, and then by filename. A few missing files were added and some duplicate files were removed. Diffs (updated) - src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f Diff: https://reviews.apache.org/r/53770/diff/ Testing --- This being the final review in the chain, I ran the cmake build on several systems: cmake .. make check (OSX) make check (CentOS 7) sudo bin/mesos-tests --gtest_filter="*ROOT*" (CentOS 7) These have reached parity with the automake build configured with `--disable-java --disable-python`. Thanks, Joseph Wu
Re: Review Request 53770: CMake Cleanup: Alphabetize the list of sources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53770/#review155896 --- Patch looks great! Reviews applied: [53327, 53753, 53754, 53755, 53756, 53757, 53758, 53759, 53760, 53761, 53762, 53763, 53764, 53765, 53766, 53767, 53768, 53769, 53770] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Nov. 15, 2016, 3:23 a.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53770/ > --- > > (Updated Nov. 15, 2016, 3:23 a.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > --- > > This alphabetizes the sources by variable name, and then by filename. > A few missing files were added and some duplicate files were removed. > > > Diffs > - > > src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f > > Diff: https://reviews.apache.org/r/53770/diff/ > > > Testing > --- > > This being the final review in the chain, I ran the cmake build on several > systems: > > cmake .. > make check (OSX) > make check (CentOS 7) > > sudo bin/mesos-tests --gtest_filter="*ROOT*" (CentOS 7) > > These have reached parity with the automake build configured with > `--disable-java --disable-python`. > > > Thanks, > > Joseph Wu > >
Review Request 53770: CMake Cleanup: Alphabetize the list of sources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53770/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- This alphabetizes the sources by variable name, and then by filename. A few missing files were added and some duplicate files were removed. Diffs - src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f Diff: https://reviews.apache.org/r/53770/diff/ Testing --- This being the final review in the chain, I ran the cmake build on several systems: cmake .. make check (OSX) make check (CentOS 7) sudo bin/mesos-tests --gtest_filter="*ROOT*" (CentOS 7) These have reached parity with the automake build configured with `--disable-java --disable-python`. Thanks, Joseph Wu
