Re: Review Request 54068: Fixed some nits in hooks interfaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54068/#review156945 --- Patch looks great! Reviews applied: [54038, 54068] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Nov. 25, 2016, 9:38 p.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54068/ > --- > > (Updated Nov. 25, 2016, 9:38 p.m.) > > > Review request for mesos, Adam B, Gastón Kleiman, and Kapil Arya. > > > Bugs: MESOS-6396 > https://issues.apache.org/jira/browse/MESOS-6396 > > > Repository: mesos > > > Description > --- > > see summary > > > Diffs > - > > include/mesos/hook.hpp f0606e3a68fa179cf7ea036f10563ef47c2aefa7 > src/examples/test_hook_module.cpp 5e91a71f2450cf3c37eb9039ef28c026095c917e > src/hook/manager.hpp 5ecfcab48da808c84d36f9bcfcb5a8e0ad2167e5 > src/hook/manager.cpp 24885226a788a7abd851e12b527f74fa972ec935 > > Diff: https://reviews.apache.org/r/54068/diff/ > > > Testing > --- > > make check && functional testing of entire RR chain. > > > Thanks, > > Till Toenshoff > >
Re: Review Request 54068: Fixed some nits in hooks interfaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54068/ --- (Updated Nov. 25, 2016, 9:38 p.m.) Review request for mesos, Adam B, Gastón Kleiman, and Kapil Arya. Bugs: MESOS-6396 https://issues.apache.org/jira/browse/MESOS-6396 Repository: mesos Description --- see summary Diffs (updated) - include/mesos/hook.hpp f0606e3a68fa179cf7ea036f10563ef47c2aefa7 src/examples/test_hook_module.cpp 5e91a71f2450cf3c37eb9039ef28c026095c917e src/hook/manager.hpp 5ecfcab48da808c84d36f9bcfcb5a8e0ad2167e5 src/hook/manager.cpp 24885226a788a7abd851e12b527f74fa972ec935 Diff: https://reviews.apache.org/r/54068/diff/ Testing --- make check && functional testing of entire RR chain. Thanks, Till Toenshoff
Re: Review Request 54068: Fixed some nits in hooks interfaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54068/#review156919 --- Ship it! Ship It! - Gastón Kleiman On Nov. 25, 2016, 4:30 a.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54068/ > --- > > (Updated Nov. 25, 2016, 4:30 a.m.) > > > Review request for mesos, Adam B, Gastón Kleiman, and Kapil Arya. > > > Bugs: MESOS-6396 > https://issues.apache.org/jira/browse/MESOS-6396 > > > Repository: mesos > > > Description > --- > > see summary > > > Diffs > - > > include/mesos/hook.hpp f0606e3a68fa179cf7ea036f10563ef47c2aefa7 > src/examples/test_hook_module.cpp 5e91a71f2450cf3c37eb9039ef28c026095c917e > src/hook/manager.hpp 5ecfcab48da808c84d36f9bcfcb5a8e0ad2167e5 > src/hook/manager.cpp 24885226a788a7abd851e12b527f74fa972ec935 > > Diff: https://reviews.apache.org/r/54068/diff/ > > > Testing > --- > > make check && functional testing of entire RR chain. > > > Thanks, > > Till Toenshoff > >
Re: Review Request 54068: Fixed some nits in hooks interfaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54068/#review156910 --- Patch looks great! Reviews applied: [54038, 54068] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Nov. 25, 2016, 4:30 a.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54068/ > --- > > (Updated Nov. 25, 2016, 4:30 a.m.) > > > Review request for mesos, Adam B, Gastón Kleiman, and Kapil Arya. > > > Bugs: MESOS-6396 > https://issues.apache.org/jira/browse/MESOS-6396 > > > Repository: mesos > > > Description > --- > > see summary > > > Diffs > - > > include/mesos/hook.hpp f0606e3a68fa179cf7ea036f10563ef47c2aefa7 > src/examples/test_hook_module.cpp 5e91a71f2450cf3c37eb9039ef28c026095c917e > src/hook/manager.hpp 5ecfcab48da808c84d36f9bcfcb5a8e0ad2167e5 > src/hook/manager.cpp 24885226a788a7abd851e12b527f74fa972ec935 > > Diff: https://reviews.apache.org/r/54068/diff/ > > > Testing > --- > > make check && functional testing of entire RR chain. > > > Thanks, > > Till Toenshoff > >
Review Request 54068: Fixed some nits in hooks interfaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54068/ --- Review request for mesos, Adam B, Gastón Kleiman, and Kapil Arya. Bugs: MESOS-6396 https://issues.apache.org/jira/browse/MESOS-6396 Repository: mesos Description --- see summary Diffs - include/mesos/hook.hpp f0606e3a68fa179cf7ea036f10563ef47c2aefa7 src/examples/test_hook_module.cpp 5e91a71f2450cf3c37eb9039ef28c026095c917e src/hook/manager.hpp 5ecfcab48da808c84d36f9bcfcb5a8e0ad2167e5 src/hook/manager.cpp 24885226a788a7abd851e12b527f74fa972ec935 Diff: https://reviews.apache.org/r/54068/diff/ Testing --- make check && functional testing of entire RR chain. Thanks, Till Toenshoff
