Re: Review Request 54347: Cleaned up the 'IOSwitchboard.RedirectLog' test.

2016-12-05 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54347/#review158018
---


Ship it!





src/tests/containerizer/io_switchboard_tests.cpp (line 239)


Related to this, we need to fix the agent's `api/v1` handler default 
'Accept' to be `application/json` as it was before. Otherwise, an old client 
relying on it i.e., not setting the header would break un-neccesarily after an 
upgrade.


- Anand Mazumdar


On Dec. 5, 2016, 7:09 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54347/
> ---
> 
> (Updated Dec. 5, 2016, 7:09 a.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up the 'IOSwitchboard.RedirectLog' test.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/io_switchboard_tests.cpp 
> ebf9bc75b8a256847a507954615241cff1da4dc3 
> 
> Diff: https://reviews.apache.org/r/54347/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>



Re: Review Request 54347: Cleaned up the 'IOSwitchboard.RedirectLog' test.

2016-12-04 Thread Kevin Klues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54347/
---

(Updated Dec. 5, 2016, 7:09 a.m.)


Review request for mesos and Anand Mazumdar.


Changes
---

Rebased on master.


Repository: mesos


Description
---

Cleaned up the 'IOSwitchboard.RedirectLog' test.


Diffs (updated)
-

  src/tests/containerizer/io_switchboard_tests.cpp 
ebf9bc75b8a256847a507954615241cff1da4dc3 

Diff: https://reviews.apache.org/r/54347/diff/


Testing
---

make check


Thanks,

Kevin Klues



Re: Review Request 54347: Cleaned up the 'IOSwitchboard.RedirectLog' test.

2016-12-03 Thread Kevin Klues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54347/
---

(Updated Dec. 4, 2016, 12:54 a.m.)


Review request for mesos and Anand Mazumdar.


Changes
---

Updated to remove circular dependency in reviews.


Repository: mesos


Description
---

Cleaned up the 'IOSwitchboard.RedirectLog' test.


Diffs (updated)
-

  src/tests/containerizer/io_switchboard_tests.cpp 
d82f22b5c9a8d177577db3aeaae9e571e7e2fb80 

Diff: https://reviews.apache.org/r/54347/diff/


Testing
---

make check


Thanks,

Kevin Klues



Review Request 54347: Cleaned up the 'IOSwitchboard.RedirectLog' test.

2016-12-03 Thread Kevin Klues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54347/
---

Review request for mesos and Anand Mazumdar.


Repository: mesos


Description
---

Cleaned up the 'IOSwitchboard.RedirectLog' test.


Diffs
-

  src/tests/containerizer/io_switchboard_tests.cpp 
d82f22b5c9a8d177577db3aeaae9e571e7e2fb80 

Diff: https://reviews.apache.org/r/54347/diff/


Testing
---

make check


Thanks,

Kevin Klues