Re: Review Request 54362: Changed master to remove roles for a multi-role framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54362/ --- (Updated Dec. 7, 2016, 4 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang. Bugs: MESOS-6684 https://issues.apache.org/jira/browse/MESOS-6684 Repository: mesos Description --- When a multi-role framework is torn down, it should be removed from internal data structure for every role in this framework. Diffs - src/master/master.cpp b0670d993348d189fafff0f83f9da0c5b18d1c51 Diff: https://reviews.apache.org/r/54362/diff/ Testing --- Thanks, Jay Guo
Re: Review Request 54362: Changed master to remove roles for a multi-role framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54362/#review158173 --- One minor comment is we *must* to commit this one together with https://reviews.apache.org/r/54360 , otherwise, the test `FrameworkInfoValidationTest.AcceptMultiRoleFramework` will be failed when `removeFramework` by `teardown`. - Guangya Liu On 十二月 6, 2016, 1:48 p.m., Jay Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54362/ > --- > > (Updated 十二月 6, 2016, 1:48 p.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang. > > > Bugs: MESOS-6684 > https://issues.apache.org/jira/browse/MESOS-6684 > > > Repository: mesos > > > Description > --- > > When a multi-role framework is torn down, it should be removed from > internal data structure for every role in this framework. > > > Diffs > - > > src/master/master.cpp b0670d993348d189fafff0f83f9da0c5b18d1c51 > > Diff: https://reviews.apache.org/r/54362/diff/ > > > Testing > --- > > > Thanks, > > Jay Guo > >
Re: Review Request 54362: Changed master to remove roles for a multi-role framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54362/#review158160 --- Ship it! Ship It! - Guangya Liu On 十二月 6, 2016, 1:48 p.m., Jay Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54362/ > --- > > (Updated 十二月 6, 2016, 1:48 p.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang. > > > Bugs: MESOS-6684 > https://issues.apache.org/jira/browse/MESOS-6684 > > > Repository: mesos > > > Description > --- > > When a multi-role framework is torn down, it should be removed from > internal data structure for every role in this framework. > > > Diffs > - > > src/master/master.cpp b0670d993348d189fafff0f83f9da0c5b18d1c51 > > Diff: https://reviews.apache.org/r/54362/diff/ > > > Testing > --- > > > Thanks, > > Jay Guo > >
Re: Review Request 54362: Changed master to remove roles for a multi-role framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54362/ --- (Updated Dec. 6, 2016, 1:48 p.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang. Bugs: MESOS-6684 https://issues.apache.org/jira/browse/MESOS-6684 Repository: mesos Description --- When a multi-role framework is torn down, it should be removed from internal data structure for every role in this framework. Diffs (updated) - src/master/master.cpp b0670d993348d189fafff0f83f9da0c5b18d1c51 Diff: https://reviews.apache.org/r/54362/diff/ Testing --- Thanks, Jay Guo
Re: Review Request 54362: Changed master to remove roles for a multi-role framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54362/#review158142 --- I would suggest you merge this with https://reviews.apache.org/r/54360/ as one patch or adjust the order of this one and https://reviews.apache.org/r/54361/ , otherwise, the test cases in https://reviews.apache.org/r/54361/ will be failed as the `removeFramework` check will be failed. - Guangya Liu On 十二月 5, 2016, 7:53 a.m., Jay Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54362/ > --- > > (Updated 十二月 5, 2016, 7:53 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang. > > > Bugs: MESOS-6684 > https://issues.apache.org/jira/browse/MESOS-6684 > > > Repository: mesos > > > Description > --- > > When a multi-role framework is torn down, it should be removed from > internal data structure for every role in this framework. > > > Diffs > - > > src/master/master.cpp b0670d993348d189fafff0f83f9da0c5b18d1c51 > > Diff: https://reviews.apache.org/r/54362/diff/ > > > Testing > --- > > > Thanks, > > Jay Guo > >
Review Request 54362: Changed master to remove roles for a multi-role framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54362/ --- Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang. Bugs: MESOS-6684 https://issues.apache.org/jira/browse/MESOS-6684 Repository: mesos Description --- When a multi-role framework is torn down, it should be removed from internal data structure for every role in this framework. Diffs - src/master/master.cpp b0670d993348d189fafff0f83f9da0c5b18d1c51 Diff: https://reviews.apache.org/r/54362/diff/ Testing --- Thanks, Jay Guo
