Re: Review Request 55546: Added platform-independent constants `DEV_NULL` and `TRUE_COMMAND`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55546/ --- (Updated Jan. 29, 2017, 7:21 a.m.) Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. Changes --- Rearrange dependencies. Repository: mesos Description --- Added platform-independent constants `DEV_NULL` and `TRUE_COMMAND`. Diffs - 3rdparty/stout/include/stout/gtest.hpp a004a378cb467495234d77a0c56fbea6e7bec420 3rdparty/stout/include/stout/os/constants.hpp c71d52e1bc0433f9922f26a6eb486235bb9880d4 Diff: https://reviews.apache.org/r/55546/diff/ Testing --- Thanks, Alex Clemmer
Re: Review Request 55546: Added platform-independent constants `DEV_NULL` and `TRUE_COMMAND`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55546/#review162755 --- Ship it! LGTM, but I'll commit this once I go further in the chain and see the code using these constants. I'll augment the commit body with... ``` `DEV_NULL` will replace occurences of "/dev/null". On Windows, `DEV_NULL` will be "NUL" instead. This is used in the code and tests. `TRUE_COMMAND` will replace occurrences of "true", when used to launch subprocesses in tests. On Windows, `TRUE_COMMAND` will be replaced with `cmd /c exit 0` instead. ``` - Joseph Wu On Jan. 15, 2017, 1:07 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55546/ > --- > > (Updated Jan. 15, 2017, 1:07 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Added platform-independent constants `DEV_NULL` and `TRUE_COMMAND`. > > > Diffs > - > > 3rdparty/stout/include/stout/gtest.hpp > a004a378cb467495234d77a0c56fbea6e7bec420 > 3rdparty/stout/include/stout/os/constants.hpp > c71d52e1bc0433f9922f26a6eb486235bb9880d4 > > Diff: https://reviews.apache.org/r/55546/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Review Request 55546: Added platform-independent constants `DEV_NULL` and `TRUE_COMMAND`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55546/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. Repository: mesos Description --- Added platform-independent constants `DEV_NULL` and `TRUE_COMMAND`. Diffs - 3rdparty/stout/include/stout/gtest.hpp a004a378cb467495234d77a0c56fbea6e7bec420 3rdparty/stout/include/stout/os/constants.hpp c71d52e1bc0433f9922f26a6eb486235bb9880d4 Diff: https://reviews.apache.org/r/55546/diff/ Testing --- Thanks, Alex Clemmer
