Re: Review Request 55896: Stop storing agent flags in the XFS disk isolator.

2017-04-25 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55896/
---

(Updated April 25, 2017, 10:37 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu.


Bugs: MESOS-5116
https://issues.apache.org/jira/browse/MESOS-5116


Repository: mesos


Description
---

We only need the agent work directory so there's no reason
to store a full copy of the agent flags.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/xfs/disk.hpp 
52f0459421a45b01ce38b17c689633301cd97982 
  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
40f1049358ad99d3f213289e36def81c580f07f3 


Diff: https://reviews.apache.org/r/55896/diff/4/

Changes: https://reviews.apache.org/r/55896/diff/3-4/


Testing
---

sudo make check (Fedora 25)


Thanks,

James Peach

Re: Review Request 55896: Stop storing agent flags in the XFS disk isolator.

2017-04-24 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55896/
---

(Updated April 24, 2017, 6:08 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu.


Bugs: MESOS-5116
https://issues.apache.org/jira/browse/MESOS-5116


Repository: mesos


Description
---

We only need the agent work directory so there's no reason
to store a full copy of the agent flags.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/xfs/disk.hpp 
52f0459421a45b01ce38b17c689633301cd97982 
  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
40f1049358ad99d3f213289e36def81c580f07f3 


Diff: https://reviews.apache.org/r/55896/diff/3/

Changes: https://reviews.apache.org/r/55896/diff/2-3/


Testing
---

sudo make check (Fedora 25)


Thanks,

James Peach

Re: Review Request 55896: Stop storing agent flags in the XFS disk isolator.

2017-03-17 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55896/
---

(Updated March 17, 2017, 9:57 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu.


Bugs: MESOS-5116
https://issues.apache.org/jira/browse/MESOS-5116


Repository: mesos


Description
---

We only need the agent work directory so there's no reason
to store a full copy of the agent flags.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/xfs/disk.hpp 
52f0459421a45b01ce38b17c689633301cd97982 
  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
40f1049358ad99d3f213289e36def81c580f07f3 


Diff: https://reviews.apache.org/r/55896/diff/2/

Changes: https://reviews.apache.org/r/55896/diff/1-2/


Testing
---

sudo make check (Fedora 25)


Thanks,

James Peach

Re: Review Request 55896: Stop storing agent flags in the XFS disk isolator.

2017-03-15 Thread Jiang Yan Xu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55896/#review169038
---


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/xfs/disk.cpp
Line 153 (original), 153 (patched)


s/workDir/_workDir/


- Jiang Yan Xu


On Jan. 24, 2017, 5:10 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55896/
> ---
> 
> (Updated Jan. 24, 2017, 5:10 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5116
> https://issues.apache.org/jira/browse/MESOS-5116
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We only need the agent work directory so there's no reason
> to store a full copy of the agent flags.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/xfs/disk.hpp 
> 52f0459421a45b01ce38b17c689633301cd97982 
>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
> dd4df86bf90bfa9cbf4664d89274cf3c64c2e374 
> 
> 
> Diff: https://reviews.apache.org/r/55896/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 55896: Stop storing agent flags in the XFS disk isolator.

2017-01-24 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55896/
---

Review request for mesos, Jie Yu and Jiang Yan Xu.


Bugs: MESOS-5116
https://issues.apache.org/jira/browse/MESOS-5116


Repository: mesos


Description
---

We only need the agent work directory so there's no reason
to store a full copy of the agent flags.


Diffs
-

  src/slave/containerizer/mesos/isolators/xfs/disk.hpp 
52f0459421a45b01ce38b17c689633301cd97982 
  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
dd4df86bf90bfa9cbf4664d89274cf3c64c2e374 

Diff: https://reviews.apache.org/r/55896/diff/


Testing
---

sudo make check (Fedora 25)


Thanks,

James Peach