Re: Review Request 55903: Update XFS disk isolator documentation.

2017-05-11 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55903/#review174755
---



Patch looks great!

Reviews applied: [55896, 55895, 55897, 55903]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 11, 2017, 6:20 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55903/
> ---
> 
> (Updated May 11, 2017, 6:20 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5116
> https://issues.apache.org/jira/browse/MESOS-5116
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update XFS disk isolator documentation.
> 
> 
> Diffs
> -
> 
>   docs/mesos-containerizer.md d0b9d762ab83bff1cf2bd98ed566376b7bd566c6 
> 
> 
> Diff: https://reviews.apache.org/r/55903/diff/6/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 55903: Update XFS disk isolator documentation.

2017-05-11 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55903/
---

(Updated May 11, 2017, 6:20 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu.


Bugs: MESOS-5116
https://issues.apache.org/jira/browse/MESOS-5116


Repository: mesos


Description
---

Update XFS disk isolator documentation.


Diffs (updated)
-

  docs/mesos-containerizer.md d0b9d762ab83bff1cf2bd98ed566376b7bd566c6 


Diff: https://reviews.apache.org/r/55903/diff/6/

Changes: https://reviews.apache.org/r/55903/diff/5-6/


Testing
---

None.


Thanks,

James Peach

Re: Review Request 55903: Update XFS disk isolator documentation.

2017-05-11 Thread Jiang Yan Xu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55903/#review174703
---


Fix it, then Ship it!





docs/mesos-containerizer.md
Lines 103 (patched)


s/only//


- Jiang Yan Xu


On May 11, 2017, 10:55 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55903/
> ---
> 
> (Updated May 11, 2017, 10:55 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5116
> https://issues.apache.org/jira/browse/MESOS-5116
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update XFS disk isolator documentation.
> 
> 
> Diffs
> -
> 
>   docs/mesos-containerizer.md d0b9d762ab83bff1cf2bd98ed566376b7bd566c6 
> 
> 
> Diff: https://reviews.apache.org/r/55903/diff/5/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 55903: Update XFS disk isolator documentation.

2017-05-11 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55903/
---

(Updated May 11, 2017, 5:55 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu.


Bugs: MESOS-5116
https://issues.apache.org/jira/browse/MESOS-5116


Repository: mesos


Description
---

Update XFS disk isolator documentation.


Diffs (updated)
-

  docs/mesos-containerizer.md d0b9d762ab83bff1cf2bd98ed566376b7bd566c6 


Diff: https://reviews.apache.org/r/55903/diff/5/

Changes: https://reviews.apache.org/r/55903/diff/4-5/


Testing
---

None.


Thanks,

James Peach

Re: Review Request 55903: Update XFS disk isolator documentation.

2017-05-10 Thread Jiang Yan Xu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55903/#review173475
---




docs/mesos-containerizer.md
Lines 98-102 (patched)


Updates needed here regarding the implementation of the accounting mode.



docs/mesos-containerizer.md
Lines 113-115 (original), 119-121 (patched)


XFS isolator now does support accounting mode now. :)



docs/mesos-containerizer.md
Line 121 (original), 127 (patched)


I guess you meant s/1000/1/ in your previous version? Should we do that 
because [5000-1] is the default project ID range so the user likely can 
just paste this command to get what they want if they use the isolator.


- Jiang Yan Xu


On April 25, 2017, 3:38 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55903/
> ---
> 
> (Updated April 25, 2017, 3:38 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5116
> https://issues.apache.org/jira/browse/MESOS-5116
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update XFS disk isolator documentation.
> 
> 
> Diffs
> -
> 
>   docs/mesos-containerizer.md d0b9d762ab83bff1cf2bd98ed566376b7bd566c6 
> 
> 
> Diff: https://reviews.apache.org/r/55903/diff/4/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 55903: Update XFS disk isolator documentation.

2017-04-25 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55903/
---

(Updated April 25, 2017, 10:38 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu.


Bugs: MESOS-5116
https://issues.apache.org/jira/browse/MESOS-5116


Repository: mesos


Description
---

Update XFS disk isolator documentation.


Diffs (updated)
-

  docs/mesos-containerizer.md d0b9d762ab83bff1cf2bd98ed566376b7bd566c6 


Diff: https://reviews.apache.org/r/55903/diff/4/

Changes: https://reviews.apache.org/r/55903/diff/3-4/


Testing
---

None.


Thanks,

James Peach

Re: Review Request 55903: Update XFS disk isolator documentation.

2017-04-24 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55903/#review172884
---



Patch looks great!

Reviews applied: [55896, 55895, 55897, 55903]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 17, 2017, 2:57 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55903/
> ---
> 
> (Updated March 17, 2017, 2:57 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5116
> https://issues.apache.org/jira/browse/MESOS-5116
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update XFS disk isolator documentation.
> 
> 
> Diffs
> -
> 
>   docs/mesos-containerizer.md d0b9d762ab83bff1cf2bd98ed566376b7bd566c6 
> 
> 
> Diff: https://reviews.apache.org/r/55903/diff/3/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 55903: Update XFS disk isolator documentation.

2017-03-17 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55903/#review169344
---



Patch looks great!

Reviews applied: [55895, 55896, 55897, 55903]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 17, 2017, 9:57 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55903/
> ---
> 
> (Updated March 17, 2017, 9:57 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5116
> https://issues.apache.org/jira/browse/MESOS-5116
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update XFS disk isolator documentation.
> 
> 
> Diffs
> -
> 
>   docs/mesos-containerizer.md d0b9d762ab83bff1cf2bd98ed566376b7bd566c6 
> 
> 
> Diff: https://reviews.apache.org/r/55903/diff/2/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 55903: Update XFS disk isolator documentation.

2017-03-17 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55903/
---

(Updated March 17, 2017, 9:57 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu.


Bugs: MESOS-5116
https://issues.apache.org/jira/browse/MESOS-5116


Repository: mesos


Description
---

Update XFS disk isolator documentation.


Diffs (updated)
-

  docs/mesos-containerizer.md d0b9d762ab83bff1cf2bd98ed566376b7bd566c6 


Diff: https://reviews.apache.org/r/55903/diff/2/

Changes: https://reviews.apache.org/r/55903/diff/1-2/


Testing
---

None.


Thanks,

James Peach

Re: Review Request 55903: Update XFS disk isolator documentation.

2017-01-25 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55903/#review162943
---



Patch looks great!

Reviews applied: [55895, 55896, 55897, 55903]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Jan. 25, 2017, 1:09 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55903/
> ---
> 
> (Updated Jan. 25, 2017, 1:09 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5116
> https://issues.apache.org/jira/browse/MESOS-5116
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update XFS disk isolator documentation.
> 
> 
> Diffs
> -
> 
>   docs/mesos-containerizer.md d0b9d762ab83bff1cf2bd98ed566376b7bd566c6 
> 
> Diff: https://reviews.apache.org/r/55903/diff/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 55903: Update XFS disk isolator documentation.

2017-01-24 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55903/
---

Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu.


Bugs: MESOS-5116
https://issues.apache.org/jira/browse/MESOS-5116


Repository: mesos


Description
---

Update XFS disk isolator documentation.


Diffs
-

  docs/mesos-containerizer.md d0b9d762ab83bff1cf2bd98ed566376b7bd566c6 

Diff: https://reviews.apache.org/r/55903/diff/


Testing
---

None.


Thanks,

James Peach