Re: Review Request 56347: Stout: Explicitly delete `SharedHandle` default constructor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56347/#review165055 --- Patch looks great! Reviews applied: [56347] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Feb. 6, 2017, 10:56 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56347/ > --- > > (Updated Feb. 6, 2017, 10:56 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Stout: Explicitly delete `SharedHandle` default constructor. > > > Diffs > - > > 3rdparty/stout/include/stout/windows.hpp > 3bc973b88ea39948780df2ecc7c3692f7e07e1a9 > > Diff: https://reviews.apache.org/r/56347/diff/ > > > Testing > --- > > make && make check > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 56347: Stout: Explicitly delete `SharedHandle` default constructor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56347/#review165020 --- Ship it! Ship It! - Joseph Wu On Feb. 6, 2017, 2:56 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56347/ > --- > > (Updated Feb. 6, 2017, 2:56 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Stout: Explicitly delete `SharedHandle` default constructor. > > > Diffs > - > > 3rdparty/stout/include/stout/windows.hpp > 3bc973b88ea39948780df2ecc7c3692f7e07e1a9 > > Diff: https://reviews.apache.org/r/56347/diff/ > > > Testing > --- > > make && make check > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 56347: Stout: Explicitly delete `SharedHandle` default constructor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56347/#review164634 --- Ship it! Ship It! - Alex Clemmer On Feb. 6, 2017, 10:56 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56347/ > --- > > (Updated Feb. 6, 2017, 10:56 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Stout: Explicitly delete `SharedHandle` default constructor. > > > Diffs > - > > 3rdparty/stout/include/stout/windows.hpp > 3bc973b88ea39948780df2ecc7c3692f7e07e1a9 > > Diff: https://reviews.apache.org/r/56347/diff/ > > > Testing > --- > > make && make check > > > Thanks, > > Andrew Schwartzmeyer > >
Review Request 56347: Stout: Explicitly delete `SharedHandle` default constructor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56347/ --- Review request for mesos. Repository: mesos Description --- Stout: Explicitly delete `SharedHandle` default constructor. Diffs - 3rdparty/stout/include/stout/windows.hpp 3bc973b88ea39948780df2ecc7c3692f7e07e1a9 Diff: https://reviews.apache.org/r/56347/diff/ Testing --- make && make check Thanks, Andrew Schwartzmeyer