Re: Review Request 56504: Stout: Made `os::mktemp` fully cross-platform.
> On Feb. 14, 2017, 11:05 p.m., Joseph Wu wrote: > > When we switched `mkdtemp` (directory version), that exposed some odd > > behavior on OSX due to how lengthy OSX's default temporary directory is. > > The IO Switchboard tests there ran into a 108 character limit for Unix > > sockets. It appears that this patch does not have as many side effects (as > > we create fewer temporary files than we do temporary directories). I should have written that I tested this in OS X also. Thanks for being thorough! - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56504/#review165582 --- On Feb. 9, 2017, 5:57 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56504/ > --- > > (Updated Feb. 9, 2017, 5:57 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Stout: Made `os::mktemp` fully cross-platform. > > > Diffs > - > > 3rdparty/stout/include/stout/os/mktemp.hpp > 231234f7652937e042f49b13fe8fc3c7193d26e1 > > Diff: https://reviews.apache.org/r/56504/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 56504: Stout: Made `os::mktemp` fully cross-platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56504/#review165582 --- Ship it! When we switched `mkdtemp` (directory version), that exposed some odd behavior on OSX due to how lengthy OSX's default temporary directory is. The IO Switchboard tests there ran into a 108 character limit for Unix sockets. It appears that this patch does not have as many side effects (as we create fewer temporary files than we do temporary directories). - Joseph Wu On Feb. 9, 2017, 9:57 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56504/ > --- > > (Updated Feb. 9, 2017, 9:57 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Stout: Made `os::mktemp` fully cross-platform. > > > Diffs > - > > 3rdparty/stout/include/stout/os/mktemp.hpp > 231234f7652937e042f49b13fe8fc3c7193d26e1 > > Diff: https://reviews.apache.org/r/56504/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 56504: Stout: Made `os::mktemp` fully cross-platform.
> On Feb. 9, 2017, 6:55 p.m., Andrew Schwartzmeyer wrote: > > Ship It! (But it might have some repercussions. It looks like the default use of `mktemp()` is now changing from `/tmp` (correct on Linux, incorrect on Windows), to `.` (current folder, working anywhere, but "correct" nowhere). - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56504/#review164968 --- On Feb. 9, 2017, 5:57 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56504/ > --- > > (Updated Feb. 9, 2017, 5:57 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Stout: Made `os::mktemp` fully cross-platform. > > > Diffs > - > > 3rdparty/stout/include/stout/os/mktemp.hpp > 231234f7652937e042f49b13fe8fc3c7193d26e1 > > Diff: https://reviews.apache.org/r/56504/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 56504: Stout: Made `os::mktemp` fully cross-platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56504/#review164968 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 9, 2017, 5:57 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56504/ > --- > > (Updated Feb. 9, 2017, 5:57 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Stout: Made `os::mktemp` fully cross-platform. > > > Diffs > - > > 3rdparty/stout/include/stout/os/mktemp.hpp > 231234f7652937e042f49b13fe8fc3c7193d26e1 > > Diff: https://reviews.apache.org/r/56504/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Review Request 56504: Stout: Made `os::mktemp` fully cross-platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56504/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Repository: mesos Description --- Stout: Made `os::mktemp` fully cross-platform. Diffs - 3rdparty/stout/include/stout/os/mktemp.hpp 231234f7652937e042f49b13fe8fc3c7193d26e1 Diff: https://reviews.apache.org/r/56504/diff/ Testing --- Thanks, Alex Clemmer
