Re: Review Request 57491: Windows: Update libprocess CMake setup for Glog patch.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57491/#review168929
---


Ship it!




I can fix those above nits before committing.

- Joseph Wu


On March 9, 2017, 5:59 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57491/
> ---
> 
> (Updated March 9, 2017, 5:59 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-6815
> https://issues.apache.org/jira/browse/MESOS-6815
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The additional Windows library `Dbghelp` must be linked for the
> patches enabling stack traces.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> e9eabd08d327f4c714199f7bde91b9adf644a678 
> 
> 
> Diff: https://reviews.apache.org/r/57491/diff/1/
> 
> 
> Testing
> ---
> 
> Run CTest. Add purposefully failing test, observe stack trace.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 57491: Windows: Update libprocess CMake setup for Glog patch.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57491/#review168916
---




3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake
Lines 34-36 (original), 34-36 (patched)


One more nit:
We should update this comment to reference `da816ea70` since we're now 
using a glog version past the latest release of glog.


- Joseph Wu


On March 9, 2017, 5:59 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57491/
> ---
> 
> (Updated March 9, 2017, 5:59 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-6815
> https://issues.apache.org/jira/browse/MESOS-6815
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The additional Windows library `Dbghelp` must be linked for the
> patches enabling stack traces.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> e9eabd08d327f4c714199f7bde91b9adf644a678 
> 
> 
> Diff: https://reviews.apache.org/r/57491/diff/1/
> 
> 
> Testing
> ---
> 
> Run CTest. Add purposefully failing test, observe stack trace.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 57491: Windows: Update libprocess CMake setup for Glog patch.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57491/#review168853
---




3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake
Lines 115 (patched)


Two typos in this line :)

Also, I'm thinking of adding this note:
```
# NOTE: CMake's dependency graph does not pull in the `Dbghelp` library
# automatically as the glog dependency is added into Mesos as an
# "external" project.  If we were to, instead, add glog's CMake files
# to the build system directly (such as, as a git submodule), glog's
# targets would be inherited.
```


- Joseph Wu


On March 9, 2017, 5:59 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57491/
> ---
> 
> (Updated March 9, 2017, 5:59 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-6815
> https://issues.apache.org/jira/browse/MESOS-6815
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The additional Windows library `Dbghelp` must be linked for the
> patches enabling stack traces.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> e9eabd08d327f4c714199f7bde91b9adf644a678 
> 
> 
> Diff: https://reviews.apache.org/r/57491/diff/1/
> 
> 
> Testing
> ---
> 
> Run CTest. Add purposefully failing test, observe stack trace.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 57491: Windows: Update libprocess CMake setup for Glog patch.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57491/#review168637
---



Patch looks great!

Reviews applied: [57490, 57491]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 10, 2017, 1:59 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57491/
> ---
> 
> (Updated March 10, 2017, 1:59 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-6815
> https://issues.apache.org/jira/browse/MESOS-6815
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The additional Windows library `Dbghelp` must be linked for the
> patches enabling stack traces.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> e9eabd08d327f4c714199f7bde91b9adf644a678 
> 
> 
> Diff: https://reviews.apache.org/r/57491/diff/1/
> 
> 
> Testing
> ---
> 
> Run CTest. Add purposefully failing test, observe stack trace.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Review Request 57491: Windows: Update libprocess CMake setup for Glog patch.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57491/
---

Review request for mesos and Joseph Wu.


Bugs: MESOS-6815
https://issues.apache.org/jira/browse/MESOS-6815


Repository: mesos


Description
---

The additional Windows library `Dbghelp` must be linked for the
patches enabling stack traces.


Diffs
-

  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
e9eabd08d327f4c714199f7bde91b9adf644a678 


Diff: https://reviews.apache.org/r/57491/diff/1/


Testing
---

Run CTest. Add purposefully failing test, observe stack trace.


Thanks,

Andrew Schwartzmeyer