Review Request 57516: Updated CHANGELOG for hierarchical roles.

2017-03-10 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57516/
---

Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park.


Repository: mesos


Description
---

Updated CHANGELOG for hierarchical roles.


Diffs
-

  CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee 


Diff: https://reviews.apache.org/r/57516/diff/1/


Testing
---

No functional change.


Thanks,

Neil Conway

Re: Review Request 57516: Updated CHANGELOG for hierarchical roles.

2017-03-26 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57516/
---

(Updated March 27, 2017, 1:44 a.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park.


Changes
---

Rebase.


Repository: mesos


Description
---

Updated CHANGELOG for hierarchical roles.


Diffs (updated)
-

  CHANGELOG 875ae02008cb22515396cf17c1d2e7da0046d068 


Diff: https://reviews.apache.org/r/57516/diff/2/

Changes: https://reviews.apache.org/r/57516/diff/1-2/


Testing
---

No functional change.


Thanks,

Neil Conway

Re: Review Request 57516: Updated CHANGELOG for hierarchical roles.

2017-03-30 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57516/
---

(Updated March 30, 2017, 3:54 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park.


Changes
---

Rebase.


Repository: mesos


Description
---

Updated CHANGELOG for hierarchical roles.


Diffs (updated)
-

  CHANGELOG 289069b39cb96c57c7603649a04c500fe84d0844 


Diff: https://reviews.apache.org/r/57516/diff/3/

Changes: https://reviews.apache.org/r/57516/diff/2-3/


Testing
---

No functional change.


Thanks,

Neil Conway

Re: Review Request 57516: Updated CHANGELOG for hierarchical roles.

2017-04-20 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57516/
---

(Updated April 20, 2017, 6:14 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park.


Changes
---

Marked hroles as experimental; noted that setting quota for nested roles is not 
currently supported.


Repository: mesos


Description
---

Updated CHANGELOG for hierarchical roles.


Diffs (updated)
-

  CHANGELOG feaedf7426fe694e4ecf1ade82abca3bf69d1691 


Diff: https://reviews.apache.org/r/57516/diff/4/

Changes: https://reviews.apache.org/r/57516/diff/3-4/


Testing
---

No functional change.


Thanks,

Neil Conway

Re: Review Request 57516: Updated CHANGELOG for hierarchical roles.

2017-04-24 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57516/#review172834
---


Ship it!




Ship It!

- Michael Park


On April 20, 2017, 11:14 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57516/
> ---
> 
> (Updated April 20, 2017, 11:14 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated CHANGELOG for hierarchical roles.
> 
> 
> Diffs
> -
> 
>   CHANGELOG feaedf7426fe694e4ecf1ade82abca3bf69d1691 
> 
> 
> Diff: https://reviews.apache.org/r/57516/diff/4/
> 
> 
> Testing
> ---
> 
> No functional change.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 57516: Updated CHANGELOG for hierarchical roles.

2017-04-24 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57516/#review172857
---




CHANGELOG
Lines 16-17 (patched)


It would also be nice to mention lack of the full plan here for 
reservations as well. E.g. we want reservations to "eng" to go to the "eng" 
tree instead of just the "eng" role.

Hm.. come to think of it, won't we be breaking things if we have people 
assuming "eng" reservations don't go to the tree and we change this?



CHANGELOG
Lines 32-35 (patched)


AFAICT the sorter headers weren't made public, they were just a detail of 
our allocator implementation.


- Benjamin Mahler


On April 20, 2017, 6:14 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57516/
> ---
> 
> (Updated April 20, 2017, 6:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated CHANGELOG for hierarchical roles.
> 
> 
> Diffs
> -
> 
>   CHANGELOG feaedf7426fe694e4ecf1ade82abca3bf69d1691 
> 
> 
> Diff: https://reviews.apache.org/r/57516/diff/4/
> 
> 
> Testing
> ---
> 
> No functional change.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 57516: Updated CHANGELOG for hierarchical roles.

2017-04-25 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57516/
---

(Updated April 25, 2017, 8:07 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park.


Repository: mesos


Description
---

Updated CHANGELOG for hierarchical roles.


Diffs (updated)
-

  CHANGELOG f98ce8c01041535967b07e8d9360cfbf90ac7814 


Diff: https://reviews.apache.org/r/57516/diff/5/

Changes: https://reviews.apache.org/r/57516/diff/4-5/


Testing
---

No functional change.


Thanks,

Neil Conway

Re: Review Request 57516: Updated CHANGELOG for hierarchical roles.

2017-04-26 Thread Neil Conway 


> On April 24, 2017, 9:11 p.m., Benjamin Mahler wrote:
> > CHANGELOG
> > Lines 16-17 (patched)
> > 
> >
> > It would also be nice to mention lack of the full plan here for 
> > reservations as well. E.g. we want reservations to "eng" to go to the "eng" 
> > tree instead of just the "eng" role.
> > 
> > Hm.. come to think of it, won't we be breaking things if we have people 
> > assuming "eng" reservations don't go to the tree and we change this?

Updated the CHANGELOG text to note the current and planned behavior of 
reservations for hierarchies.

Note that there's a good chance we'll be able to land proper support for 
hierarchical reservations in 1.3.0


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57516/#review172857
---


On April 25, 2017, 8:07 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57516/
> ---
> 
> (Updated April 25, 2017, 8:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated CHANGELOG for hierarchical roles.
> 
> 
> Diffs
> -
> 
>   CHANGELOG f98ce8c01041535967b07e8d9360cfbf90ac7814 
> 
> 
> Diff: https://reviews.apache.org/r/57516/diff/5/
> 
> 
> Testing
> ---
> 
> No functional change.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 57516: Updated CHANGELOG for hierarchical roles.

2017-04-26 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57516/
---

(Updated April 26, 2017, 5:58 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park.


Changes
---

Update CHANGELOG to discuss hierarchical reservations.


Repository: mesos


Description
---

Updated CHANGELOG for hierarchical roles.


Diffs (updated)
-

  CHANGELOG 08f10da1c46071a45f2cf26e28874536ba34ec54 


Diff: https://reviews.apache.org/r/57516/diff/6/

Changes: https://reviews.apache.org/r/57516/diff/5-6/


Testing
---

No functional change.


Thanks,

Neil Conway