Re: Review Request 57593: Sorted enum values in `authorizer.proto` by numerical order.

2017-03-14 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57593/#review16
---


Ship it!




Ship It!

- Vinod Kone


On March 14, 2017, 11:20 a.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57593/
> ---
> 
> (Updated March 14, 2017, 11:20 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Aliasing is allowed in `org.apache.mesos.authorization.Actions`, so the
> values have to be kept in numerical order in order to prevent accidental
> aliasing.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.proto 
> 617bf6e0a3a39d8164635d481c181ef50148a095 
> 
> 
> Diff: https://reviews.apache.org/r/57593/diff/1/
> 
> 
> Testing
> ---
> 
> `make`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>



Re: Review Request 57593: Sorted enum values in `authorizer.proto` by numerical order.

2017-03-14 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57593/#review168887
---


Ship it!




Ship It!

- Alexander Rukletsov


On March 14, 2017, 11:20 a.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57593/
> ---
> 
> (Updated March 14, 2017, 11:20 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Aliasing is allowed in `org.apache.mesos.authorization.Actions`, so the
> values have to be kept in numerical order in order to prevent accidental
> aliasing.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.proto 
> 617bf6e0a3a39d8164635d481c181ef50148a095 
> 
> 
> Diff: https://reviews.apache.org/r/57593/diff/1/
> 
> 
> Testing
> ---
> 
> `make`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>



Review Request 57593: Sorted enum values in `authorizer.proto` by numerical order.

2017-03-14 Thread Gastón Kleiman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57593/
---

Review request for mesos, Alexander Rukletsov, Vinod Kone, and Jiang Yan Xu.


Repository: mesos


Description
---

Aliasing is allowed in `org.apache.mesos.authorization.Actions`, so the
values have to be kept in numerical order in order to prevent accidental
aliasing.


Diffs
-

  include/mesos/authorizer/authorizer.proto 
617bf6e0a3a39d8164635d481c181ef50148a095 


Diff: https://reviews.apache.org/r/57593/diff/1/


Testing
---

`make`


Thanks,

Gastón Kleiman