Re: Review Request 57594: Added a helper for building a task status from scratch.

2017-03-15 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57594/
---

(Updated March 15, 2017, 12:45 p.m.)


Review request for mesos, Gastón Kleiman and Vinod Kone.


Changes
---

Vinod's comments.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/common/protobuf_utils.hpp 09e468c77f0cdd931302d1bdcc192370b6ce3340 
  src/common/protobuf_utils.cpp 34c14e8ebd7b575627704c7edebcbb0458eeb3b1 
  src/docker/executor.cpp 6c11320fc40ba1eebdbdf95f0a52ac383646d9f8 
  src/launcher/default_executor.cpp 0ed436faa68e984d0be4e5186138f738bc7f1b52 


Diff: https://reviews.apache.org/r/57594/diff/2/

Changes: https://reviews.apache.org/r/57594/diff/1-2/


Testing
---

make check


Thanks,

Alexander Rukletsov

Re: Review Request 57594: Added a helper for building a task status from scratch.

2017-03-15 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57594/#review168973
---


Fix it, then Ship it!





src/common/protobuf_utils.hpp
Lines 101-102 (patched)


I would make these the first 2 args because they are the most important and 
cannot be deduced; uuid and tiemstamp could have default values.


- Vinod Kone


On March 14, 2017, 2:05 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57594/
> ---
> 
> (Updated March 14, 2017, 2:05 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 09e468c77f0cdd931302d1bdcc192370b6ce3340 
>   src/common/protobuf_utils.cpp 34c14e8ebd7b575627704c7edebcbb0458eeb3b1 
>   src/docker/executor.cpp 6c11320fc40ba1eebdbdf95f0a52ac383646d9f8 
>   src/launcher/default_executor.cpp 0ed436faa68e984d0be4e5186138f738bc7f1b52 
> 
> 
> Diff: https://reviews.apache.org/r/57594/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Review Request 57594: Added a helper for building a task status from scratch.

2017-03-14 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57594/
---

Review request for mesos, Gastón Kleiman and Vinod Kone.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/common/protobuf_utils.hpp 09e468c77f0cdd931302d1bdcc192370b6ce3340 
  src/common/protobuf_utils.cpp 34c14e8ebd7b575627704c7edebcbb0458eeb3b1 
  src/docker/executor.cpp 6c11320fc40ba1eebdbdf95f0a52ac383646d9f8 
  src/launcher/default_executor.cpp 0ed436faa68e984d0be4e5186138f738bc7f1b52 


Diff: https://reviews.apache.org/r/57594/diff/1/


Testing
---

make check


Thanks,

Alexander Rukletsov