Re: Review Request 57597: Added comments regarding exit status on Windows vs. Posix.

2017-03-15 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57597/#review169000
---


Ship it!




Ship It!

- Vinod Kone


On March 15, 2017, 12:51 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57597/
> ---
> 
> (Updated March 15, 2017, 12:51 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto a432eade1e65a7e1c122b413883607a81393ebac 
>   include/mesos/scheduler/scheduler.proto 
> d04924a49d0bf28952af6cb72d972cac61e6f781 
>   include/mesos/v1/mesos.proto 8a733d9368456dfdf4ca77b80048548bfb3228c1 
>   include/mesos/v1/scheduler/scheduler.proto 
> 6e8246da0af9097b6fd2fe7c9c15fc4bdc9e4fce 
>   src/checks/checker.cpp 8716e4cc684e6c4b6b76d8ca53221be06d10b2a6 
> 
> 
> Diff: https://reviews.apache.org/r/57597/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 57597: Added comments regarding exit status on Windows vs. Posix.

2017-03-15 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57597/
---

(Updated March 15, 2017, 12:51 p.m.)


Review request for mesos, Gastón Kleiman and Vinod Kone.


Changes
---

Added a comment for `CheckStatusInfo.exit_code`.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/mesos.proto a432eade1e65a7e1c122b413883607a81393ebac 
  include/mesos/scheduler/scheduler.proto 
d04924a49d0bf28952af6cb72d972cac61e6f781 
  include/mesos/v1/mesos.proto 8a733d9368456dfdf4ca77b80048548bfb3228c1 
  include/mesos/v1/scheduler/scheduler.proto 
6e8246da0af9097b6fd2fe7c9c15fc4bdc9e4fce 
  src/checks/checker.cpp 8716e4cc684e6c4b6b76d8ca53221be06d10b2a6 


Diff: https://reviews.apache.org/r/57597/diff/2/

Changes: https://reviews.apache.org/r/57597/diff/1-2/


Testing
---

make check


Thanks,

Alexander Rukletsov

Re: Review Request 57597: Added comments regarding exit status on Windows vs. Posix.

2017-03-15 Thread Alexander Rukletsov 


> On March 15, 2017, 10:04 a.m., Vinod Kone wrote:
> > src/checks/checker.cpp
> > Lines 436-438 (patched)
> > 
> >
> > Why is this comment here and not in the CheckInfo proto like you did 
> > with Executor Failure?
> > 
> > Also, the first statement looks very similar to what you have in 
> > executor failure. Can you explicitly say that we return the result of 
> > `WEXITSTATUS` here?

Let's have both! Can be valuable until after MESOS-7242 is resolved.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57597/#review168978
---


On March 14, 2017, 2:09 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57597/
> ---
> 
> (Updated March 14, 2017, 2:09 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> d04924a49d0bf28952af6cb72d972cac61e6f781 
>   include/mesos/v1/scheduler/scheduler.proto 
> 6e8246da0af9097b6fd2fe7c9c15fc4bdc9e4fce 
>   src/checks/checker.cpp 8716e4cc684e6c4b6b76d8ca53221be06d10b2a6 
> 
> 
> Diff: https://reviews.apache.org/r/57597/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 57597: Added comments regarding exit status on Windows vs. Posix.

2017-03-15 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57597/#review168978
---




src/checks/checker.cpp
Lines 436-438 (patched)


Why is this comment here and not in the CheckInfo proto like you did with 
Executor Failure?

Also, the first statement looks very similar to what you have in executor 
failure. Can you explicitly say that we return the result of `WEXITSTATUS` here?


- Vinod Kone


On March 14, 2017, 2:09 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57597/
> ---
> 
> (Updated March 14, 2017, 2:09 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> d04924a49d0bf28952af6cb72d972cac61e6f781 
>   include/mesos/v1/scheduler/scheduler.proto 
> 6e8246da0af9097b6fd2fe7c9c15fc4bdc9e4fce 
>   src/checks/checker.cpp 8716e4cc684e6c4b6b76d8ca53221be06d10b2a6 
> 
> 
> Diff: https://reviews.apache.org/r/57597/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Review Request 57597: Added comments regarding exit status on Windows vs. Posix.

2017-03-14 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57597/
---

Review request for mesos, Gastón Kleiman and Vinod Kone.


Repository: mesos


Description
---

See summary.


Diffs
-

  include/mesos/scheduler/scheduler.proto 
d04924a49d0bf28952af6cb72d972cac61e6f781 
  include/mesos/v1/scheduler/scheduler.proto 
6e8246da0af9097b6fd2fe7c9c15fc4bdc9e4fce 
  src/checks/checker.cpp 8716e4cc684e6c4b6b76d8ca53221be06d10b2a6 


Diff: https://reviews.apache.org/r/57597/diff/1/


Testing
---

make check


Thanks,

Alexander Rukletsov