Re: Review Request 57598: Added comment regarding exit status on Windows vs. Posix in libprocess.

2017-03-15 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57598/
---

(Updated March 15, 2017, 12:51 p.m.)


Review request for mesos, Gastón Kleiman and Vinod Kone.


Changes
---

Rebased. NNTR.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess_base.hpp 
7117a2730ae8666d0b55cbe05162a0b4e843193c 


Diff: https://reviews.apache.org/r/57598/diff/2/

Changes: https://reviews.apache.org/r/57598/diff/1-2/


Testing
---

make check


Thanks,

Alexander Rukletsov



Re: Review Request 57598: Added comment regarding exit status on Windows vs. Posix in libprocess.

2017-03-15 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57598/#review168979
---


Ship it!




Ship It!

- Vinod Kone


On March 14, 2017, 2:09 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57598/
> ---
> 
> (Updated March 14, 2017, 2:09 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess_base.hpp 
> 7117a2730ae8666d0b55cbe05162a0b4e843193c 
> 
> 
> Diff: https://reviews.apache.org/r/57598/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Review Request 57598: Added comment regarding exit status on Windows vs. Posix in libprocess.

2017-03-14 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57598/
---

Review request for mesos, Gastón Kleiman and Vinod Kone.


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/include/process/subprocess_base.hpp 
7117a2730ae8666d0b55cbe05162a0b4e843193c 


Diff: https://reviews.apache.org/r/57598/diff/1/


Testing
---

make check


Thanks,

Alexander Rukletsov