Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-21 Thread Benjamin Mahler 


> On March 18, 2017, 6:14 a.m., haosdent huang wrote:
> > src/webui/master/static/roles.html
> > Lines 28-31 (patched)
> > 
> >
> > I change to
> > 
> > ```
> > -  {{role.resources.cpus | number}}
> > -  {{role.resources.gpus | number}}
> > -  {{role.resources.mem * (1024 * 1024) | number}}
> > -  {{role.resources.disk * (1024 * 1024) | number}}
> > +  {{role.resources.cpus | decimalFloat}}
> > +  {{role.resources.gpus | decimalFloat}}
> > +  {{role.resources.mem * (1024 * 1024) | dataSize}}
> > +  {{role.resources.disk * (1024 * 1024) | dataSize}}
> > 
> > ```
> > here

Thanks!


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57622/#review169359
---


On March 16, 2017, 1:28 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57622/
> ---
> 
> (Updated March 16, 2017, 1:28 a.m.)
> 
> 
> Review request for mesos, Jay Guo, haosdent huang, Michael Park, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-6995
> https://issues.apache.org/jira/browse/MESOS-6995
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Initially, this includes the weight, number of frameworks involved
> with the role, and the resource allocation. Longer term this should
> include the quota information and the revocable resources.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 8c67e472ec2e973b66c0004f6bf58bd8b0e4fad3 
>   src/webui/master/static/index.html 7811ecb2c8c4fc5d14c4d5ca690b611290b07c83 
>   src/webui/master/static/js/app.js 73043a8521d2931b639ece11bf3f2b8bccba83d6 
>   src/webui/master/static/js/controllers.js 
> ae3e7875258fed9e70b8d15ac82b3e8ffadc6522 
>   src/webui/master/static/roles.html PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57622/diff/4/
> 
> 
> Testing
> ---
> 
> manual testing.
> 
> 
> File Attachments
> 
> 
> screenshot
>   
> https://reviews.apache.org/media/uploaded/files/2017/03/14/2670df08-47f2-4cbf-8c61-1f897c19fa1c__Screen_Shot_2017-03-14_at_3.26.06_PM.png
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-17 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57622/#review169359
---




src/webui/master/static/roles.html
Lines 28-31 (patched)


I change to

```
-  {{role.resources.cpus | number}}
-  {{role.resources.gpus | number}}
-  {{role.resources.mem * (1024 * 1024) | number}}
-  {{role.resources.disk * (1024 * 1024) | number}}
+  {{role.resources.cpus | decimalFloat}}
+  {{role.resources.gpus | decimalFloat}}
+  {{role.resources.mem * (1024 * 1024) | dataSize}}
+  {{role.resources.disk * (1024 * 1024) | dataSize}}

```
here


- haosdent huang


On March 16, 2017, 1:28 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57622/
> ---
> 
> (Updated March 16, 2017, 1:28 a.m.)
> 
> 
> Review request for mesos, Jay Guo, haosdent huang, Michael Park, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-6995
> https://issues.apache.org/jira/browse/MESOS-6995
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Initially, this includes the weight, number of frameworks involved
> with the role, and the resource allocation. Longer term this should
> include the quota information and the revocable resources.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 8c67e472ec2e973b66c0004f6bf58bd8b0e4fad3 
>   src/webui/master/static/index.html 7811ecb2c8c4fc5d14c4d5ca690b611290b07c83 
>   src/webui/master/static/js/app.js 73043a8521d2931b639ece11bf3f2b8bccba83d6 
>   src/webui/master/static/js/controllers.js 
> ae3e7875258fed9e70b8d15ac82b3e8ffadc6522 
>   src/webui/master/static/roles.html PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57622/diff/4/
> 
> 
> Testing
> ---
> 
> manual testing.
> 
> 
> File Attachments
> 
> 
> screenshot
>   
> https://reviews.apache.org/media/uploaded/files/2017/03/14/2670df08-47f2-4cbf-8c61-1f897c19fa1c__Screen_Shot_2017-03-14_at_3.26.06_PM.png
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-17 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57622/#review169358
---


Fix it, then Ship it!




Ship It!


src/webui/master/static/js/app.js
Lines 21-22 (patched)


Let's ensure the order is alphabetically.


- haosdent huang


On March 16, 2017, 1:28 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57622/
> ---
> 
> (Updated March 16, 2017, 1:28 a.m.)
> 
> 
> Review request for mesos, Jay Guo, haosdent huang, Michael Park, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-6995
> https://issues.apache.org/jira/browse/MESOS-6995
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Initially, this includes the weight, number of frameworks involved
> with the role, and the resource allocation. Longer term this should
> include the quota information and the revocable resources.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 8c67e472ec2e973b66c0004f6bf58bd8b0e4fad3 
>   src/webui/master/static/index.html 7811ecb2c8c4fc5d14c4d5ca690b611290b07c83 
>   src/webui/master/static/js/app.js 73043a8521d2931b639ece11bf3f2b8bccba83d6 
>   src/webui/master/static/js/controllers.js 
> ae3e7875258fed9e70b8d15ac82b3e8ffadc6522 
>   src/webui/master/static/roles.html PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57622/diff/4/
> 
> 
> Testing
> ---
> 
> manual testing.
> 
> 
> File Attachments
> 
> 
> screenshot
>   
> https://reviews.apache.org/media/uploaded/files/2017/03/14/2670df08-47f2-4cbf-8c61-1f897c19fa1c__Screen_Shot_2017-03-14_at_3.26.06_PM.png
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-16 Thread Jay Guo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57622/#review169246
---


Ship it!




Ship It!

- Jay Guo


On March 16, 2017, 9:28 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57622/
> ---
> 
> (Updated March 16, 2017, 9:28 a.m.)
> 
> 
> Review request for mesos, Jay Guo, haosdent huang, Michael Park, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-6995
> https://issues.apache.org/jira/browse/MESOS-6995
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Initially, this includes the weight, number of frameworks involved
> with the role, and the resource allocation. Longer term this should
> include the quota information and the revocable resources.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 8c67e472ec2e973b66c0004f6bf58bd8b0e4fad3 
>   src/webui/master/static/index.html 7811ecb2c8c4fc5d14c4d5ca690b611290b07c83 
>   src/webui/master/static/js/app.js 73043a8521d2931b639ece11bf3f2b8bccba83d6 
>   src/webui/master/static/js/controllers.js 
> ae3e7875258fed9e70b8d15ac82b3e8ffadc6522 
>   src/webui/master/static/roles.html PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57622/diff/4/
> 
> 
> Testing
> ---
> 
> manual testing.
> 
> 
> File Attachments
> 
> 
> screenshot
>   
> https://reviews.apache.org/media/uploaded/files/2017/03/14/2670df08-47f2-4cbf-8c61-1f897c19fa1c__Screen_Shot_2017-03-14_at_3.26.06_PM.png
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-15 Thread Benjamin Mahler 


> On March 15, 2017, 10:44 a.m., Jay Guo wrote:
> > src/webui/master/static/roles.html
> > Lines 30-31 (patched)
> > 
> >
> > ```
> >   {{role.resources.mem * (1024 * 1024) | dataSize}}
> >   {{role.resources.disk * (1024 * 1024) | dataSize}}
> > ```

Good catch, thanks!


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57622/#review168986
---


On March 15, 2017, 9:03 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57622/
> ---
> 
> (Updated March 15, 2017, 9:03 p.m.)
> 
> 
> Review request for mesos, Jay Guo, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-6995
> https://issues.apache.org/jira/browse/MESOS-6995
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Initially, this includes the weight, number of frameworks involved
> with the role, and the resource allocation. Longer term this should
> include the quota information and the revocable resources.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 8c67e472ec2e973b66c0004f6bf58bd8b0e4fad3 
>   src/webui/master/static/index.html 7811ecb2c8c4fc5d14c4d5ca690b611290b07c83 
>   src/webui/master/static/js/app.js 73043a8521d2931b639ece11bf3f2b8bccba83d6 
>   src/webui/master/static/js/controllers.js 
> ae3e7875258fed9e70b8d15ac82b3e8ffadc6522 
>   src/webui/master/static/roles.html PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57622/diff/4/
> 
> 
> Testing
> ---
> 
> manual testing.
> 
> 
> File Attachments
> 
> 
> screenshot
>   
> https://reviews.apache.org/media/uploaded/files/2017/03/14/2670df08-47f2-4cbf-8c61-1f897c19fa1c__Screen_Shot_2017-03-14_at_3.26.06_PM.png
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-15 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57622/
---

(Updated March 15, 2017, 9:03 p.m.)


Review request for mesos, Jay Guo, Michael Park, and Neil Conway.


Changes
---

Fixed the memory and disk display.


Bugs: MESOS-6995
https://issues.apache.org/jira/browse/MESOS-6995


Repository: mesos


Description
---

Initially, this includes the weight, number of frameworks involved
with the role, and the resource allocation. Longer term this should
include the quota information and the revocable resources.


Diffs (updated)
-

  src/Makefile.am 8c67e472ec2e973b66c0004f6bf58bd8b0e4fad3 
  src/webui/master/static/index.html 7811ecb2c8c4fc5d14c4d5ca690b611290b07c83 
  src/webui/master/static/js/app.js 73043a8521d2931b639ece11bf3f2b8bccba83d6 
  src/webui/master/static/js/controllers.js 
ae3e7875258fed9e70b8d15ac82b3e8ffadc6522 
  src/webui/master/static/roles.html PRE-CREATION 


Diff: https://reviews.apache.org/r/57622/diff/4/

Changes: https://reviews.apache.org/r/57622/diff/3-4/


Testing
---

manual testing.


File Attachments


screenshot
  
https://reviews.apache.org/media/uploaded/files/2017/03/14/2670df08-47f2-4cbf-8c61-1f897c19fa1c__Screen_Shot_2017-03-14_at_3.26.06_PM.png


Thanks,

Benjamin Mahler

Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-15 Thread Jay Guo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57622/#review168986
---




src/webui/master/static/roles.html
Lines 30-31 (patched)


```
  {{role.resources.mem * (1024 * 1024) | dataSize}}
  {{role.resources.disk * (1024 * 1024) | dataSize}}
```


- Jay Guo


On March 15, 2017, 10:05 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57622/
> ---
> 
> (Updated March 15, 2017, 10:05 a.m.)
> 
> 
> Review request for mesos, Jay Guo, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-6995
> https://issues.apache.org/jira/browse/MESOS-6995
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Initially, this includes the weight, number of frameworks involved
> with the role, and the resource allocation. Longer term this should
> include the quota information and the revocable resources.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 2eea11a4f18f5d0e4ac3cc6bffc8b80f00556d01 
>   src/webui/master/static/index.html 7811ecb2c8c4fc5d14c4d5ca690b611290b07c83 
>   src/webui/master/static/js/app.js 73043a8521d2931b639ece11bf3f2b8bccba83d6 
>   src/webui/master/static/js/controllers.js 
> 4e1d07eb6155301c7d7d2b3e030c38156e8210ad 
>   src/webui/master/static/roles.html PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57622/diff/3/
> 
> 
> Testing
> ---
> 
> manual testing.
> 
> 
> File Attachments
> 
> 
> screenshot
>   
> https://reviews.apache.org/media/uploaded/files/2017/03/14/2670df08-47f2-4cbf-8c61-1f897c19fa1c__Screen_Shot_2017-03-14_at_3.26.06_PM.png
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-14 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57622/
---

(Updated March 15, 2017, 2:05 a.m.)


Review request for mesos, Jay Guo, Michael Park, and Neil Conway.


Changes
---

Fixed an issue where the roles tab is not shown as active (this was due to 
following the approach used in the maintenance tab, where it's also broken).


Bugs: MESOS-6995
https://issues.apache.org/jira/browse/MESOS-6995


Repository: mesos


Description
---

Initially, this includes the weight, number of frameworks involved
with the role, and the resource allocation. Longer term this should
include the quota information and the revocable resources.


Diffs (updated)
-

  src/Makefile.am 2eea11a4f18f5d0e4ac3cc6bffc8b80f00556d01 
  src/webui/master/static/index.html 7811ecb2c8c4fc5d14c4d5ca690b611290b07c83 
  src/webui/master/static/js/app.js 73043a8521d2931b639ece11bf3f2b8bccba83d6 
  src/webui/master/static/js/controllers.js 
4e1d07eb6155301c7d7d2b3e030c38156e8210ad 
  src/webui/master/static/roles.html PRE-CREATION 


Diff: https://reviews.apache.org/r/57622/diff/3/

Changes: https://reviews.apache.org/r/57622/diff/2-3/


Testing
---

manual testing.


File Attachments


screenshot
  
https://reviews.apache.org/media/uploaded/files/2017/03/14/2670df08-47f2-4cbf-8c61-1f897c19fa1c__Screen_Shot_2017-03-14_at_3.26.06_PM.png


Thanks,

Benjamin Mahler

Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-14 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57622/#review168958
---




src/webui/master/static/roles.html
Lines 15 (patched)


Remove "data-sort" here.


- Benjamin Mahler


On March 14, 2017, 10:28 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57622/
> ---
> 
> (Updated March 14, 2017, 10:28 p.m.)
> 
> 
> Review request for mesos, Jay Guo, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-6995
> https://issues.apache.org/jira/browse/MESOS-6995
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Initially, this includes the weight, number of frameworks involved
> with the role, and the resource allocation. Longer term this should
> include the quota information and the revocable resources.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/index.html 7811ecb2c8c4fc5d14c4d5ca690b611290b07c83 
>   src/webui/master/static/js/app.js 73043a8521d2931b639ece11bf3f2b8bccba83d6 
>   src/webui/master/static/js/controllers.js 
> 4e1d07eb6155301c7d7d2b3e030c38156e8210ad 
>   src/webui/master/static/roles.html PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57622/diff/1/
> 
> 
> Testing
> ---
> 
> manual testing.
> 
> 
> File Attachments
> 
> 
> screenshot
>   
> https://reviews.apache.org/media/uploaded/files/2017/03/14/2670df08-47f2-4cbf-8c61-1f897c19fa1c__Screen_Shot_2017-03-14_at_3.26.06_PM.png
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Review Request 57622: Introduced a Roles tab in the webui.

2017-03-14 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57622/
---

Review request for mesos, Jay Guo, Michael Park, and Neil Conway.


Bugs: MESOS-6995
https://issues.apache.org/jira/browse/MESOS-6995


Repository: mesos


Description
---

Initially, this includes the weight, number of frameworks involved
with the role, and the resource allocation. Longer term this should
include the quota information and the revocable resources.


Diffs
-

  src/webui/master/static/index.html 7811ecb2c8c4fc5d14c4d5ca690b611290b07c83 
  src/webui/master/static/js/app.js 73043a8521d2931b639ece11bf3f2b8bccba83d6 
  src/webui/master/static/js/controllers.js 
4e1d07eb6155301c7d7d2b3e030c38156e8210ad 
  src/webui/master/static/roles.html PRE-CREATION 


Diff: https://reviews.apache.org/r/57622/diff/1/


Testing
---

manual testing.


File Attachments


screenshot
  
https://reviews.apache.org/media/uploaded/files/2017/03/14/2670df08-47f2-4cbf-8c61-1f897c19fa1c__Screen_Shot_2017-03-14_at_3.26.06_PM.png


Thanks,

Benjamin Mahler