Re: Review Request 57700: Modified a test to also check if the data was written to the volume.

2017-03-20 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57700/#review169487
---


Ship it!




Thanks for fixing it, Anand!

- Gilbert Song


On March 16, 2017, 11:49 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57700/
> ---
> 
> (Updated March 16, 2017, 11:49 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, it was possbile that the directory exists but does not
> link to the persistent volume.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> b701e7d2f11af91a94d57db53ac2904e301996f1 
> 
> 
> Diff: https://reviews.apache.org/r/57700/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 57700: Modified a test to also check if the data was written to the volume.

2017-03-16 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57700/#review169223
---



Patch looks great!

Reviews applied: [57469, 57700]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 16, 2017, 6:49 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57700/
> ---
> 
> (Updated March 16, 2017, 6:49 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, it was possbile that the directory exists but does not
> link to the persistent volume.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> b701e7d2f11af91a94d57db53ac2904e301996f1 
> 
> 
> Diff: https://reviews.apache.org/r/57700/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 57700: Modified a test to also check if the data was written to the volume.

2017-03-16 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57700/
---

Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

Previously, it was possbile that the directory exists but does not
link to the persistent volume.


Diffs
-

  src/tests/default_executor_tests.cpp b701e7d2f11af91a94d57db53ac2904e301996f1 


Diff: https://reviews.apache.org/r/57700/diff/1/


Testing
---

make check


Thanks,

Anand Mazumdar