Re: Review Request 57731: Fixed a test in MasterAuthorizationTest.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57731/#review172738 --- Ship it! Ship It! - Anindya Sinha On March 17, 2017, 3:55 p.m., Jiang Yan Xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57731/ > --- > > (Updated March 17, 2017, 3:55 p.m.) > > > Review request for mesos, Anindya Sinha and Vinod Kone. > > > Bugs: MESOS-7097 > https://issues.apache.org/jira/browse/MESOS-7097 > > > Repository: mesos > > > Description > --- > > - `MasterAuthorizationTest.PendingExecutorInfoDiffersOnDifferentSlaves` > used to assume the mock authorizer is only called for tasks > authorization but with the new `regsiter_agents` ACL this is no > longer true. > > > Diffs > - > > src/tests/master_authorization_tests.cpp > 1a0285a3f345ef21a8256d4123d8bb684f538da4 > > > Diff: https://reviews.apache.org/r/57731/diff/4/ > > > Testing > --- > > make check. > > > Thanks, > > Jiang Yan Xu > >
Re: Review Request 57731: Fixed a test in MasterAuthorizationTest.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57731/#review171025 --- Ship it! Ship It! - Greg Mann On March 17, 2017, 3:55 p.m., Jiang Yan Xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57731/ > --- > > (Updated March 17, 2017, 3:55 p.m.) > > > Review request for mesos, Anindya Sinha and Vinod Kone. > > > Bugs: MESOS-7097 > https://issues.apache.org/jira/browse/MESOS-7097 > > > Repository: mesos > > > Description > --- > > - `MasterAuthorizationTest.PendingExecutorInfoDiffersOnDifferentSlaves` > used to assume the mock authorizer is only called for tasks > authorization but with the new `regsiter_agents` ACL this is no > longer true. > > > Diffs > - > > src/tests/master_authorization_tests.cpp > 1a0285a3f345ef21a8256d4123d8bb684f538da4 > > > Diff: https://reviews.apache.org/r/57731/diff/4/ > > > Testing > --- > > make check. > > > Thanks, > > Jiang Yan Xu > >
Re: Review Request 57731: Fixed a test in MasterAuthorizationTest.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57731/#review170297 --- Patch looks great! Reviews applied: [57520, 57534, 57535, 57710, 57730, 57731] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 17, 2017, 3:55 p.m., Jiang Yan Xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57731/ > --- > > (Updated March 17, 2017, 3:55 p.m.) > > > Review request for mesos, Anindya Sinha and Vinod Kone. > > > Bugs: MESOS-7097 > https://issues.apache.org/jira/browse/MESOS-7097 > > > Repository: mesos > > > Description > --- > > - `MasterAuthorizationTest.PendingExecutorInfoDiffersOnDifferentSlaves` > used to assume the mock authorizer is only called for tasks > authorization but with the new `regsiter_agents` ACL this is no > longer true. > > > Diffs > - > > src/tests/master_authorization_tests.cpp > 1a0285a3f345ef21a8256d4123d8bb684f538da4 > > > Diff: https://reviews.apache.org/r/57731/diff/4/ > > > Testing > --- > > make check. > > > Thanks, > > Jiang Yan Xu > >
