Re: Review Request 57898: Windows: Add deprecation warning for VS 2015.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57898/#review173014
---


Ship it!





cmake/CompilationConfigure.cmake
Line 141 (original), 141 (patched)


Might as well be consistent with the full generator name here:
`Visual Studio 15 2017 Win64`


- Joseph Wu


On April 13, 2017, 3:03 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57898/
> ---
> 
> (Updated April 13, 2017, 3:03 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7391
> https://issues.apache.org/jira/browse/MESOS-7391
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Specifically this checks if the generator used did not match "Visual
> Studio 15 2017", which Mesos prefers. Note that the `CMAKE_GENERATOR`
> variable is expanded fully even when shorthand is used, e.g. `-G"Visual
> Studio 15"` will correctly match.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 5936be07557395ad08b06aa376b5a29f9b11c143 
> 
> 
> Diff: https://reviews.apache.org/r/57898/diff/1/
> 
> 
> Testing
> ---
> 
> Tested using different generators on Windows. Warning is displayed when using 
> `-G"Visual Studio 14"`, `-G"Visual Studio 14 2015"`, and `-G"Visual Studio 14 
> 2015 Win64"`, but not when using `-G"Visual Studio 15"`, `-G"Visual Studio 15 
> 2017"`, or `-G"Visual Studio 15 2017 Win64"`.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 57898: Windows: Add deprecation warning for VS 2015.

[Jeff Coffler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57898/#review172814
---


Ship it!




Is this ever going to be committed? I've been holding off on upgrading VS 
myself to insure that this works properly ...

- Jeff Coffler


On April 13, 2017, 10:03 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57898/
> ---
> 
> (Updated April 13, 2017, 10:03 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7391
> https://issues.apache.org/jira/browse/MESOS-7391
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Specifically this checks if the generator used did not match "Visual
> Studio 15 2017", which Mesos prefers. Note that the `CMAKE_GENERATOR`
> variable is expanded fully even when shorthand is used, e.g. `-G"Visual
> Studio 15"` will correctly match.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 5936be07557395ad08b06aa376b5a29f9b11c143 
> 
> 
> Diff: https://reviews.apache.org/r/57898/diff/1/
> 
> 
> Testing
> ---
> 
> Tested using different generators on Windows. Warning is displayed when using 
> `-G"Visual Studio 14"`, `-G"Visual Studio 14 2015"`, and `-G"Visual Studio 14 
> 2015 Win64"`, but not when using `-G"Visual Studio 15"`, `-G"Visual Studio 15 
> 2017"`, or `-G"Visual Studio 15 2017 Win64"`.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 57898: Windows: Add deprecation warning for VS 2015.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57898/
---

(Updated April 13, 2017, 10:03 p.m.)


Review request for mesos, Jeff Coffler, Joseph Wu, and Michael Park.


Changes
---

Update bug since it was pulled out of the task.


Bugs: MESOS-7391
https://issues.apache.org/jira/browse/MESOS-7391


Repository: mesos


Description
---

Specifically this checks if the generator used did not match "Visual
Studio 15 2017", which Mesos prefers. Note that the `CMAKE_GENERATOR`
variable is expanded fully even when shorthand is used, e.g. `-G"Visual
Studio 15"` will correctly match.


Diffs
-

  cmake/CompilationConfigure.cmake 5936be07557395ad08b06aa376b5a29f9b11c143 


Diff: https://reviews.apache.org/r/57898/diff/1/


Testing
---

Tested using different generators on Windows. Warning is displayed when using 
`-G"Visual Studio 14"`, `-G"Visual Studio 14 2015"`, and `-G"Visual Studio 14 
2015 Win64"`, but not when using `-G"Visual Studio 15"`, `-G"Visual Studio 15 
2017"`, or `-G"Visual Studio 15 2017 Win64"`.


Thanks,

Andrew Schwartzmeyer

Re: Review Request 57898: Windows: Add deprecation warning for VS 2015.

[Jeff Coffler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57898/#review170428
---



This looks fine to me. I'll hold off upgrading until this is merged, just to 
double check that it trips properly.

- Jeff Coffler


On March 27, 2017, 5:12 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57898/
> ---
> 
> (Updated March 27, 2017, 5:12 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7297
> https://issues.apache.org/jira/browse/MESOS-7297
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Specifically this checks if the generator used did not match "Visual
> Studio 15 2017", which Mesos prefers. Note that the `CMAKE_GENERATOR`
> variable is expanded fully even when shorthand is used, e.g. `-G"Visual
> Studio 15"` will correctly match.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 5936be07557395ad08b06aa376b5a29f9b11c143 
> 
> 
> Diff: https://reviews.apache.org/r/57898/diff/1/
> 
> 
> Testing
> ---
> 
> Tested using different generators on Windows. Warning is displayed when using 
> `-G"Visual Studio 14"`, `-G"Visual Studio 14 2015"`, and `-G"Visual Studio 14 
> 2015 Win64"`, but not when using `-G"Visual Studio 15"`, `-G"Visual Studio 15 
> 2017"`, or `-G"Visual Studio 15 2017 Win64"`.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 57898: Windows: Add deprecation warning for VS 2015.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57898/#review169975
---



Patch looks great!

Reviews applied: [57898]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 23, 2017, 11:12 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57898/
> ---
> 
> (Updated March 23, 2017, 11:12 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-7297
> https://issues.apache.org/jira/browse/MESOS-7297
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Specifically this checks if the generator used did not match "Visual
> Studio 15 2017", which Mesos prefers. Note that the `CMAKE_GENERATOR`
> variable is expanded fully even when shorthand is used, e.g. `-G"Visual
> Studio 15"` will correctly match.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 5936be07557395ad08b06aa376b5a29f9b11c143 
> 
> 
> Diff: https://reviews.apache.org/r/57898/diff/1/
> 
> 
> Testing
> ---
> 
> Tested using different generators on Windows. Warning is displayed when using 
> `-G"Visual Studio 14"`, `-G"Visual Studio 14 2015"`, and `-G"Visual Studio 14 
> 2015 Win64"`, but not when using `-G"Visual Studio 15"`, `-G"Visual Studio 15 
> 2017"`, or `-G"Visual Studio 15 2017 Win64"`.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Review Request 57898: Windows: Add deprecation warning for VS 2015.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57898/
---

Review request for mesos and Joseph Wu.


Bugs: MESOS-7297
https://issues.apache.org/jira/browse/MESOS-7297


Repository: mesos


Description
---

Specifically this checks if the generator used did not match "Visual
Studio 15 2017", which Mesos prefers. Note that the `CMAKE_GENERATOR`
variable is expanded fully even when shorthand is used, e.g. `-G"Visual
Studio 15"` will correctly match.


Diffs
-

  cmake/CompilationConfigure.cmake 5936be07557395ad08b06aa376b5a29f9b11c143 


Diff: https://reviews.apache.org/r/57898/diff/1/


Testing
---

Tested using different generators on Windows. Warning is displayed when using 
`-G"Visual Studio 14"`, `-G"Visual Studio 14 2015"`, and `-G"Visual Studio 14 
2015 Win64"`, but not when using `-G"Visual Studio 15"`, `-G"Visual Studio 15 
2017"`, or `-G"Visual Studio 15 2017 Win64"`.


Thanks,

Andrew Schwartzmeyer