Re: Review Request 57989: Removing deprecated ACL `ShutdownFramework`.

2017-04-27 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57989/
---

(Updated April 27, 2017, 12:58 a.m.)


Review request for mesos, Adam B and Alexander Rukletsov.


Bugs: MESOS-7320
https://issues.apache.org/jira/browse/MESOS-7320


Repository: mesos


Description
---

The `ShutdownFramework` message from `acls.proto` was deprecated more
than six months ago in favor of `TeardownFramework`. Since its
deprecation cycle is already over, this patch removes the message.

Note that this only removes the message support from the ACLs, since
the associated action was removed long ago.


Diffs
-

  CHANGELOG 875ae02008cb22515396cf17c1d2e7da0046d068 
  docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252 
  include/mesos/authorizer/acls.proto 46e66e8ed42240e5258890cdaf5aebe8800efcf0 
  src/authorizer/local/authorizer.cpp be8037299601427e5d5e79f58f77eea3f89579d0 
  src/tests/teardown_tests.cpp 239a87ee0be8605a3f13196933038ef752ad9d4b 


Diff: https://reviews.apache.org/r/57989/diff/1/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 57989: Removing deprecated ACL `ShutdownFramework`.

2017-04-10 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57989/#review171526
---


Fix it, then Ship it!




Minor doc rewording, and you probably need to rebase, but otherwise great.


docs/upgrades.md
Lines 265 (patched)


s/its replacemente/the new/
s/After consolidation of the ACLs, the binaries could be safely 
replaced./After updating the ACLs, the binaries can be safely replaced.


- Adam B


On March 28, 2017, 2:35 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57989/
> ---
> 
> (Updated March 28, 2017, 2:35 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7259
> https://issues.apache.org/jira/browse/MESOS-7259
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `ShutdownFramework` message from `acls.proto` was deprecated more
> than six months ago in favor of `TeardownFramework`. Since its
> deprecation cycle is already over, this patch removes the message.
> 
> Note that this only removes the message support from the ACLs, since
> the associated action was removed long ago.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 875ae02008cb22515396cf17c1d2e7da0046d068 
>   docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252 
>   include/mesos/authorizer/acls.proto 
> 46e66e8ed42240e5258890cdaf5aebe8800efcf0 
>   src/authorizer/local/authorizer.cpp 
> be8037299601427e5d5e79f58f77eea3f89579d0 
>   src/tests/teardown_tests.cpp 239a87ee0be8605a3f13196933038ef752ad9d4b 
> 
> 
> Diff: https://reviews.apache.org/r/57989/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 57989: Removing deprecated ACL `ShutdownFramework`.

2017-03-28 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57989/#review170308
---



Bad review!

Reviews applied: [57989, 57472, 57166, 56805, 57165, 57164]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos Reviewbot


On March 28, 2017, 9:35 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57989/
> ---
> 
> (Updated March 28, 2017, 9:35 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7259
> https://issues.apache.org/jira/browse/MESOS-7259
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `ShutdownFramework` message from `acls.proto` was deprecated more
> than six months ago in favor of `TeardownFramework`. Since its
> deprecation cycle is already over, this patch removes the message.
> 
> Note that this only removes the message support from the ACLs, since
> the associated action was removed long ago.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 875ae02008cb22515396cf17c1d2e7da0046d068 
>   docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252 
>   include/mesos/authorizer/acls.proto 
> 46e66e8ed42240e5258890cdaf5aebe8800efcf0 
>   src/authorizer/local/authorizer.cpp 
> be8037299601427e5d5e79f58f77eea3f89579d0 
>   src/tests/teardown_tests.cpp 239a87ee0be8605a3f13196933038ef752ad9d4b 
> 
> 
> Diff: https://reviews.apache.org/r/57989/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Review Request 57989: Removing deprecated ACL `ShutdownFramework`.

2017-03-28 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57989/
---

Review request for mesos, Adam B and Alexander Rukletsov.


Bugs: MESOS-7259
https://issues.apache.org/jira/browse/MESOS-7259


Repository: mesos


Description
---

The `ShutdownFramework` message from `acls.proto` was deprecated more
than six months ago in favor of `TeardownFramework`. Since its
deprecation cycle is already over, this patch removes the message.

Note that this only removes the message support from the ACLs, since
the associated action was removed long ago.


Diffs
-

  CHANGELOG 875ae02008cb22515396cf17c1d2e7da0046d068 
  docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252 
  include/mesos/authorizer/acls.proto 46e66e8ed42240e5258890cdaf5aebe8800efcf0 
  src/authorizer/local/authorizer.cpp be8037299601427e5d5e79f58f77eea3f89579d0 
  src/tests/teardown_tests.cpp 239a87ee0be8605a3f13196933038ef752ad9d4b 


Diff: https://reviews.apache.org/r/57989/diff/1/


Testing
---

make check


Thanks,

Alexander Rojas