Re: Review Request 58011: CMake: Add Cotire module (version 1.7.9).
> On March 29, 2017, 12:34 p.m., Andrew Schwartzmeyer wrote: > > Can we record what commit of upstream cotire this file got pulled from (or > > tag if we did indeed pull from a release)? I realize the module has a > > version in it, but I don't trust that it gurantees the file didn't come > > from tip of master. I've already added the SHA to the commit I have staged for committing :) - Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58011/#review170457 --- On March 28, 2017, 5:54 p.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58011/ > --- > > (Updated March 28, 2017, 5:54 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-7226 > https://issues.apache.org/jira/browse/MESOS-7226 > > > Repository: mesos > > > Description > --- > > Add CMake's cotire module to allow for use of PCH (precompiled > headers) during compilation, reducing compilation speed. > > > Diffs > - > > 3rdparty/cmake/cotire.cmake PRE-CREATION > CMakeLists.txt 0d1e17b863856287b18fd026e1ae71ec35e5ad83 > LICENSE f11970cada909e7bbb685f96cb9ef0ff24e01924 > > > Diff: https://reviews.apache.org/r/58011/diff/1/ > > > Testing > --- > > Testing done at end of chain > > > Thanks, > > Jeff Coffler > >
Re: Review Request 58011: CMake: Add Cotire module (version 1.7.9).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58011/#review170457 --- Can we record what commit of upstream cotire this file got pulled from (or tag if we did indeed pull from a release)? I realize the module has a version in it, but I don't trust that it gurantees the file didn't come from tip of master. - Andrew Schwartzmeyer On March 29, 2017, 12:54 a.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58011/ > --- > > (Updated March 29, 2017, 12:54 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-7226 > https://issues.apache.org/jira/browse/MESOS-7226 > > > Repository: mesos > > > Description > --- > > Add CMake's cotire module to allow for use of PCH (precompiled > headers) during compilation, reducing compilation speed. > > > Diffs > - > > 3rdparty/cmake/cotire.cmake PRE-CREATION > CMakeLists.txt 0d1e17b863856287b18fd026e1ae71ec35e5ad83 > LICENSE f11970cada909e7bbb685f96cb9ef0ff24e01924 > > > Diff: https://reviews.apache.org/r/58011/diff/1/ > > > Testing > --- > > Testing done at end of chain > > > Thanks, > > Jeff Coffler > >
Re: Review Request 58011: CMake: Add Cotire module (version 1.7.9).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58011/#review170439 --- Ship it! I'm going to tweak the commit description because I'm sure you meant "reducing compilation time" rather than "reducing compilation speed" ;) - Joseph Wu On March 28, 2017, 5:54 p.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58011/ > --- > > (Updated March 28, 2017, 5:54 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-7226 > https://issues.apache.org/jira/browse/MESOS-7226 > > > Repository: mesos > > > Description > --- > > Add CMake's cotire module to allow for use of PCH (precompiled > headers) during compilation, reducing compilation speed. > > > Diffs > - > > 3rdparty/cmake/cotire.cmake PRE-CREATION > CMakeLists.txt 0d1e17b863856287b18fd026e1ae71ec35e5ad83 > LICENSE f11970cada909e7bbb685f96cb9ef0ff24e01924 > > > Diff: https://reviews.apache.org/r/58011/diff/1/ > > > Testing > --- > > Testing done at end of chain > > > Thanks, > > Jeff Coffler > >
Review Request 58011: CMake: Add Cotire module (version 1.7.9).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58011/ --- Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li. Bugs: MESOS-7226 https://issues.apache.org/jira/browse/MESOS-7226 Repository: mesos Description --- Add CMake's cotire module to allow for use of PCH (precompiled headers) during compilation, reducing compilation speed. Diffs - 3rdparty/cmake/cotire.cmake PRE-CREATION CMakeLists.txt 0d1e17b863856287b18fd026e1ae71ec35e5ad83 LICENSE f11970cada909e7bbb685f96cb9ef0ff24e01924 Diff: https://reviews.apache.org/r/58011/diff/1/ Testing --- Testing done at end of chain Thanks, Jeff Coffler
