Re: Review Request 58021: Added storage-related offer operations.

2017-04-03 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58021/
---

(Updated April 3, 2017, 10:41 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-7314
https://issues.apache.org/jira/browse/MESOS-7314


Repository: mesos


Description (updated)
---

See summary.


Diffs
-

  include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac 
  include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c 
  src/common/protobuf_utils.cpp 3fcaf786b29a00f003c10b0f1614a2c7eddc725d 
  src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a 
  src/master/master.cpp ab071f56a66ae66c97a185b2377a9cfe9a5c1ade 
  src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11 


Diff: https://reviews.apache.org/r/58021/diff/2/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 58021: Added storage-related offer operations.

2017-04-03 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58021/
---

(Updated April 3, 2017, 10:41 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Rebased.


Summary (updated)
-

Added storage-related offer operations.


Bugs: MESOS-7314
https://issues.apache.org/jira/browse/MESOS-7314


Repository: mesos


Description (updated)
---

Added storage-related offer operations.


Diffs (updated)
-

  include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac 
  include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c 
  src/common/protobuf_utils.cpp 3fcaf786b29a00f003c10b0f1614a2c7eddc725d 
  src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a 
  src/master/master.cpp ab071f56a66ae66c97a185b2377a9cfe9a5c1ade 
  src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11 


Diff: https://reviews.apache.org/r/58021/diff/2/

Changes: https://reviews.apache.org/r/58021/diff/1-2/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 58021: Added storage-related offer operations.

2017-04-03 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58021/
---

(Updated April 3, 2017, 12:25 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Changed review chain order.


Bugs: MESOS-7314
https://issues.apache.org/jira/browse/MESOS-7314


Repository: mesos


Description
---

See summary.


Diffs
-

  include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac 
  include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c 
  src/common/protobuf_utils.cpp 3fcaf786b29a00f003c10b0f1614a2c7eddc725d 
  src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a 
  src/master/master.cpp ab071f56a66ae66c97a185b2377a9cfe9a5c1ade 
  src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11 


Diff: https://reviews.apache.org/r/58021/diff/2/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 58021: Added storage-related offer operations.

2017-04-04 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58021/
---

(Updated April 4, 2017, 2:47 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Made operations use a single resource. This simplifies resource handling, 
bookkeeping and possible user errors.


Bugs: MESOS-7314
https://issues.apache.org/jira/browse/MESOS-7314


Repository: mesos


Description (updated)
---

Added storage-related offer operations.


Diffs (updated)
-

  include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac 
  include/mesos/v1/mesos.proto 228623155c7f68c0f24d173aacbc6eb734f1382f 
  src/common/protobuf_utils.cpp 3fcaf786b29a00f003c10b0f1614a2c7eddc725d 
  src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a 
  src/master/master.cpp 6a6a570e52d21bfb2443f981e3d7faf8c36f74bc 
  src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11 


Diff: https://reviews.apache.org/r/58021/diff/3/

Changes: https://reviews.apache.org/r/58021/diff/2-3/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 58021: Added storage-related offer operations.

2017-04-18 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58021/#review172176
---




src/common/protobuf_utils.cpp
Lines 435-448 (original), 435-452 (patched)


why pull those outside the function? Can we still keep them inside 
injectAllocationInfo?



src/common/protobuf_utils.cpp
Lines 577-581 (patched)


Ditto here.


- Jie Yu


On April 4, 2017, 12:47 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58021/
> ---
> 
> (Updated April 4, 2017, 12:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-7314
> https://issues.apache.org/jira/browse/MESOS-7314
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added storage-related offer operations.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac 
>   include/mesos/v1/mesos.proto 228623155c7f68c0f24d173aacbc6eb734f1382f 
>   src/common/protobuf_utils.cpp 3fcaf786b29a00f003c10b0f1614a2c7eddc725d 
>   src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a 
>   src/master/master.cpp 6a6a570e52d21bfb2443f981e3d7faf8c36f74bc 
>   src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11 
> 
> 
> Diff: https://reviews.apache.org/r/58021/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 58021: Added storage-related offer operations.

2017-04-25 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58021/
---

(Updated April 25, 2017, 9:47 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Addressed issues.


Bugs: MESOS-7314
https://issues.apache.org/jira/browse/MESOS-7314


Repository: mesos


Description
---

Added storage-related offer operations.


Diffs (updated)
-

  include/mesos/mesos.proto 0087343e3e441cfceff154d4a701298ccbe94c85 
  include/mesos/v1/mesos.proto a4426c4053460cf486534804f879feadff1bbadb 
  src/common/protobuf_utils.cpp 3fcaf786b29a00f003c10b0f1614a2c7eddc725d 
  src/common/resources.cpp 77bac0c4390da905016a942991b14a79877f8455 
  src/master/master.cpp d1cdc35a066e190ef8e0bd788e07e63b92f7fce7 
  src/v1/resources.cpp 2e6b298b1f5b7728b908a4800d6495ad26aedc1d 


Diff: https://reviews.apache.org/r/58021/diff/4/

Changes: https://reviews.apache.org/r/58021/diff/3-4/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 58021: Added storage-related offer operations.

2017-08-08 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58021/
---

(Updated Aug. 8, 2017, 10:21 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-7314
https://issues.apache.org/jira/browse/MESOS-7314


Repository: mesos


Description
---

Added storage-related offer operations.


Diffs (updated)
-

  include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461 
  include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa 
  src/common/protobuf_utils.cpp 3ae68e93a985a4cfe23be9c9bd8f92e418102a39 
  src/common/resources.cpp 8d4388935ada6be60448e6f6a88db0e5fc4ad4a1 
  src/common/resources_utils.cpp 821bd0967d55f7fbcb57a4efae5fc390af53ca79 
  src/master/master.cpp 7f38a5e21884546d4b4c866ca5918db779af8f99 
  src/v1/resources.cpp 508f3f85c8388a41f57f964b0f6df3b4708d3442 


Diff: https://reviews.apache.org/r/58021/diff/5/

Changes: https://reviews.apache.org/r/58021/diff/4-5/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 58021: Added storage-related offer operations.

2017-08-28 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58021/#review183971
---




src/common/protobuf_utils.cpp
Line 442 (original), 442 (patched)


I'd see if we can avoid changing `inject` to different methods based on the 
type. See if something like the following will work or not:

```
struct Injector
{
  void operator()(
  Resource& resource,
  const Reosurce::AllocationInfo& allocationInfo)
  { ... }
  
  void operator()(
  RepeatedPtrField* resources,
  const Reosurce::AllocationInfo& allocationInfo)
  { ... }
} inject;
```


- Jie Yu


On Aug. 8, 2017, 8:21 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58021/
> ---
> 
> (Updated Aug. 8, 2017, 8:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-7314
> https://issues.apache.org/jira/browse/MESOS-7314
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added storage-related offer operations.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461 
>   include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa 
>   src/common/protobuf_utils.cpp 3ae68e93a985a4cfe23be9c9bd8f92e418102a39 
>   src/common/resources.cpp 8d4388935ada6be60448e6f6a88db0e5fc4ad4a1 
>   src/common/resources_utils.cpp 821bd0967d55f7fbcb57a4efae5fc390af53ca79 
>   src/master/master.cpp 7f38a5e21884546d4b4c866ca5918db779af8f99 
>   src/v1/resources.cpp 508f3f85c8388a41f57f964b0f6df3b4708d3442 
> 
> 
> Diff: https://reviews.apache.org/r/58021/diff/5/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 58021: Added storage-related offer operations.

2017-08-29 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58021/
---

(Updated Aug. 29, 2017, 3:23 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Addressed issues.


Bugs: MESOS-7314
https://issues.apache.org/jira/browse/MESOS-7314


Repository: mesos


Description
---

Added storage-related offer operations.


Diffs (updated)
-

  include/mesos/mesos.proto 86936cf9ad9406fa4c3358ccb3c58e2f3259d65f 
  include/mesos/v1/mesos.proto 20d9ecff68465c6517a5a239a4bd0f42f82d0cc6 
  src/common/protobuf_utils.cpp 3ae68e93a985a4cfe23be9c9bd8f92e418102a39 
  src/common/resources.cpp 8d4388935ada6be60448e6f6a88db0e5fc4ad4a1 
  src/common/resources_utils.cpp 821bd0967d55f7fbcb57a4efae5fc390af53ca79 
  src/master/master.cpp 183f53070848853b50bfb02bcd6b458ac0b2f685 
  src/v1/resources.cpp 508f3f85c8388a41f57f964b0f6df3b4708d3442 


Diff: https://reviews.apache.org/r/58021/diff/6/

Changes: https://reviews.apache.org/r/58021/diff/5-6/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 58021: Added storage-related offer operations.

2017-08-30 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58021/#review184228
---


Fix it, then Ship it!





src/common/protobuf_utils.cpp
Lines 532-538 (original), 574-584 (patched)


Can you change this too? like what we did for inject?


- Jie Yu


On Aug. 29, 2017, 1:23 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58021/
> ---
> 
> (Updated Aug. 29, 2017, 1:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-7314
> https://issues.apache.org/jira/browse/MESOS-7314
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added storage-related offer operations.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 86936cf9ad9406fa4c3358ccb3c58e2f3259d65f 
>   include/mesos/v1/mesos.proto 20d9ecff68465c6517a5a239a4bd0f42f82d0cc6 
>   src/common/protobuf_utils.cpp 3ae68e93a985a4cfe23be9c9bd8f92e418102a39 
>   src/common/resources.cpp 8d4388935ada6be60448e6f6a88db0e5fc4ad4a1 
>   src/common/resources_utils.cpp 821bd0967d55f7fbcb57a4efae5fc390af53ca79 
>   src/master/master.cpp 183f53070848853b50bfb02bcd6b458ac0b2f685 
>   src/v1/resources.cpp 508f3f85c8388a41f57f964b0f6df3b4708d3442 
> 
> 
> Diff: https://reviews.apache.org/r/58021/diff/6/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 58021: Added storage-related offer operations.

2017-08-31 Thread Jan Schlicht 


> On Aug. 31, 2017, 4:14 a.m., Jie Yu wrote:
> > src/common/protobuf_utils.cpp
> > Lines 532-538 (original), 574-584 (patched)
> > 
> >
> > Can you change this too? like what we did for inject?

Oh, of course. Not sure how I could miss that.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58021/#review184228
---


On Aug. 29, 2017, 3:23 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58021/
> ---
> 
> (Updated Aug. 29, 2017, 3:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-7314
> https://issues.apache.org/jira/browse/MESOS-7314
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added storage-related offer operations.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 86936cf9ad9406fa4c3358ccb3c58e2f3259d65f 
>   include/mesos/v1/mesos.proto 20d9ecff68465c6517a5a239a4bd0f42f82d0cc6 
>   src/common/protobuf_utils.cpp 3ae68e93a985a4cfe23be9c9bd8f92e418102a39 
>   src/common/resources.cpp 8d4388935ada6be60448e6f6a88db0e5fc4ad4a1 
>   src/common/resources_utils.cpp 821bd0967d55f7fbcb57a4efae5fc390af53ca79 
>   src/master/master.cpp 183f53070848853b50bfb02bcd6b458ac0b2f685 
>   src/v1/resources.cpp 508f3f85c8388a41f57f964b0f6df3b4708d3442 
> 
> 
> Diff: https://reviews.apache.org/r/58021/diff/6/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 58021: Added storage-related offer operations.

2017-08-31 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58021/
---

(Updated Aug. 31, 2017, 1:33 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Addressed issues.


Bugs: MESOS-7314
https://issues.apache.org/jira/browse/MESOS-7314


Repository: mesos


Description
---

Added storage-related offer operations.


Diffs (updated)
-

  include/mesos/mesos.proto eede0827fc0da5f2fa3cfb432fde29b95a8c644c 
  include/mesos/v1/mesos.proto 8c6246ee824f28d93dc5b57d25939d1ba76c986b 
  src/common/protobuf_utils.cpp 3ae68e93a985a4cfe23be9c9bd8f92e418102a39 
  src/common/resources.cpp 8d4388935ada6be60448e6f6a88db0e5fc4ad4a1 
  src/common/resources_utils.cpp 821bd0967d55f7fbcb57a4efae5fc390af53ca79 
  src/master/master.cpp 4fa05fa309e4302d18cb9557a4730bd5f8dd29e6 
  src/v1/resources.cpp 508f3f85c8388a41f57f964b0f6df3b4708d3442 


Diff: https://reviews.apache.org/r/58021/diff/7/

Changes: https://reviews.apache.org/r/58021/diff/6-7/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 58021: Added storage-related offer operations.

2017-09-06 Thread James DeFelice 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58021/#review184731
---




include/mesos/mesos.proto
Lines 1835 (patched)


I'd love to see documentation for these new operations to distinguish them 
from the CREATE and DESTROY operations


- James DeFelice


On Aug. 31, 2017, 11:33 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58021/
> ---
> 
> (Updated Aug. 31, 2017, 11:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-7314
> https://issues.apache.org/jira/browse/MESOS-7314
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added storage-related offer operations.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto eede0827fc0da5f2fa3cfb432fde29b95a8c644c 
>   include/mesos/v1/mesos.proto 8c6246ee824f28d93dc5b57d25939d1ba76c986b 
>   src/common/protobuf_utils.cpp 3ae68e93a985a4cfe23be9c9bd8f92e418102a39 
>   src/common/resources.cpp 8d4388935ada6be60448e6f6a88db0e5fc4ad4a1 
>   src/common/resources_utils.cpp 821bd0967d55f7fbcb57a4efae5fc390af53ca79 
>   src/master/master.cpp 4fa05fa309e4302d18cb9557a4730bd5f8dd29e6 
>   src/v1/resources.cpp 508f3f85c8388a41f57f964b0f6df3b4708d3442 
> 
> 
> Diff: https://reviews.apache.org/r/58021/diff/7/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 58021: Added storage-related offer operations.

2017-09-06 Thread Jie Yu 


> On Sept. 6, 2017, 8:55 p.m., James DeFelice wrote:
> > include/mesos/mesos.proto
> > Lines 1835 (patched)
> > 
> >
> > I'd love to see documentation for these new operations to distinguish 
> > them from the CREATE and DESTROY operations

Yeah, this is WIP. Will definitely follow up with docs for that. We'll likely 
introduce alias for existing CREATE/DESTROY


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58021/#review184731
---


On Aug. 31, 2017, 11:33 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58021/
> ---
> 
> (Updated Aug. 31, 2017, 11:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-7314
> https://issues.apache.org/jira/browse/MESOS-7314
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added storage-related offer operations.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto eede0827fc0da5f2fa3cfb432fde29b95a8c644c 
>   include/mesos/v1/mesos.proto 8c6246ee824f28d93dc5b57d25939d1ba76c986b 
>   src/common/protobuf_utils.cpp 3ae68e93a985a4cfe23be9c9bd8f92e418102a39 
>   src/common/resources.cpp 8d4388935ada6be60448e6f6a88db0e5fc4ad4a1 
>   src/common/resources_utils.cpp 821bd0967d55f7fbcb57a4efae5fc390af53ca79 
>   src/master/master.cpp 4fa05fa309e4302d18cb9557a4730bd5f8dd29e6 
>   src/v1/resources.cpp 508f3f85c8388a41f57f964b0f6df3b4708d3442 
> 
> 
> Diff: https://reviews.apache.org/r/58021/diff/7/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>