Re: Review Request 58357: Support more test frameworks in test-upgrade script.

2017-04-19 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/
---

(Updated April 19, 2017, 4:28 p.m.)


Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.


Changes
---

Greg's review comments.


Summary (updated)
-

Support more test frameworks in test-upgrade script.


Bugs: MESOS-7228
https://issues.apache.org/jira/browse/MESOS-7228


Repository: mesos


Description (updated)
---

This patch added support to java and python based test framework in
`test-upgrade.py` script.


Diffs (updated)
-

  support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45 


Diff: https://reviews.apache.org/r/58357/diff/3/

Changes: https://reviews.apache.org/r/58357/diff/2-3/


Testing
---

Ran this on all three languages options for cpp, java and python.


Thanks,

Zhitao Li

Re: Review Request 58357: Support more test frameworks in test-upgrade script.

2017-04-19 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review172403
---



Patch looks great!

Reviews applied: [58357]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On April 19, 2017, 4:28 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> ---
> 
> (Updated April 19, 2017, 4:28 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
> 
> 
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added support to java and python based test framework in
> `test-upgrade.py` script.
> 
> 
> Diffs
> -
> 
>   support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45 
> 
> 
> Diff: https://reviews.apache.org/r/58357/diff/3/
> 
> 
> Testing
> ---
> 
> Ran this on all three languages options for cpp, java and python.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 58357: Support more test frameworks in test-upgrade script.

2017-04-20 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review172551
---



Tested this out; works great!! Just a couple small things below.


support/test-upgrade.py
Lines 298-302 (patched)


Would it be possible to allow the user to exclude more than one at a time? 
I would also be find with the user specifying explicitly a list of the 
frameworks they _do_ want to run.



support/test-upgrade.py
Lines 325-326 (patched)


Could you add an extra newline or two of logging at the end of each 
iteration? It's a bit hard to read the logging output since there are no 
newlines between the end of each framework run.


- Greg Mann


On April 19, 2017, 4:28 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> ---
> 
> (Updated April 19, 2017, 4:28 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
> 
> 
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added support to java and python based test framework in
> `test-upgrade.py` script.
> 
> 
> Diffs
> -
> 
>   support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45 
> 
> 
> Diff: https://reviews.apache.org/r/58357/diff/3/
> 
> 
> Testing
> ---
> 
> Ran this on all three languages options for cpp, java and python.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 58357: Support more test frameworks in test-upgrade script.

2017-04-24 Thread Zhitao Li 


> On April 20, 2017, 9:40 p.m., Greg Mann wrote:
> > support/test-upgrade.py
> > Lines 298-302 (patched)
> > 
> >
> > Would it be possible to allow the user to exclude more than one at a 
> > time? I would also be find with the user specifying explicitly a list of 
> > the frameworks they _do_ want to run.

Yes I can make this a comma separated list.

Do you think we need both of `excluding tests` and `only run tests`?


> On April 20, 2017, 9:40 p.m., Greg Mann wrote:
> > support/test-upgrade.py
> > Lines 325-326 (patched)
> > 
> >
> > Could you add an extra newline or two of logging at the end of each 
> > iteration? It's a bit hard to read the logging output since there are no 
> > newlines between the end of each framework run.

Will do.


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review172551
---


On April 19, 2017, 4:28 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> ---
> 
> (Updated April 19, 2017, 4:28 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
> 
> 
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added support to java and python based test framework in
> `test-upgrade.py` script.
> 
> 
> Diffs
> -
> 
>   support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45 
> 
> 
> Diff: https://reviews.apache.org/r/58357/diff/3/
> 
> 
> Testing
> ---
> 
> Ran this on all three languages options for cpp, java and python.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 58357: Support more test frameworks in test-upgrade script.

2017-04-24 Thread Greg Mann 


> On April 20, 2017, 9:40 p.m., Greg Mann wrote:
> > support/test-upgrade.py
> > Lines 298-302 (patched)
> > 
> >
> > Would it be possible to allow the user to exclude more than one at a 
> > time? I would also be find with the user specifying explicitly a list of 
> > the frameworks they _do_ want to run.
> 
> Zhitao Li wrote:
> Yes I can make this a comma separated list.
> 
> Do you think we need both of `excluding tests` and `only run tests`?

I think just one or the other is fine.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review172551
---


On April 19, 2017, 4:28 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> ---
> 
> (Updated April 19, 2017, 4:28 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
> 
> 
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added support to java and python based test framework in
> `test-upgrade.py` script.
> 
> 
> Diffs
> -
> 
>   support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45 
> 
> 
> Diff: https://reviews.apache.org/r/58357/diff/3/
> 
> 
> Testing
> ---
> 
> Ran this on all three languages options for cpp, java and python.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 58357: Support more test frameworks in test-upgrade script.

2017-04-27 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/
---

(Updated April 27, 2017, 5:58 p.m.)


Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.


Bugs: MESOS-7228
https://issues.apache.org/jira/browse/MESOS-7228


Repository: mesos


Description
---

This patch added support to java and python based test framework in
`test-upgrade.py` script.


Diffs (updated)
-

  support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45 


Diff: https://reviews.apache.org/r/58357/diff/4/

Changes: https://reviews.apache.org/r/58357/diff/3-4/


Testing
---

Ran this on all three languages options for cpp, java and python.


Thanks,

Zhitao Li

Re: Review Request 58357: Support more test frameworks in test-upgrade script.

2017-04-27 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review173277
---


Fix it, then Ship it!





support/test-upgrade.py
Lines 342-343 (patched)


Could you add an extra newline (or two?) at the end of this print 
statement? Currently, the output in between interations has no newline 
separating one run from the next:

```
Test case 4 (Run of next setup)
# Starting mesos 1.3.0 cpp-test-framework #
Waiting for mesos 1.3.0 cpp-test-framework to complete (10 sec max)...
Run ['/mnt/src/mesos/build/src/test-framework', '--master=127.0.0.1:5050'], 
output: /tmp/tmpMNDhg3
mesos 1.3.0 cpp-test-framework succeeded with mesos 1.3.0 master and mesos 
1.3.0 agent
Upgrade test succeeded for framework cpp-test-framework from mesos 1.2.0 to 
mesos 1.3.0
Running upgrade test from mesos 1.2.0 to mesos 1.3.0 for framework 
java-test-framework
+--+++---+
| Test case|   Framework| Master | Agent |
+--+++---+
|#1|  mesos 1.2.0   | mesos 1.2.0| mesos 1.2.0   |
|#2|  mesos 1.2.0   | mesos 1.3.0| mesos 1.2.0   |
|#3|  mesos 1.2.0   | mesos 1.3.0| mesos 1.3.0   |
|#4|  mesos 1.3.0   | mesos 1.3.0| mesos 1.3.0   |
+--+++---+

NOTE: live denotes that master process keeps running from previous case.
```


- Greg Mann


On April 27, 2017, 5:58 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> ---
> 
> (Updated April 27, 2017, 5:58 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
> 
> 
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added support to java and python based test framework in
> `test-upgrade.py` script.
> 
> 
> Diffs
> -
> 
>   support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45 
> 
> 
> Diff: https://reviews.apache.org/r/58357/diff/4/
> 
> 
> Testing
> ---
> 
> Ran this on all three languages options for cpp, java and python.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 58357: Support more test frameworks in test-upgrade script.

2017-04-28 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review173303
---



Patch looks great!

Reviews applied: [58357]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On April 27, 2017, 5:58 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> ---
> 
> (Updated April 27, 2017, 5:58 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
> 
> 
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added support to java and python based test framework in
> `test-upgrade.py` script.
> 
> 
> Diffs
> -
> 
>   support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45 
> 
> 
> Diff: https://reviews.apache.org/r/58357/diff/4/
> 
> 
> Testing
> ---
> 
> Ran this on all three languages options for cpp, java and python.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 58357: Support more test frameworks in test-upgrade script.

2017-04-28 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/
---

(Updated April 29, 2017, 12:17 a.m.)


Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.


Bugs: MESOS-7228
https://issues.apache.org/jira/browse/MESOS-7228


Repository: mesos


Description
---

This patch added support to java and python based test framework in
`test-upgrade.py` script.


Diffs (updated)
-

  support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45 


Diff: https://reviews.apache.org/r/58357/diff/5/

Changes: https://reviews.apache.org/r/58357/diff/4-5/


Testing
---

Ran this on all three languages options for cpp, java and python.


Thanks,

Zhitao Li

Re: Review Request 58357: Support more test frameworks in test-upgrade script.

2017-04-29 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review173424
---



Patch looks great!

Reviews applied: [58357]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On April 29, 2017, 12:17 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> ---
> 
> (Updated April 29, 2017, 12:17 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
> 
> 
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added support to java and python based test framework in
> `test-upgrade.py` script.
> 
> 
> Diffs
> -
> 
>   support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45 
> 
> 
> Diff: https://reviews.apache.org/r/58357/diff/5/
> 
> 
> Testing
> ---
> 
> Ran this on all three languages options for cpp, java and python.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>