Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58449/ --- Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. Repository: mesos Description --- The `SOURCE_SUBDIR` command to `ExternalProject_Add` was added in CMake 3.7.0, and is necessary to most cleanly build an external CMake built project where the `CMakeLists.txt` is in a subfolder of the project. Diffs - CMakeLists.txt ea529ec2d5c2b9be4f19c67c2033c3f4b9073c1f Diff: https://reviews.apache.org/r/58449/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer
Re: Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58449/#review171980 --- Documentation does need to be updated, but it will come in my other branch full of Widnows documentation updates. - Andrew Schwartzmeyer On April 14, 2017, 2:10 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58449/ > --- > > (Updated April 14, 2017, 2:10 a.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Repository: mesos > > > Description > --- > > The `SOURCE_SUBDIR` command to `ExternalProject_Add` was added in CMake > 3.7.0, and is necessary to most cleanly build an external CMake built > project where the `CMakeLists.txt` is in a subfolder of the project. > > > Diffs > - > > CMakeLists.txt ea529ec2d5c2b9be4f19c67c2033c3f4b9073c1f > > > Diff: https://reviews.apache.org/r/58449/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58449/#review171985 --- Patch looks great! Reviews applied: [57898, 58446, 58447, 58448, 58449] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 14, 2017, 2:10 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58449/ > --- > > (Updated April 14, 2017, 2:10 a.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Repository: mesos > > > Description > --- > > The `SOURCE_SUBDIR` command to `ExternalProject_Add` was added in CMake > 3.7.0, and is necessary to most cleanly build an external CMake built > project where the `CMakeLists.txt` is in a subfolder of the project. > > > Diffs > - > > CMakeLists.txt ea529ec2d5c2b9be4f19c67c2033c3f4b9073c1f > > > Diff: https://reviews.apache.org/r/58449/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58449/#review172258 --- Ship it! Ship It! - Jeff Coffler On April 14, 2017, 2:10 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58449/ > --- > > (Updated April 14, 2017, 2:10 a.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Repository: mesos > > > Description > --- > > The `SOURCE_SUBDIR` command to `ExternalProject_Add` was added in CMake > 3.7.0, and is necessary to most cleanly build an external CMake built > project where the `CMakeLists.txt` is in a subfolder of the project. > > > Diffs > - > > CMakeLists.txt ea529ec2d5c2b9be4f19c67c2033c3f4b9073c1f > > > Diff: https://reviews.apache.org/r/58449/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows.
> On April 18, 2017, 8:19 p.m., Jeff Coffler wrote: > > Ship It! Hey, just wondering, why'd you give a "Ship It!" here, but then went back to patches earlier in the chain and asked for test results (provided in the patch previous to this)? - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58449/#review172258 --- On April 14, 2017, 2:10 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58449/ > --- > > (Updated April 14, 2017, 2:10 a.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Repository: mesos > > > Description > --- > > The `SOURCE_SUBDIR` command to `ExternalProject_Add` was added in CMake > 3.7.0, and is necessary to most cleanly build an external CMake built > project where the `CMakeLists.txt` is in a subfolder of the project. > > > Diffs > - > > CMakeLists.txt ea529ec2d5c2b9be4f19c67c2033c3f4b9073c1f > > > Diff: https://reviews.apache.org/r/58449/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows.
> On April 18, 2017, 8:19 p.m., Jeff Coffler wrote: > > Ship It! > > Andrew Schwartzmeyer wrote: > Hey, just wondering, why'd you give a "Ship It!" here, but then went back > to patches earlier in the chain and asked for test results (provided in the > patch previous to this)? I'd like to chat with you about this. From my look with Review Board, I now don't see "test results" here. I thought I did before. I think I'm confused about how Review Board works. Stop by when you get in and explain what I'm missing, thanks! - Jeff --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58449/#review172258 --- On April 14, 2017, 2:10 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58449/ > --- > > (Updated April 14, 2017, 2:10 a.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Repository: mesos > > > Description > --- > > The `SOURCE_SUBDIR` command to `ExternalProject_Add` was added in CMake > 3.7.0, and is necessary to most cleanly build an external CMake built > project where the `CMakeLists.txt` is in a subfolder of the project. > > > Diffs > - > > CMakeLists.txt ea529ec2d5c2b9be4f19c67c2033c3f4b9073c1f > > > Diff: https://reviews.apache.org/r/58449/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows.
> On April 18, 2017, 8:19 p.m., Jeff Coffler wrote: > > Ship It! > > Andrew Schwartzmeyer wrote: > Hey, just wondering, why'd you give a "Ship It!" here, but then went back > to patches earlier in the chain and asked for test results (provided in the > patch previous to this)? > > Jeff Coffler wrote: > I'd like to chat with you about this. From my look with Review Board, I > now don't see "test results" here. I thought I did before. > > I think I'm confused about how Review Board works. Stop by when you get > in and explain what I'm missing, thanks! Sure thing :) - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58449/#review172258 --- On April 14, 2017, 2:10 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58449/ > --- > > (Updated April 14, 2017, 2:10 a.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Repository: mesos > > > Description > --- > > The `SOURCE_SUBDIR` command to `ExternalProject_Add` was added in CMake > 3.7.0, and is necessary to most cleanly build an external CMake built > project where the `CMakeLists.txt` is in a subfolder of the project. > > > Diffs > - > > CMakeLists.txt ea529ec2d5c2b9be4f19c67c2033c3f4b9073c1f > > > Diff: https://reviews.apache.org/r/58449/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58449/#review173019 --- Ship it! Confirmed that this review chain works with a clean build (after re-installing MSVC to 2017 and CMake to 3.8) - Joseph Wu On April 13, 2017, 7:10 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58449/ > --- > > (Updated April 13, 2017, 7:10 p.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Repository: mesos > > > Description > --- > > The `SOURCE_SUBDIR` command to `ExternalProject_Add` was added in CMake > 3.7.0, and is necessary to most cleanly build an external CMake built > project where the `CMakeLists.txt` is in a subfolder of the project. > > > Diffs > - > > CMakeLists.txt ea529ec2d5c2b9be4f19c67c2033c3f4b9073c1f > > > Diff: https://reviews.apache.org/r/58449/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
