Re: Review Request 58759: Introduced SecretFetcher module interface.

[Kapil Arya]

> On May 4, 2017, 6:25 p.m., Jie Yu wrote:
> > include/mesos/module/secretfetcher.hpp
> > Lines 17 (patched)
> > 
> >
> > secret_fetcher.hpp
> > 
> > (we have secret_generator.hpp). Let's make sure it's consistent.

I'll update it to secret_fetcher.hpp. However, please note that there is still 
some inconsistency here: the module interface is called `SecretGenerator` but 
the file is named `secret_generator.hpp`.


> On May 4, 2017, 6:25 p.m., Jie Yu wrote:
> > include/mesos/secret/fetcher.hpp
> > Lines 17 (patched)
> > 
> >
> > I'd put the file to include/mesos/fetcher/secret_fetcher.hpp
> 
> Kapil Arya wrote:
> I am not sure so sure about it because there is nothing in common between 
> `Fetcher` and `SecretFetcher`. One can think of `SecretFetcher` as more like 
> secret-resolver.
> 
> Perhaps, next to authentication/secret_generator.hpp would be slightly 
> better, but then it doesn't have much to do with authentication either.
> 
> Jie Yu wrote:
> OK, i am fine with secret/fetcher.hpp. Make sure it's consistent with the 
> cpp file.

I am not sure what you mean by "Make sure it's consistent with the cpp file"?


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review173966
---


On May 4, 2017, 4:06 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58759/
> ---
> 
> (Updated May 4, 2017, 4:06 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced SecretFetcher module interface.
> 
> 
> Diffs
> -
> 
>   include/mesos/module/secretfetcher.hpp PRE-CREATION 
>   include/mesos/secret/fetcher.hpp PRE-CREATION 
>   src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
>   src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 
> 
> 
> Diff: https://reviews.apache.org/r/58759/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58759: Introduced SecretFetcher module interface.

[Jie Yu]

> On May 4, 2017, 10:25 p.m., Jie Yu wrote:
> > include/mesos/secret/fetcher.hpp
> > Lines 17 (patched)
> > 
> >
> > I'd put the file to include/mesos/fetcher/secret_fetcher.hpp
> 
> Kapil Arya wrote:
> I am not sure so sure about it because there is nothing in common between 
> `Fetcher` and `SecretFetcher`. One can think of `SecretFetcher` as more like 
> secret-resolver.
> 
> Perhaps, next to authentication/secret_generator.hpp would be slightly 
> better, but then it doesn't have much to do with authentication either.

OK, i am fine with secret/fetcher.hpp. Make sure it's consistent with the cpp 
file.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review173966
---


On May 4, 2017, 8:06 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58759/
> ---
> 
> (Updated May 4, 2017, 8:06 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced SecretFetcher module interface.
> 
> 
> Diffs
> -
> 
>   include/mesos/module/secretfetcher.hpp PRE-CREATION 
>   include/mesos/secret/fetcher.hpp PRE-CREATION 
>   src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
>   src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 
> 
> 
> Diff: https://reviews.apache.org/r/58759/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58759: Introduced SecretFetcher module interface.

[Kapil Arya]

> On May 4, 2017, 6:25 p.m., Jie Yu wrote:
> > include/mesos/secret/fetcher.hpp
> > Lines 17 (patched)
> > 
> >
> > I'd put the file to include/mesos/fetcher/secret_fetcher.hpp

I am not sure so sure about it because there is nothing in common between 
`Fetcher` and `SecretFetcher`. One can think of `SecretFetcher` as more like 
secret-resolver.

Perhaps, next to authentication/secret_generator.hpp would be slightly better, 
but then it doesn't have much to do with authentication either.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review173966
---


On May 4, 2017, 4:06 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58759/
> ---
> 
> (Updated May 4, 2017, 4:06 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced SecretFetcher module interface.
> 
> 
> Diffs
> -
> 
>   include/mesos/module/secretfetcher.hpp PRE-CREATION 
>   include/mesos/secret/fetcher.hpp PRE-CREATION 
>   src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
>   src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 
> 
> 
> Diff: https://reviews.apache.org/r/58759/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58759: Introduced SecretFetcher module interface.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review173966
---




include/mesos/module/secretfetcher.hpp
Lines 17 (patched)


secret_fetcher.hpp

(we have secret_generator.hpp). Let's make sure it's consistent.



include/mesos/secret/fetcher.hpp
Lines 17 (patched)


I'd put the file to include/mesos/fetcher/secret_fetcher.hpp


- Jie Yu


On May 4, 2017, 8:06 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58759/
> ---
> 
> (Updated May 4, 2017, 8:06 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced SecretFetcher module interface.
> 
> 
> Diffs
> -
> 
>   include/mesos/module/secretfetcher.hpp PRE-CREATION 
>   include/mesos/secret/fetcher.hpp PRE-CREATION 
>   src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
>   src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 
> 
> 
> Diff: https://reviews.apache.org/r/58759/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58759: Introduced SecretFetcher module interface.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/
---

(Updated May 4, 2017, 4:06 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
---

Addressed Vinod's comments.


Bugs: MESOS-7418
https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description
---

Introduced SecretFetcher module interface.


Diffs (updated)
-

  include/mesos/module/secretfetcher.hpp PRE-CREATION 
  include/mesos/secret/fetcher.hpp PRE-CREATION 
  src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
  src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 


Diff: https://reviews.apache.org/r/58759/diff/3/

Changes: https://reviews.apache.org/r/58759/diff/2-3/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 58759: Introduced SecretFetcher module interface.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review173514
---




include/mesos/secret/secretfetcher.hpp
Lines 27 (patched)


Should this be just called `Fetcher` since it is in the `secret` namespace 
already? Looks like this is how URI, APPC etc fetchers are named.


- Vinod Kone


On April 28, 2017, 6:50 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58759/
> ---
> 
> (Updated April 28, 2017, 6:50 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced SecretFetcher module interface.
> 
> 
> Diffs
> -
> 
>   include/mesos/module/secretfetcher.hpp PRE-CREATION 
>   include/mesos/secret/secretfetcher.hpp PRE-CREATION 
>   src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
>   src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 
> 
> 
> Diff: https://reviews.apache.org/r/58759/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58759: Introduced SecretFetcher module interface.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/
---

(Updated April 28, 2017, 2:50 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Bugs: MESOS-7418
https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description
---

Introduced SecretFetcher module interface.


Diffs (updated)
-

  include/mesos/module/secretfetcher.hpp PRE-CREATION 
  include/mesos/secret/secretfetcher.hpp PRE-CREATION 
  src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
  src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 


Diff: https://reviews.apache.org/r/58759/diff/2/

Changes: https://reviews.apache.org/r/58759/diff/1-2/


Testing
---


Thanks,

Kapil Arya

Review Request 58759: Introduced SecretFetcher module interface.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/
---

Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

Introduced SecretFetcher module interface.


Diffs
-

  include/mesos/module/secretfetcher.hpp PRE-CREATION 
  include/mesos/secret/secretfetcher.hpp PRE-CREATION 
  src/Makefile.am 1fc453c497f278c9fc3fa5e91eb720a932915fde 
  src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 


Diff: https://reviews.apache.org/r/58759/diff/1/


Testing
---


Thanks,

Kapil Arya