Re: Review Request 58910: Addressed a TODO about checkpointing in tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58910/#review174663 --- Ship it! Ship It! - Jie Yu On May 11, 2017, 12:26 a.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58910/ > --- > > (Updated May 11, 2017, 12:26 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-7449 > https://issues.apache.org/jira/browse/MESOS-7449 > > > Repository: mesos > > > Description > --- > > Checkpointing only plays a role in tests when the containerizer > is destroyed and subsequently recovered. This commit updates a > couple of test files to the new containerizer interface and > also turns checkpointing _off_ in tests which do not perform any > containerizer recovery. > > > Diffs > - > > src/tests/containerizer/io_switchboard_tests.cpp > b19961ee91af3c174d4377c2514465d6c99cf331 > src/tests/containerizer/mesos_containerizer_tests.cpp > 13e0f7e603a3ffdd0965b253d7abfe6a069cd2b4 > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > c163b882fb2fc463537d6906c5a47b24a9a756c4 > src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp > 5f4e382baf80439b9a61f22c1912cadeba1109b7 > > > Diff: https://reviews.apache.org/r/58910/diff/3/ > > > Testing > --- > > See last patch in chain. > > > Thanks, > > Joseph Wu > >
Re: Review Request 58910: Addressed a TODO about checkpointing in tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58910/ --- (Updated May 10, 2017, 5:26 p.m.) Review request for mesos and Jie Yu. Changes --- Fixed up some typos. Bugs: MESOS-7449 https://issues.apache.org/jira/browse/MESOS-7449 Repository: mesos Description --- Checkpointing only plays a role in tests when the containerizer is destroyed and subsequently recovered. This commit updates a couple of test files to the new containerizer interface and also turns checkpointing _off_ in tests which do not perform any containerizer recovery. Diffs (updated) - src/tests/containerizer/io_switchboard_tests.cpp b19961ee91af3c174d4377c2514465d6c99cf331 src/tests/containerizer/mesos_containerizer_tests.cpp 13e0f7e603a3ffdd0965b253d7abfe6a069cd2b4 src/tests/containerizer/nested_mesos_containerizer_tests.cpp c163b882fb2fc463537d6906c5a47b24a9a756c4 src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp 5f4e382baf80439b9a61f22c1912cadeba1109b7 Diff: https://reviews.apache.org/r/58910/diff/3/ Changes: https://reviews.apache.org/r/58910/diff/2-3/ Testing --- See last patch in chain. Thanks, Joseph Wu
Re: Review Request 58910: Addressed a TODO about checkpointing in tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58910/ --- (Updated May 8, 2017, 4:22 p.m.) Review request for mesos and Jie Yu. Changes --- Split part of this patch into two other patches. Two patches contain refactoring plus slight tweaks in functionality. The last patch contains only refactoring. Summary (updated) - Addressed a TODO about checkpointing in tests. Bugs: MESOS-7449 https://issues.apache.org/jira/browse/MESOS-7449 Repository: mesos Description (updated) --- Checkpointing only plays a role in tests when the containerizer is destroyed and subsequently recovered. This commit updates a couple of test files to the new containerizer interface and also turns checkpointing _off_ in tests which do not perform any containerizer recovery. Diffs (updated) - src/tests/containerizer/io_switchboard_tests.cpp b19961ee91af3c174d4377c2514465d6c99cf331 src/tests/containerizer/mesos_containerizer_tests.cpp 13e0f7e603a3ffdd0965b253d7abfe6a069cd2b4 src/tests/containerizer/nested_mesos_containerizer_tests.cpp c163b882fb2fc463537d6906c5a47b24a9a756c4 src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp 5f4e382baf80439b9a61f22c1912cadeba1109b7 Diff: https://reviews.apache.org/r/58910/diff/2/ Changes: https://reviews.apache.org/r/58910/diff/1-2/ Testing (updated) --- See last patch in chain. Thanks, Joseph Wu
